| Message ID | 20240813-b4-upstream-j721s2-avs-v3-3-5115d93cdeb2@ti.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Add AVS support for J721S2 | expand |
On 8/13/2024 11:40 AM, Manorit Chawdhry wrote: > MPU clock had been missing. Distinguish multiple clocks with clock-names > and add MPU clock as well. > > Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com> > --- > arch/arm/dts/k3-am69-r5-sk.dts | 3 ++- > arch/arm/dts/k3-j7200-r5-common-proc-board.dts | 3 ++- > arch/arm/dts/k3-j721e-r5.dtsi | 3 ++- > arch/arm/dts/k3-j721s2-r5.dtsi | 3 ++- > arch/arm/dts/k3-j784s4-r5-evm.dts | 3 ++- > 5 files changed, 10 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/dts/k3-am69-r5-sk.dts b/arch/arm/dts/k3-am69-r5-sk.dts > index f177f563527f..9bbf76d8bf35 100644 > --- a/arch/arm/dts/k3-am69-r5-sk.dts > +++ b/arch/arm/dts/k3-am69-r5-sk.dts > @@ -26,7 +26,8 @@ > power-domains = <&k3_pds 61 TI_SCI_PD_EXCLUSIVE>, > <&k3_pds 202 TI_SCI_PD_EXCLUSIVE>; > resets = <&k3_reset 202 0>; > - clocks = <&k3_clks 61 0>; > + clocks = <&k3_clks 61 0>, <&k3_clks 202 0>; Thanks for catching this Could we think of having SOC specific R5 dt , So that we don't need to update such SOC information at each board level Similar to what is done (k3-j721e-r5.dtsi) > + clock-names = "gtc", "core"; > assigned-clocks = <&k3_clks 61 0>, <&k3_clks 202 0>; > assigned-clock-parents = <&k3_clks 61 2>; > assigned-clock-rates = <200000000>, <2000000000>; > diff --git a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts > index fb7e2e502392..e6da86f3cd10 100644 > --- a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts > +++ b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts > @@ -23,7 +23,8 @@ > <&k3_pds 202 TI_SCI_PD_EXCLUSIVE>, > <&k3_pds 4 TI_SCI_PD_EXCLUSIVE>; > resets = <&k3_reset 202 0>; > - clocks = <&k3_clks 61 1>; > + clocks = <&k3_clks 61 1>, <&k3_clks 202 2>; > + clock-names = "gtc", "core"; > assigned-clocks = <&k3_clks 202 2>, <&k3_clks 61 1>, <&k3_clks 323 0>; > assigned-clock-parents= <0>, <0>, <&k3_clks 323 2>; > assigned-clock-rates = <2000000000>, <200000000>; > diff --git a/arch/arm/dts/k3-j721e-r5.dtsi b/arch/arm/dts/k3-j721e-r5.dtsi > index fd0d921272c5..688a6cf40892 100644 > --- a/arch/arm/dts/k3-j721e-r5.dtsi > +++ b/arch/arm/dts/k3-j721e-r5.dtsi > @@ -20,7 +20,8 @@ > <&k3_pds 202 TI_SCI_PD_EXCLUSIVE>, > <&k3_pds 4 TI_SCI_PD_EXCLUSIVE>; > resets = <&k3_reset 202 0>; > - clocks = <&k3_clks 61 1>; > + clocks = <&k3_clks 61 1>, <&k3_clks 202 2>; > + clock-names = "gtc", "core"; > assigned-clocks = <&k3_clks 202 2>, <&k3_clks 61 1>; > assigned-clock-rates = <2000000000>, <200000000>; > ti,sci = <&dmsc>; > diff --git a/arch/arm/dts/k3-j721s2-r5.dtsi b/arch/arm/dts/k3-j721s2-r5.dtsi > index caf696c2d960..634676c8491e 100644 > --- a/arch/arm/dts/k3-j721s2-r5.dtsi > +++ b/arch/arm/dts/k3-j721s2-r5.dtsi > @@ -20,7 +20,8 @@ > <&k3_pds 202 TI_SCI_PD_EXCLUSIVE>, > <&k3_pds 4 TI_SCI_PD_EXCLUSIVE>; > resets = <&k3_reset 202 0>; > - clocks = <&k3_clks 61 1>; > + clocks = <&k3_clks 61 1>, <&k3_clks 202 0>; > + clock-names = "gtc", "core"; > assigned-clocks = <&k3_clks 61 1>, <&k3_clks 202 0>; > assigned-clock-parents = <&k3_clks 61 3>; > assigned-clock-rates = <200000000>, <2000000000>; > diff --git a/arch/arm/dts/k3-j784s4-r5-evm.dts b/arch/arm/dts/k3-j784s4-r5-evm.dts > index bef4573d3d20..306d2007f89e 100644 > --- a/arch/arm/dts/k3-j784s4-r5-evm.dts > +++ b/arch/arm/dts/k3-j784s4-r5-evm.dts > @@ -26,7 +26,8 @@ > power-domains = <&k3_pds 61 TI_SCI_PD_EXCLUSIVE>, > <&k3_pds 202 TI_SCI_PD_EXCLUSIVE>; > resets = <&k3_reset 202 0>; > - clocks = <&k3_clks 61 0>; > + clocks = <&k3_clks 61 0>, <&k3_clks 202 0>; > + clock-names = "gtc", "core"; > assigned-clocks = <&k3_clks 61 0>, <&k3_clks 202 0>; > assigned-clock-parents = <&k3_clks 61 2>; > assigned-clock-rates = <200000000>, <2000000000>; >
diff --git a/arch/arm/dts/k3-am69-r5-sk.dts b/arch/arm/dts/k3-am69-r5-sk.dts index f177f563527f..9bbf76d8bf35 100644 --- a/arch/arm/dts/k3-am69-r5-sk.dts +++ b/arch/arm/dts/k3-am69-r5-sk.dts @@ -26,7 +26,8 @@ power-domains = <&k3_pds 61 TI_SCI_PD_EXCLUSIVE>, <&k3_pds 202 TI_SCI_PD_EXCLUSIVE>; resets = <&k3_reset 202 0>; - clocks = <&k3_clks 61 0>; + clocks = <&k3_clks 61 0>, <&k3_clks 202 0>; + clock-names = "gtc", "core"; assigned-clocks = <&k3_clks 61 0>, <&k3_clks 202 0>; assigned-clock-parents = <&k3_clks 61 2>; assigned-clock-rates = <200000000>, <2000000000>; diff --git a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts index fb7e2e502392..e6da86f3cd10 100644 --- a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts +++ b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts @@ -23,7 +23,8 @@ <&k3_pds 202 TI_SCI_PD_EXCLUSIVE>, <&k3_pds 4 TI_SCI_PD_EXCLUSIVE>; resets = <&k3_reset 202 0>; - clocks = <&k3_clks 61 1>; + clocks = <&k3_clks 61 1>, <&k3_clks 202 2>; + clock-names = "gtc", "core"; assigned-clocks = <&k3_clks 202 2>, <&k3_clks 61 1>, <&k3_clks 323 0>; assigned-clock-parents= <0>, <0>, <&k3_clks 323 2>; assigned-clock-rates = <2000000000>, <200000000>; diff --git a/arch/arm/dts/k3-j721e-r5.dtsi b/arch/arm/dts/k3-j721e-r5.dtsi index fd0d921272c5..688a6cf40892 100644 --- a/arch/arm/dts/k3-j721e-r5.dtsi +++ b/arch/arm/dts/k3-j721e-r5.dtsi @@ -20,7 +20,8 @@ <&k3_pds 202 TI_SCI_PD_EXCLUSIVE>, <&k3_pds 4 TI_SCI_PD_EXCLUSIVE>; resets = <&k3_reset 202 0>; - clocks = <&k3_clks 61 1>; + clocks = <&k3_clks 61 1>, <&k3_clks 202 2>; + clock-names = "gtc", "core"; assigned-clocks = <&k3_clks 202 2>, <&k3_clks 61 1>; assigned-clock-rates = <2000000000>, <200000000>; ti,sci = <&dmsc>; diff --git a/arch/arm/dts/k3-j721s2-r5.dtsi b/arch/arm/dts/k3-j721s2-r5.dtsi index caf696c2d960..634676c8491e 100644 --- a/arch/arm/dts/k3-j721s2-r5.dtsi +++ b/arch/arm/dts/k3-j721s2-r5.dtsi @@ -20,7 +20,8 @@ <&k3_pds 202 TI_SCI_PD_EXCLUSIVE>, <&k3_pds 4 TI_SCI_PD_EXCLUSIVE>; resets = <&k3_reset 202 0>; - clocks = <&k3_clks 61 1>; + clocks = <&k3_clks 61 1>, <&k3_clks 202 0>; + clock-names = "gtc", "core"; assigned-clocks = <&k3_clks 61 1>, <&k3_clks 202 0>; assigned-clock-parents = <&k3_clks 61 3>; assigned-clock-rates = <200000000>, <2000000000>; diff --git a/arch/arm/dts/k3-j784s4-r5-evm.dts b/arch/arm/dts/k3-j784s4-r5-evm.dts index bef4573d3d20..306d2007f89e 100644 --- a/arch/arm/dts/k3-j784s4-r5-evm.dts +++ b/arch/arm/dts/k3-j784s4-r5-evm.dts @@ -26,7 +26,8 @@ power-domains = <&k3_pds 61 TI_SCI_PD_EXCLUSIVE>, <&k3_pds 202 TI_SCI_PD_EXCLUSIVE>; resets = <&k3_reset 202 0>; - clocks = <&k3_clks 61 0>; + clocks = <&k3_clks 61 0>, <&k3_clks 202 0>; + clock-names = "gtc", "core"; assigned-clocks = <&k3_clks 61 0>, <&k3_clks 202 0>; assigned-clock-parents = <&k3_clks 61 2>; assigned-clock-rates = <200000000>, <2000000000>;
MPU clock had been missing. Distinguish multiple clocks with clock-names and add MPU clock as well. Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com> --- arch/arm/dts/k3-am69-r5-sk.dts | 3 ++- arch/arm/dts/k3-j7200-r5-common-proc-board.dts | 3 ++- arch/arm/dts/k3-j721e-r5.dtsi | 3 ++- arch/arm/dts/k3-j721s2-r5.dtsi | 3 ++- arch/arm/dts/k3-j784s4-r5-evm.dts | 3 ++- 5 files changed, 10 insertions(+), 5 deletions(-)