| Message ID | 20240811145047.4189460-11-sjg@chromium.org |
|---|---|
| State | New |
| Delegated to: | Heiko Schocher |
| Headers | show |
| Series | i2c: Chip away at some old code | expand |
Hello Simon, On 11.08.24 16:50, Simon Glass wrote: > Drop some old code from the mxc_i2c and ddr/fsl drivers. This will allow > removal of very old common I2C code. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > Changes in v2: > - Leave pg_wcom alone as its boards were converted > > drivers/ddr/fsl/main.c | 3 +-- > drivers/i2c/mxc_i2c.c | 1 + > 2 files changed, 2 insertions(+), 2 deletions(-) Thanks! Reviewed-by: Heiko Schocher <hs@denx.de> bye, Heiko
diff --git a/drivers/ddr/fsl/main.c b/drivers/ddr/fsl/main.c index 31091bb4495..888dfb7ff33 100644 --- a/drivers/ddr/fsl/main.c +++ b/drivers/ddr/fsl/main.c @@ -111,7 +111,7 @@ static int ddr_i2c_read(DEV_TYPE *dev, unsigned int addr, #if CONFIG_IS_ENABLED(DM_I2C) ret = dm_i2c_read(dev, 0, buf, len); #else - ret = i2c_read(dev->chip, addr, alen, buf, len); + ret = 0; #endif return ret; @@ -162,7 +162,6 @@ static void __get_spd(generic_spd_eeprom_t *spd, u8 i2c_address) }; dev = &ldev; - i2c_set_bus_num(CONFIG_SYS_SPD_BUS_NUM); #endif #ifdef CONFIG_SYS_FSL_DDR4 diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c index 84c0050eac0..2f3cb5908c9 100644 --- a/drivers/i2c/mxc_i2c.c +++ b/drivers/i2c/mxc_i2c.c @@ -620,6 +620,7 @@ int enable_i2c_clk(unsigned char enable, unsigned int i2c_num) __attribute__((weak, alias("__enable_i2c_clk"))); #if !CONFIG_IS_ENABLED(DM_I2C) + /* * Read data from I2C device *
Drop some old code from the mxc_i2c and ddr/fsl drivers. This will allow removal of very old common I2C code. Signed-off-by: Simon Glass <sjg@chromium.org> --- Changes in v2: - Leave pg_wcom alone as its boards were converted drivers/ddr/fsl/main.c | 3 +-- drivers/i2c/mxc_i2c.c | 1 + 2 files changed, 2 insertions(+), 2 deletions(-)