Message ID | 20240805124326.544310-2-bisson.gary@gmail.com |
---|---|
State | Superseded |
Delegated to: | Fabio Estevam |
Headers | show |
Series | imx: imx8ulp: add binman support | expand |
> Subject: [PATCH 1/5] tools: imx8image: fix soc variable for ULP > > Fixes: 6ec65c8558f (tools: image: support i.MX93) Put this just before your "Signed-off-by". > > Currently the ULP token sets the soc as IMX9, making it impossible to > differentiate the two families of processors. > However, since the 8ULP requires specific binaries like upower which > do not exist in 93, they need to be separated. > > Signed-off-by: Gary Bisson <bisson.gary@gmail.com> Besides the minor comment: Reviewed-by: Peng Fan <peng.fan@nxp.com> Regards, Peng.
On Mon, Aug 5, 2024 at 9:43 AM Gary Bisson <bisson.gary@gmail.com> wrote: > > Fixes: 6ec65c8558f (tools: image: support i.MX93) > > Currently the ULP token sets the soc as IMX9, making it impossible to > differentiate the two families of processors. > However, since the 8ULP requires specific binaries like upower which do > not exist in 93, they need to be separated. > > Signed-off-by: Gary Bisson <bisson.gary@gmail.com> Applied the series, thanks.
diff --git a/tools/imx8image.c b/tools/imx8image.c index 76d0cd62dcc..53ab16637ba 100644 --- a/tools/imx8image.c +++ b/tools/imx8image.c @@ -119,7 +119,7 @@ static void parse_cfg_cmd(image_t *param_stack, int32_t cmd, char *token, } else if (!strncmp(token, "IMX8QM", 6)) { soc = QM; } else if (!strncmp(token, "ULP", 3)) { - soc = IMX9; + soc = ULP; } else if (!strncmp(token, "IMX9", 4)) { soc = IMX9; } else {
Fixes: 6ec65c8558f (tools: image: support i.MX93) Currently the ULP token sets the soc as IMX9, making it impossible to differentiate the two families of processors. However, since the 8ULP requires specific binaries like upower which do not exist in 93, they need to be separated. Signed-off-by: Gary Bisson <bisson.gary@gmail.com> --- tools/imx8image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)