| Message ID | 20240731134257.686017-3-admin@hifiphile.com |
|---|---|
| State | RFC |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | dm: Duplicate uclass name fix and alias improvements | expand |
Hi Zixun, On Wed, 31 Jul 2024 at 07:43, Zixun LI <admin@hifiphile.com> wrote: > > Currently uclass index is shown in DM tree dump which ignores alias > sequence numbering. The result could be confusing since these 2 numbers > could be different. Show device sequence number instead. I think it makes sense to show the seq instead of the index, but please update the header for the table to say 'Seq' > > Signed-off-by: Zixun LI <admin@hifiphile.com> > --- > drivers/core/dump.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/core/dump.c b/drivers/core/dump.c > index 5ec30d5b3c..c812d87fa4 100644 > --- a/drivers/core/dump.c > +++ b/drivers/core/dump.c > @@ -40,7 +40,7 @@ static void show_devices(struct udevice *dev, int depth, int last_flag, > /* print the first 20 characters to not break the tree-format. */ > printf(CONFIG_IS_ENABLED(USE_TINY_PRINTF) ? " %s %d [ %c ] %s " : > " %-10.10s %3d [ %c ] %-20.20s ", dev->uclass->uc_drv->name, > - dev_get_uclass_index(dev, NULL), > + dev->seq_, > flags & DM_FLAG_ACTIVATED ? '+' : ' ', dev->driver->name); > > for (i = depth; i >= 0; i--) { > -- > 2.45.2 > Regards, Simon
diff --git a/drivers/core/dump.c b/drivers/core/dump.c index 5ec30d5b3c..c812d87fa4 100644 --- a/drivers/core/dump.c +++ b/drivers/core/dump.c @@ -40,7 +40,7 @@ static void show_devices(struct udevice *dev, int depth, int last_flag, /* print the first 20 characters to not break the tree-format. */ printf(CONFIG_IS_ENABLED(USE_TINY_PRINTF) ? " %s %d [ %c ] %s " : " %-10.10s %3d [ %c ] %-20.20s ", dev->uclass->uc_drv->name, - dev_get_uclass_index(dev, NULL), + dev->seq_, flags & DM_FLAG_ACTIVATED ? '+' : ' ', dev->driver->name); for (i = depth; i >= 0; i--) {
Currently uclass index is shown in DM tree dump which ignores alias sequence numbering. The result could be confusing since these 2 numbers could be different. Show device sequence number instead. Signed-off-by: Zixun LI <admin@hifiphile.com> --- drivers/core/dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)