diff mbox series

[PATCHv3,04/12] cpu: imx: fix the CPU frequency in cpu_imx_get_info()

Message ID 20240726175108.34704-5-Zhiqiang.Hou@nxp.com
State Superseded
Delegated to: Fabio Estevam
Headers show
Series Add a subcommand 'release' to cmd/cpu.c | expand

Commit Message

Z.Q. Hou July 26, 2024, 5:51 p.m. UTC 
From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>

1MHz = 1000000Hzzzzzz

Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
---
V3:
 - New patch.

 drivers/cpu/imx8_cpu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Fabio Estevam July 26, 2024, 8:42 p.m. UTC | #1 
On Fri, Jul 26, 2024 at 2:30 PM Zhiqiang Hou <Zhiqiang.Hou@nxp.com> wrote:
>
> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>
> 1MHz = 1000000Hzzzzzz

Please provide a proper commit log with an explanation. This Hzzzzzz
makes no sense.

Please retain the Reviewed-by tags from Simon on the previous version.
Z.Q. Hou July 29, 2024, 3:02 a.m. UTC | #2 
Hi Fabio,

> -----Original Message-----
> From: Fabio Estevam <festevam@gmail.com>
> Sent: Saturday, July 27, 2024 4:43 AM
> To: Z.Q. Hou <zhiqiang.hou@nxp.com>
> Cc: u-boot@lists.denx.de; trini@konsulko.com; Peng Fan
> <peng.fan@nxp.com>; sjg@chromium.org
> Subject: Re: [PATCHv3 04/12] cpu: imx: fix the CPU frequency in
> cpu_imx_get_info()
> 
> On Fri, Jul 26, 2024 at 2:30 PM Zhiqiang Hou <Zhiqiang.Hou@nxp.com> wrote:
> >
> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> >
> > 1MHz = 1000000Hzzzzzz
> 
> Please provide a proper commit log with an explanation. This Hzzzzzz makes
> no sense.

Will fix this typo.

> 
> Please retain the Reviewed-by tags from Simon on the previous version.

Yes, will add.

Thanks,
Zhiqiang
diff mbox series

Patch

diff --git a/drivers/cpu/imx8_cpu.c b/drivers/cpu/imx8_cpu.c
index 4781a565547..601a7071a64 100644
--- a/drivers/cpu/imx8_cpu.c
+++ b/drivers/cpu/imx8_cpu.c
@@ -1,6 +1,6 @@ 
 // SPDX-License-Identifier: GPL-2.0+
 /*
- * Copyright 2019 NXP
+ * Copyright 2019, 2024 NXP
  */
 
 #include <cpu.h>
@@ -193,7 +193,7 @@  static int cpu_imx_get_info(const struct udevice *dev, struct cpu_info *info)
 {
 	struct cpu_imx_plat *plat = dev_get_plat(dev);
 
-	info->cpu_freq = plat->freq_mhz * 1000;
+	info->cpu_freq = plat->freq_mhz * 1000000;
 	info->features = BIT(CPU_FEAT_L1_CACHE) | BIT(CPU_FEAT_MMU);
 	return 0;
 }