diff mbox series

net: ftgmac100: Fixed NC-SI PHY device cannot get

Message ID 20240628071445.1059016-1-jacky_chou@aspeedtech.com
State Accepted
Delegated to: Andes
Headers show
Series net: ftgmac100: Fixed NC-SI PHY device cannot get | expand

Commit Message

Jacky Chou June 28, 2024, 7:14 a.m. UTC 
The NC-SI interface does not need the MDIO bus and the
NC-SI PHY device cannot get from dm_eth_phy_connect.
Therefore, use phy_connect directly here.

Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
---
 drivers/net/ftgmac100.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Leo Liang Sept. 9, 2024, 7:49 a.m. UTC | #1 
On Fri, Jun 28, 2024 at 03:14:45PM +0800, Jacky Chou wrote:
> The NC-SI interface does not need the MDIO bus and the
> NC-SI PHY device cannot get from dm_eth_phy_connect.
> Therefore, use phy_connect directly here.
> 
> Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
> ---
>  drivers/net/ftgmac100.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Leo Yu-Chi Liang <ycliang@andestech.com>
diff mbox series

Patch

diff --git a/drivers/net/ftgmac100.c b/drivers/net/ftgmac100.c
index 9b536fd5ab..256a519020 100644
--- a/drivers/net/ftgmac100.c
+++ b/drivers/net/ftgmac100.c
@@ -223,7 +223,7 @@  static int ftgmac100_phy_init(struct udevice *dev)
 	struct phy_device *phydev;
 	int ret;
 
-	if (IS_ENABLED(CONFIG_DM_MDIO))
+	if (IS_ENABLED(CONFIG_DM_MDIO) && priv->phy_mode != PHY_INTERFACE_MODE_NCSI)
 		phydev = dm_eth_phy_connect(dev);
 	else
 		phydev = phy_connect(priv->bus, priv->phy_addr, dev, priv->phy_mode);