From patchwork Thu Jun 27 09:19:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1953098 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=GXeCqT42; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4W8tMk38jGz20Xg for ; Thu, 27 Jun 2024 19:20:34 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 12A838855B; Thu, 27 Jun 2024 11:19:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="GXeCqT42"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 01AA78855B; Thu, 27 Jun 2024 11:19:38 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0DC5388256 for ; Thu, 27 Jun 2024 11:19:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-52cdd893e5cso5833969e87.1 for ; Thu, 27 Jun 2024 02:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1719479975; x=1720084775; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q7dZ7EgYr0k6vuGV4Zq+HOmn5La1Qr8GHhYneKXIm/g=; b=GXeCqT42Jaym2Skan6TupMYxYwshqL6P+WIjZtzLlEQr1UNHoqj/LUZDg5JfaLx8lR Sf8HNjxsSq/teboOygHn41MSNI1EUNBaz8UVIhanEQR/NYLWCozP/iCzl2ZlOYMYDRkc RfXK7EjK8Ury1C0iyXPRkon0EctW27EQ/+l0o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719479975; x=1720084775; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q7dZ7EgYr0k6vuGV4Zq+HOmn5La1Qr8GHhYneKXIm/g=; b=YeIlBpz3GiaHJHKMGgRwLqP7Y7QMjdEL9f/lit9twhkM4KzaifIkryOnEV6lly0S9Q 5JU77Cvy6xAD7qYi8/RbUEIM50Hj4oFox7dp5W07f+pCtHrgYhXCRsSiNygPDm44o2oa scez71cYm+x4q5DGk6zMj6ltNye/pYwAdDqYkIW17tQLaJt2TnwQNX3IUfVN5UAUh4H3 wlBv3zmHk/wolI0pygnWYl1MlBJPK2h3HWvxxs5WC6v+YM9eMaK81nndgna6j+iqwCMZ ApyE4RMRNMHJ3VAhqQgkUVbGwk6yxLHDBNVhdVWreuHO5EuAx5xgY1ezvzr8sHJK9MSh x+GQ== X-Gm-Message-State: AOJu0YwbcxUu4yQP5xxE4U5sEqX1quWFzQ34MVmuLMKiJ0IVnhvORKbq oVtOjMLeN+Hh4fenDiv4a3BzbuFj2yqr3z/RzX8eAvTFQRZO4KsxDHBDNbW4RIVNvXIKnCGgOFv SRw== X-Google-Smtp-Source: AGHT+IHNP5cUwDnfSDNin7G9bLUmgtMFoakBYJd8yvc4TfT47I7CBWwAZBYa3N8bd8s5ViJNSgRBgg== X-Received: by 2002:a05:6512:467:b0:52c:da39:87a7 with SMTP id 2adb3069b0e04-52ce1843951mr10096611e87.41.1719479975149; Thu, 27 Jun 2024 02:19:35 -0700 (PDT) Received: from tasman.. (host-92-15-194-143.as13285.net. [92.15.194.143]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367436a28f7sm1199818f8f.117.2024.06.27.02.19.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 02:19:34 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Sughosh Ganu , Alper Nebi Yasak , Neha Malcom Francis , Peng Fan , Philippe Reynes , Stefan Herbrechtsmeier Subject: [PATCH v6 5/8] binman: Keep the efi_capsule input file Date: Thu, 27 Jun 2024 10:19:23 +0100 Message-Id: <20240627091926.374633-6-sjg@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240627091926.374633-1-sjg@chromium.org> References: <20240627091926.374633-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean There is no need to remove input files. It makes it harder to diagnose failures. Keep the payload file. There is no test for this condition, but one could be added. Signed-off-by: Simon Glass Acked-by: Sughosh Ganu --- (no changes since v4) Changes in v4: - Drop Fixes tag tools/binman/etype/efi_capsule.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/binman/etype/efi_capsule.py b/tools/binman/etype/efi_capsule.py index 47da5da324b..03e55cbc4d9 100644 --- a/tools/binman/etype/efi_capsule.py +++ b/tools/binman/etype/efi_capsule.py @@ -148,7 +148,6 @@ class Entry_efi_capsule(Entry_section): self.fw_version, self.oem_flags) if ret is not None: - os.remove(payload) return tools.read_file(capsule_fname) else: # Bintool is missing; just use the input data as the output