From patchwork Mon Jun 24 21:03:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Marangi X-Patchwork-Id: 1951758 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=kEGVKmqH; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4W7L9k5NwWz1ydW for ; Tue, 25 Jun 2024 07:06:34 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 943A888405; Mon, 24 Jun 2024 23:04:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kEGVKmqH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C18C6885A4; Mon, 24 Jun 2024 23:04:48 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5976888590 for ; Mon, 24 Jun 2024 23:04:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ansuelsmth@gmail.com Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-36279cf6414so3854007f8f.3 for ; Mon, 24 Jun 2024 14:04:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719263085; x=1719867885; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=XNqKnoO1M7Vvxa76ER/5BqBkhfciKUzVHEdydKoIgrI=; b=kEGVKmqH04Of3jw0W1dxQmIok4duNiTv1WVUT4SObGr0NwLHw7OQdPAhKMRC8/+7CO UirpAS39Wz1dCn9GORBqJu7n7Vm7vnJTwSnxEYlCaXdr2hv1IQtq1C7AOLjWnh0F152k bFHUf3m92VpXU/FsT1NnRgYKwV0I8JsQb9ue0ruWMakdQdk7L3Nov/GI7cBm1d6Vbra3 XjkubNpc6pvBBFyrzuAwsYvIuTAxfribBWZbHw9nEolOno8eP/CZrq2rMQM1880mmo7E 4ro1vYiVaGc7/25AADdKEfjDtG5FoH4IFQ0hcwpVaRGfPJH3AqcQZEeHwEnmSRwYHlmO q81Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719263085; x=1719867885; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XNqKnoO1M7Vvxa76ER/5BqBkhfciKUzVHEdydKoIgrI=; b=J8jYuNzubIsAKc3xMPMAYiexUwyN/QsYURErzy08hTeEN6ZbYXDAKJ2QzfClkFeukN R653BZclCnvCy5J0JNLVzVTFIKVje646IdQlPGs3uawLOIft+S9FBXVS9HFyN9j3aYVF e/JfACuSwvi/kdSBCjBbBq25yPWZv6EGYk2/S1IWWHkPQVLs6p3txIhCG8BGuLJkc/Dl CXPRAuASb3uWdg35M1Adu3ZGI1o6qusgqvsYOKOf5h4bp7bQANKub95eCRhMwyTK0WlZ ZBfNLdpQNQgNCG6LLI+Es6CWxid6wEZ206rdFKqlgJlubvG7efjFCYbBBJCddKFTaWqb fH4Q== X-Forwarded-Encrypted: i=1; AJvYcCUVNtLy3xpahbqdQPvN9xgPnMYjs7kSh9AaYledPnRM44NT1tHlEsi4XF3YQgYMx4+dD8w3vtUcRBCMiX4RLE4if3DtBg== X-Gm-Message-State: AOJu0YxVTIwNeaOKg63tfcna+wzgFZPebJCEycfpzALDe2boGxb5eLCy /35i5lLMLIuRFvanfY6VzS97+EzBhY7cQ3KNbV8wgkV03wLqIK9t X-Google-Smtp-Source: AGHT+IFjQs6WtX2SWx45UU3FOmc7+43R9g3mb4/0jLcKmpHOI+9d6m2dYPmL4WcSZxmeoSyZIZL2iw== X-Received: by 2002:adf:f7d2:0:b0:366:ddc2:a14a with SMTP id ffacd0b85a97d-366e94d6a97mr2914196f8f.40.1719263084735; Mon, 24 Jun 2024 14:04:44 -0700 (PDT) Received: from localhost.localdomain (93-34-90-105.ip49.fastwebnet.it. [93.34.90.105]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3664178f5f7sm10968228f8f.19.2024.06.24.14.04.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 14:04:44 -0700 (PDT) From: Christian Marangi To: Tom Rini , Lukasz Majewski , Sean Anderson , Ryder Lee , Weijie Gao , Chunfeng Yun , GSS_MTK_Uboot_upstream , Heiko Schocher , Peng Fan , Jaehoon Chung , Joe Hershberger , Ramon Fried , Jagan Teki , John Crispin , This contributor prefers not to receive mails , Mason Huo , Heinrich Schuchardt , Christian Marangi , Sergei Antonov , Sumit Garg , Simon Glass , Leo Yu-Chi Liang , Neil Armstrong , Mark Kettenis , Marek Vasut , Alexey Romanov , Peter Robinson , Sam Shih , u-boot@lists.denx.de Subject: [PATCH v4 12/14] pci: mediatek: make pcie-phy optional for gen3 Date: Mon, 24 Jun 2024 23:03:38 +0200 Message-ID: <20240624210418.19324-13-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240624210418.19324-1-ansuelsmth@gmail.com> References: <20240624210418.19324-1-ansuelsmth@gmail.com> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Set pcie-phy optional for PCIe gen3. MT7988 doesn't require it and making it mandatory prevent the driver to correctly probe. Signed-off-by: Christian Marangi --- drivers/pci/pcie_mediatek_gen3.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/pci/pcie_mediatek_gen3.c b/drivers/pci/pcie_mediatek_gen3.c index 673813b8b75..0149edae0bf 100644 --- a/drivers/pci/pcie_mediatek_gen3.c +++ b/drivers/pci/pcie_mediatek_gen3.c @@ -284,9 +284,8 @@ static int mtk_pcie_power_on(struct udevice *dev) pcie->priv = dev; - err = generic_phy_get_by_name(dev, "pcie-phy", &pcie->phy); - if (err) - return err; + /* pcie-phy is optional (mt7988 doesn't need it) */ + generic_phy_get_by_name(dev, "pcie-phy", &pcie->phy); /* * Upstream linux kernel devine these clock without clock-names @@ -308,13 +307,15 @@ static int mtk_pcie_power_on(struct udevice *dev) if (err) return err; - err = generic_phy_init(&pcie->phy); - if (err) - return err; + if (pcie->phy.dev) { + err = generic_phy_init(&pcie->phy); + if (err) + return err; - err = generic_phy_power_on(&pcie->phy); - if (err) - goto err_phy_on; + err = generic_phy_power_on(&pcie->phy); + if (err) + goto err_phy_on; + } err = clk_enable(&pcie->pl_250m_ck); if (err) @@ -348,7 +349,8 @@ err_clk_tl_26m: err_clk_pl_250m: clk_disable(&pcie->pl_250m_ck); err_phy_on: - generic_phy_exit(&pcie->phy); + if (pcie->phy.dev) + generic_phy_exit(&pcie->phy); return err; }