mbox series

Pull request for tpm-master-24062024

Message ID 20240624122956.5739-1-ilias.apalodimas@linaro.org
State Accepted
Delegated to: Tom Rini
Headers show
Series Pull request for tpm-master-24062024 | expand

Pull-request

https://source.denx.de/u-boot/custodians/u-boot-tpm/ tags/tpm-master-24062024

Message

Ilias Apalodimas June 24, 2024, 12:29 p.m. UTC
Hi Tom,

A few last minutes fixes for EFI, but this time via the TPM tree

The following changes since commit fe2ce09a0753634543c32cafe85eb87a625f76ca:

  Merge branch 'master' of https://source.denx.de/u-boot/custodians/u-boot-watchdog (2024-06-18 08:34:56 -0600)

are available in the Git repository at:

  https://source.denx.de/u-boot/custodians/u-boot-tpm/ tags/tpm-master-24062024

for you to fetch changes up to b73948c785d2bbccf0a76dec92cf50fe5b408c0e:

  efi_loader: fix the return values on efi_tcg (2024-06-24 08:38:06 +0300)

The CI is here https://source.denx.de/u-boot/custodians/u-boot-tpm/-/pipelines/21309
and showed no problems.

I also tested measured booot looking at the EventLog pre/post patch. No changes
apart from PCR0 which is expected to change

----------------------------------------------------------------
When the EFI TCG measurement code moved from EFI to the TPM subsystem for
general use some prototypes changed from returning efi_status_t to int,
which is more appropriate for the non-EFI APIs. However, some of the
EFI callsites never changed and we ended up assigning the int value to
efi_status_t.

This is unlikely to cause any problems, apart from returning invalid
values on failures and violating the EFI spec.

----------------------------------------------------------------
Ilias Apalodimas (2):
      tpm: fix the return code, if the eventlog buffer is full
      efi_loader: fix the return values on efi_tcg

 lib/efi_loader/efi_tcg2.c | 126 +++++++++++++++++++++++++---------------------
 lib/tpm-v2.c              |   2 +-
 2 files changed, 70 insertions(+), 58 deletions(-)

Comments

Tom Rini June 24, 2024, 7:30 p.m. UTC | #1
On Mon, Jun 24, 2024 at 03:29:56PM +0300, Ilias Apalodimas wrote:

> Hi Tom,
> 
> A few last minutes fixes for EFI, but this time via the TPM tree
> 
> The following changes since commit fe2ce09a0753634543c32cafe85eb87a625f76ca:
> 
>   Merge branch 'master' of https://source.denx.de/u-boot/custodians/u-boot-watchdog (2024-06-18 08:34:56 -0600)
> 
> are available in the Git repository at:
> 
>   https://source.denx.de/u-boot/custodians/u-boot-tpm/ tags/tpm-master-24062024
> 
> for you to fetch changes up to b73948c785d2bbccf0a76dec92cf50fe5b408c0e:
> 
>   efi_loader: fix the return values on efi_tcg (2024-06-24 08:38:06 +0300)
> 
> The CI is here https://source.denx.de/u-boot/custodians/u-boot-tpm/-/pipelines/21309
> and showed no problems.
> 
> I also tested measured booot looking at the EventLog pre/post patch. No changes
> apart from PCR0 which is expected to change
> 

Applied to u-boot/master, thanks!