| Message ID | 20240622143601.187723-2-ilias.apalodimas@linaro.org |
|---|---|
| State | Superseded |
| Delegated to: | Heinrich Schuchardt |
| Headers | show |
| Series | The great TCG deduplication saga | expand |
On 22.06.24 16:35, Ilias Apalodimas wrote: > We currently return 'No space left on device' if the eventlong buffer > we allocated is not enough. On a similar check later on that function > during the call to tcg2_log_init() we return 'No buffer space > available'. So switch both error codes to -ENOBUFS since we are always > checking a buffer and not a device. > > Fixes: commit 97707f12fdab ("tpm: Support boot measurements") > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > lib/tpm-v2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/tpm-v2.c b/lib/tpm-v2.c > index a67daed2f3c1..91526af33acb 100644 > --- a/lib/tpm-v2.c > +++ b/lib/tpm-v2.c > @@ -554,7 +554,7 @@ int tcg2_log_prepare_buffer(struct udevice *dev, struct tcg2_event_log *elog, > if (elog->log_size) { > if (log.found) { > if (elog->log_size < log.log_position) > - return -ENOSPC; > + return -ENOBUFS; > > /* > * Copy the discovered log into the user buffer
diff --git a/lib/tpm-v2.c b/lib/tpm-v2.c index a67daed2f3c1..91526af33acb 100644 --- a/lib/tpm-v2.c +++ b/lib/tpm-v2.c @@ -554,7 +554,7 @@ int tcg2_log_prepare_buffer(struct udevice *dev, struct tcg2_event_log *elog, if (elog->log_size) { if (log.found) { if (elog->log_size < log.log_position) - return -ENOSPC; + return -ENOBUFS; /* * Copy the discovered log into the user buffer
We currently return 'No space left on device' if the eventlong buffer we allocated is not enough. On a similar check later on that function during the call to tcg2_log_init() we return 'No buffer space available'. So switch both error codes to -ENOBUFS since we are always checking a buffer and not a device. Fixes: commit 97707f12fdab ("tpm: Support boot measurements") Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> --- lib/tpm-v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)