diff mbox series

[next,v2] rockchip: puma-rk3399: increase Ethernet PHY timeout to 30s

Message ID 20240619-puma-eth-timeout-v2-1-a01c443d4445@cherry.de
State Accepted
Commit 04ec02a8824279a1da3c6ce1d8a2db06baf8a522
Delegated to: Kever Yang
Headers show
Series [next,v2] rockchip: puma-rk3399: increase Ethernet PHY timeout to 30s | expand

Commit Message

Quentin Schulz June 19, 2024, 3:44 p.m. UTC 
From: Quentin Schulz <quentin.schulz@cherry.de>

On Puma v2.1 with a KSZ9031, the Ethernet PHY often doesn't detect the
link in the 4-second default timeout.

After some boot-loop test for about a thousand boots, 70% were below
10s, 90% below 15s and 100% below 30s. Let's play it safe and make it
30s so that hopefully all links that should be detected are.

Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
---
Changes in v2:
- rebase on next
- use Kconfig symbol instead of constant in include/configs/
- Link to v1: https://lore.kernel.org/r/20240619-puma-eth-timeout-v1-1-db5c17153f82@cherry.de
---
 configs/puma-rk3399_defconfig | 1 +
 1 file changed, 1 insertion(+)


---
base-commit: 01a5d7547ed3a51a8ac5837c31a150f85bc475f8
change-id: 20240619-puma-eth-timeout-41be9c243ed7

Best regards,

Comments

Kever Yang July 16, 2024, 2:15 a.m. UTC | #1 
On 2024/6/19 23:44, Quentin Schulz wrote:
> From: Quentin Schulz <quentin.schulz@cherry.de>
>
> On Puma v2.1 with a KSZ9031, the Ethernet PHY often doesn't detect the
> link in the 4-second default timeout.
>
> After some boot-loop test for about a thousand boots, 70% were below
> 10s, 90% below 15s and 100% below 30s. Let's play it safe and make it
> 30s so that hopefully all links that should be detected are.
>
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
> Changes in v2:
> - rebase on next
> - use Kconfig symbol instead of constant in include/configs/
> - Link to v1: https://lore.kernel.org/r/20240619-puma-eth-timeout-v1-1-db5c17153f82@cherry.de
> ---
>   configs/puma-rk3399_defconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/configs/puma-rk3399_defconfig b/configs/puma-rk3399_defconfig
> index 5319239f989..4293cf0ae44 100644
> --- a/configs/puma-rk3399_defconfig
> +++ b/configs/puma-rk3399_defconfig
> @@ -69,6 +69,7 @@ CONFIG_MMC_SDHCI_ROCKCHIP=y
>   CONFIG_SF_DEFAULT_BUS=1
>   CONFIG_SPI_FLASH_GIGADEVICE=y
>   CONFIG_SPI_FLASH_WINBOND=y
> +CONFIG_PHY_ANEG_TIMEOUT=30000
>   CONFIG_PHY_MICREL=y
>   CONFIG_PHY_MICREL_KSZ90X1=y
>   CONFIG_ETH_DESIGNWARE=y
>
> ---
> base-commit: 01a5d7547ed3a51a8ac5837c31a150f85bc475f8
> change-id: 20240619-puma-eth-timeout-41be9c243ed7
>
> Best regards,
diff mbox series

Patch

diff --git a/configs/puma-rk3399_defconfig b/configs/puma-rk3399_defconfig
index 5319239f989..4293cf0ae44 100644
--- a/configs/puma-rk3399_defconfig
+++ b/configs/puma-rk3399_defconfig
@@ -69,6 +69,7 @@  CONFIG_MMC_SDHCI_ROCKCHIP=y
 CONFIG_SF_DEFAULT_BUS=1
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_WINBOND=y
+CONFIG_PHY_ANEG_TIMEOUT=30000
 CONFIG_PHY_MICREL=y
 CONFIG_PHY_MICREL_KSZ90X1=y
 CONFIG_ETH_DESIGNWARE=y