| Message ID | 20240614005309.34433-6-marek.vasut+renesas@mailbox.org |
|---|---|
| State | Accepted |
| Commit | a75753327399d821ba70d8cb493d1bc12d1034cc |
| Delegated to: | Mattijs Korpershoek |
| Headers | show |
| Series | usb: gadget: Introduce handle_interrupts ops to USB_GADGET_GENERIC uclass | expand |
Hi Marek, Thank you for the patch. On ven., juin 14, 2024 at 02:51, Marek Vasut <marek.vasut+renesas@mailbox.org> wrote: > Implement .handle_interrupts callback as a replacement for deprecated > dm_usb_gadget_handle_interrupts() function. The new callback allows > for each DM capable USB gadget controller driver to define its own > IRQ handling implementation without colliding with other controller > drivers. > > Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> > --- > Cc: Alexander Sverdlin <alexander.sverdlin@siemens.com> > Cc: Felipe Balbi <felipe.balbi@linux.intel.com> > Cc: Lukasz Majewski <lukma@denx.de> > Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com> > Cc: Nishanth Menon <nm@ti.com> > Cc: Simon Glass <sjg@chromium.org> > Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com> > Cc: Tom Rini <trini@konsulko.com> > Cc: u-boot@lists.denx.de > --- > drivers/usb/gadget/max3420_udc.c | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/drivers/usb/gadget/max3420_udc.c b/drivers/usb/gadget/max3420_udc.c > index 5a227c0ffd9..557a1f0644e 100644 > --- a/drivers/usb/gadget/max3420_udc.c > +++ b/drivers/usb/gadget/max3420_udc.c > @@ -808,13 +808,6 @@ static void max3420_setup_spi(struct max3420_udc *udc) > spi_wr8(udc, MAX3420_REG_PINCTL, bFDUPSPI); > } > > -int dm_usb_gadget_handle_interrupts(struct udevice *dev) > -{ > - struct max3420_udc *udc = dev_get_priv(dev); > - > - return max3420_irq(udc); > -} > - > static int max3420_udc_probe(struct udevice *dev) > { > struct max3420_udc *udc = dev_get_priv(dev); > @@ -859,6 +852,17 @@ static int max3420_udc_remove(struct udevice *dev) > return 0; > } > > +static int max3420_gadget_handle_interrupts(struct udevice *dev) > +{ > + struct max3420_udc *udc = dev_get_priv(dev); > + > + return max3420_irq(udc); > +} > + > +static const struct usb_gadget_generic_ops max3420_gadget_ops = { > + .handle_interrupts = max3420_gadget_handle_interrupts, > +}; > + > static const struct udevice_id max3420_ids[] = { > { .compatible = "maxim,max3421-udc" }, > { } > @@ -868,6 +872,7 @@ U_BOOT_DRIVER(max3420_generic_udc) = { > .name = "max3420-udc", > .id = UCLASS_USB_GADGET_GENERIC, > .of_match = max3420_ids, > + .ops = &max3420_gadget_ops, > .probe = max3420_udc_probe, > .remove = max3420_udc_remove, > .priv_auto = sizeof(struct max3420_udc), > -- > 2.43.0
diff --git a/drivers/usb/gadget/max3420_udc.c b/drivers/usb/gadget/max3420_udc.c index 5a227c0ffd9..557a1f0644e 100644 --- a/drivers/usb/gadget/max3420_udc.c +++ b/drivers/usb/gadget/max3420_udc.c @@ -808,13 +808,6 @@ static void max3420_setup_spi(struct max3420_udc *udc) spi_wr8(udc, MAX3420_REG_PINCTL, bFDUPSPI); } -int dm_usb_gadget_handle_interrupts(struct udevice *dev) -{ - struct max3420_udc *udc = dev_get_priv(dev); - - return max3420_irq(udc); -} - static int max3420_udc_probe(struct udevice *dev) { struct max3420_udc *udc = dev_get_priv(dev); @@ -859,6 +852,17 @@ static int max3420_udc_remove(struct udevice *dev) return 0; } +static int max3420_gadget_handle_interrupts(struct udevice *dev) +{ + struct max3420_udc *udc = dev_get_priv(dev); + + return max3420_irq(udc); +} + +static const struct usb_gadget_generic_ops max3420_gadget_ops = { + .handle_interrupts = max3420_gadget_handle_interrupts, +}; + static const struct udevice_id max3420_ids[] = { { .compatible = "maxim,max3421-udc" }, { } @@ -868,6 +872,7 @@ U_BOOT_DRIVER(max3420_generic_udc) = { .name = "max3420-udc", .id = UCLASS_USB_GADGET_GENERIC, .of_match = max3420_ids, + .ops = &max3420_gadget_ops, .probe = max3420_udc_probe, .remove = max3420_udc_remove, .priv_auto = sizeof(struct max3420_udc),
Implement .handle_interrupts callback as a replacement for deprecated dm_usb_gadget_handle_interrupts() function. The new callback allows for each DM capable USB gadget controller driver to define its own IRQ handling implementation without colliding with other controller drivers. Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> --- Cc: Alexander Sverdlin <alexander.sverdlin@siemens.com> Cc: Felipe Balbi <felipe.balbi@linux.intel.com> Cc: Lukasz Majewski <lukma@denx.de> Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com> Cc: Nishanth Menon <nm@ti.com> Cc: Simon Glass <sjg@chromium.org> Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com> Cc: Tom Rini <trini@konsulko.com> Cc: u-boot@lists.denx.de --- drivers/usb/gadget/max3420_udc.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-)