| Message ID | 20240517160624.156962-1-heinrich.schuchardt@canonical.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | [1/1] defconfig: disable VIDEO_COPY on the sandbox | expand |
在2024年5月17日五月 下午5:06，Heinrich Schuchardt写道： > Since commit a75cf70d23ac ("efi: Correct handling of frame buffer") the EFI > block image transfer is broken on the sandbox. > > To test build sandbox_defconfig with CONFIG_EFI_SELFTEST=y and execute > > setenv efi_selftest block image transfer > bootefi selftest > > Fixes: a75cf70d23ac ("efi: Correct handling of frame buffer") > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com> It turns out that texture copy is only required for 8bpc display, which we don't care much anyway. Thanks - Jiaxun > --- > configs/sandbox_defconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig > index 93b52f2de5c..80c310b8e82 100644 > --- a/configs/sandbox_defconfig > +++ b/configs/sandbox_defconfig > @@ -318,7 +318,6 @@ CONFIG_USB_ETHER=y > CONFIG_USB_ETH_CDC=y > CONFIG_VIDEO=y > CONFIG_VIDEO_FONT_SUN12X22=y > -CONFIG_VIDEO_COPY=y > CONFIG_CONSOLE_ROTATION=y > CONFIG_CONSOLE_TRUETYPE=y > CONFIG_CONSOLE_TRUETYPE_CANTORAONE=y > -- > 2.43.0
Hi, On Fri, 17 May 2024 at 17:36, Jiaxun Yang <jiaxun.yang@flygoat.com> wrote: > > > > 在2024年5月17日五月 下午5:06，Heinrich Schuchardt写道： > > Since commit a75cf70d23ac ("efi: Correct handling of frame buffer") the EFI > > block image transfer is broken on the sandbox. > > > > To test build sandbox_defconfig with CONFIG_EFI_SELFTEST=y and execute > > > > setenv efi_selftest block image transfer > > bootefi selftest > > > > Fixes: a75cf70d23ac ("efi: Correct handling of frame buffer") > > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> > > Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com> > > It turns out that texture copy is only required for 8bpc display, which > we don't care much anyway. I can repeat this with this change in sandbox.dtsi in the /lcd node: log2-depth = <3>; I see: >>> Selected test: 'block image transfer' Setting up 'block image transfer' Graphical output protocol is not available. Setting up 'block image transfer' succeeded Executing 'block image transfer' Executing 'block image transfer' succeeded Tearing down 'block image transfer' Tearing down 'block image transfer' succeeded Summary: 0 failures <<< It looks like gop_get_bpp() doesn't have support for VIDEO_BPP8 and there may be other problems. I don't want to display this option in sandbox, since we want to test the VIDEO_COPY feature. Instead, I think EFI support should be enhanced to cover 8bpp if desired. Regards, Simon
diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index 93b52f2de5c..80c310b8e82 100644 --- a/configs/sandbox_defconfig +++ b/configs/sandbox_defconfig @@ -318,7 +318,6 @@ CONFIG_USB_ETHER=y CONFIG_USB_ETH_CDC=y CONFIG_VIDEO=y CONFIG_VIDEO_FONT_SUN12X22=y -CONFIG_VIDEO_COPY=y CONFIG_CONSOLE_ROTATION=y CONFIG_CONSOLE_TRUETYPE=y CONFIG_CONSOLE_TRUETYPE_CANTORAONE=y
Since commit a75cf70d23ac ("efi: Correct handling of frame buffer") the EFI block image transfer is broken on the sandbox. To test build sandbox_defconfig with CONFIG_EFI_SELFTEST=y and execute setenv efi_selftest block image transfer bootefi selftest Fixes: a75cf70d23ac ("efi: Correct handling of frame buffer") Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> --- configs/sandbox_defconfig | 1 - 1 file changed, 1 deletion(-)