diff mbox series

[029/149] board: broadcom: Remove <common.h> and add needed includes

Message ID 20240501024316.1767971-29-trini@konsulko.com
State Accepted
Commit efbb04bc182e3fbc0ba2c7e08a8cec98bd46003c
Delegated to: Tom Rini
Headers show
Series [001/149] global: Make <asm/global_data.h> include <asm/u-boot.h> | expand

Commit Message

Tom Rini May 1, 2024, 2:41 a.m. UTC
Remove <common.h> from this board vendor directory and when needed
add missing include files directly.

Signed-off-by: Tom Rini <trini@konsulko.com>
---
Cc: Anand Gore <anand.gore@broadcom.com>
Cc: William Zhang <william.zhang@broadcom.com>
Cc: Kursad Oney <kursad.oney@broadcom.com>
Cc: Joel Peshkin <joel.peshkin@broadcom.com>
Cc: Philippe Reynes <philippe.reynes@softathome.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
Cc: Thomas Fitzsimmons <fitzsim@fitzsim.org>
---
 board/broadcom/bcmbca/board.c  | 1 -
 board/broadcom/bcmns/ns.c      | 1 -
 board/broadcom/bcmns3/ns3.c    | 2 +-
 board/broadcom/bcmstb/bcmstb.c | 1 -
 4 files changed, 1 insertion(+), 4 deletions(-)

Comments

William Zhang May 1, 2024, 3:42 a.m. UTC | #1
Hi Tom,

On 04/30/2024 07:41 PM, Tom Rini wrote:
> Remove <common.h> from this board vendor directory and when needed
> add missing include files directly.
> 
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> Cc: Anand Gore <anand.gore@broadcom.com>
> Cc: William Zhang <william.zhang@broadcom.com>
> Cc: Kursad Oney <kursad.oney@broadcom.com>
> Cc: Joel Peshkin <joel.peshkin@broadcom.com>
> Cc: Philippe Reynes <philippe.reynes@softathome.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> Cc: Thomas Fitzsimmons <fitzsim@fitzsim.org>
> ---
>   board/broadcom/bcmbca/board.c  | 1 -
>   board/broadcom/bcmns/ns.c      | 1 -
>   board/broadcom/bcmns3/ns3.c    | 2 +-
>   board/broadcom/bcmstb/bcmstb.c | 1 -
>   4 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/board/broadcom/bcmbca/board.c b/board/broadcom/bcmbca/board.c
> index bcecb4d78392..a6ced92565f9 100644
> --- a/board/broadcom/bcmbca/board.c
> +++ b/board/broadcom/bcmbca/board.c
> @@ -3,7 +3,6 @@
>    * (C) Copyright 2022 Broadcom Ltd.
>    */
>   
> -#include <common.h>
>   #include <fdtdec.h>
>   
>   int board_init(void)
> diff --git a/board/broadcom/bcmns/ns.c b/board/broadcom/bcmns/ns.c
> index 1249e45af036..45cc62936cec 100644
> --- a/board/broadcom/bcmns/ns.c
> +++ b/board/broadcom/bcmns/ns.c
> @@ -4,7 +4,6 @@
>    * Copyright (C) 2023 Linus Walleij <linus.walleij@linaro.org>
>    */
>   
> -#include <common.h>
>   #include <dm.h>
>   #include <init.h>
>   #include <log.h>
> diff --git a/board/broadcom/bcmns3/ns3.c b/board/broadcom/bcmns3/ns3.c
> index 7ae6742c4be8..bb2f1e4f62ad 100644
> --- a/board/broadcom/bcmns3/ns3.c
> +++ b/board/broadcom/bcmns3/ns3.c
> @@ -4,8 +4,8 @@
>    *
>    */
>   
> -#include <common.h>
>   #include <fdt_support.h>
> +#include <linux/errno.h>
>   #include <asm/io.h>
>   #include <asm/gic-v3.h>
>   #include <asm/global_data.h>
> diff --git a/board/broadcom/bcmstb/bcmstb.c b/board/broadcom/bcmstb/bcmstb.c
> index aead6f099e81..bc05aecc446d 100644
> --- a/board/broadcom/bcmstb/bcmstb.c
> +++ b/board/broadcom/bcmstb/bcmstb.c
> @@ -12,7 +12,6 @@
>   #include <time.h>
>   #include <asm/global_data.h>
>   #include <linux/types.h>
> -#include <common.h>
>   #include <env.h>
>   #include <asm/io.h>
>   #include <asm/bootm.h>
> 

For board/broadcom/bcmbca/board.c

Reviewed-by: William Zhang <william.zhang@broadcom.com>
diff mbox series

Patch

diff --git a/board/broadcom/bcmbca/board.c b/board/broadcom/bcmbca/board.c
index bcecb4d78392..a6ced92565f9 100644
--- a/board/broadcom/bcmbca/board.c
+++ b/board/broadcom/bcmbca/board.c
@@ -3,7 +3,6 @@ 
  * (C) Copyright 2022 Broadcom Ltd.
  */
 
-#include <common.h>
 #include <fdtdec.h>
 
 int board_init(void)
diff --git a/board/broadcom/bcmns/ns.c b/board/broadcom/bcmns/ns.c
index 1249e45af036..45cc62936cec 100644
--- a/board/broadcom/bcmns/ns.c
+++ b/board/broadcom/bcmns/ns.c
@@ -4,7 +4,6 @@ 
  * Copyright (C) 2023 Linus Walleij <linus.walleij@linaro.org>
  */
 
-#include <common.h>
 #include <dm.h>
 #include <init.h>
 #include <log.h>
diff --git a/board/broadcom/bcmns3/ns3.c b/board/broadcom/bcmns3/ns3.c
index 7ae6742c4be8..bb2f1e4f62ad 100644
--- a/board/broadcom/bcmns3/ns3.c
+++ b/board/broadcom/bcmns3/ns3.c
@@ -4,8 +4,8 @@ 
  *
  */
 
-#include <common.h>
 #include <fdt_support.h>
+#include <linux/errno.h>
 #include <asm/io.h>
 #include <asm/gic-v3.h>
 #include <asm/global_data.h>
diff --git a/board/broadcom/bcmstb/bcmstb.c b/board/broadcom/bcmstb/bcmstb.c
index aead6f099e81..bc05aecc446d 100644
--- a/board/broadcom/bcmstb/bcmstb.c
+++ b/board/broadcom/bcmstb/bcmstb.c
@@ -12,7 +12,6 @@ 
 #include <time.h>
 #include <asm/global_data.h>
 #include <linux/types.h>
-#include <common.h>
 #include <env.h>
 #include <asm/io.h>
 #include <asm/bootm.h>