| Message ID | 20240419023632.29078-2-seanga2@gmail.com |
|---|---|
| State | Accepted |
| Commit | eba80858039c403cb3e2ef166c7f1418838d4ec2 |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | patman: A fix and some new tags | expand |
On Fri, 19 Apr 2024 at 03:36, Sean Anderson <seanga2@gmail.com> wrote: > > If add_maintainers is set to False in the user's ~/.patman config, it will > cause the custom_get_maintainer_script to fail since that test expects > maintainers to be added. Set add_maintainer to True in the .patman config > to prevent this. > > Fixes: 8c042fb7f9f ("patman: add '--get-maintainer-script' argument") > Signed-off-by: Sean Anderson <seanga2@gmail.com> > --- > > tools/patman/func_test.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On Fri, 19 Apr 2024 at 03:36, Sean Anderson <seanga2@gmail.com> wrote: > > If add_maintainers is set to False in the user's ~/.patman config, it will > cause the custom_get_maintainer_script to fail since that test expects > maintainers to be added. Set add_maintainer to True in the .patman config > to prevent this. > > Fixes: 8c042fb7f9f ("patman: add '--get-maintainer-script' argument") > Signed-off-by: Sean Anderson <seanga2@gmail.com> > --- > > tools/patman/func_test.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot-dm, thanks!
diff --git a/tools/patman/func_test.py b/tools/patman/func_test.py index e3918497cf4..9c016fb5e9a 100644 --- a/tools/patman/func_test.py +++ b/tools/patman/func_test.py @@ -540,7 +540,8 @@ complicated as possible''') with open('.patman', 'w', buffering=1) as f: f.write('[settings]\n' 'get_maintainer_script: dummy-script.sh\n' - 'check_patch: False\n') + 'check_patch: False\n' + 'add_maintainers: True\n') with open('dummy-script.sh', 'w', buffering=1) as f: f.write('#!/usr/bin/env python\n' 'print("hello@there.com")\n')
If add_maintainers is set to False in the user's ~/.patman config, it will cause the custom_get_maintainer_script to fail since that test expects maintainers to be added. Set add_maintainer to True in the .patman config to prevent this. Fixes: 8c042fb7f9f ("patman: add '--get-maintainer-script' argument") Signed-off-by: Sean Anderson <seanga2@gmail.com> --- tools/patman/func_test.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)