Message ID | 20240416002624.1909-1-yasuharu.shibata@gmail.com |
---|---|
State | Accepted |
Commit | beac9581531d7882df8c1de653db18fb3ab4100a |
Delegated to: | Tom Rini |
Headers | show |
Series | [v2] net: wget: fix TCP sequence number wrap around issue | expand |
On Tue, 16 Apr 2024 09:26:24 +0900, Yasuharu Shibata wrote: > If tcp_seq_num is wrap around, tcp_seq_num >= initial_data_seq_num > isn't satisfied and store_block() isn't called. > The condition has a wrap around issue, so it is fixed in this patch. > > Applied to u-boot/master, thanks!
diff --git a/net/wget.c b/net/wget.c index 71bac92d84..abab371e58 100644 --- a/net/wget.c +++ b/net/wget.c @@ -404,9 +404,7 @@ static void wget_handler(uchar *pkt, u16 dport, } next_data_seq_num = tcp_seq_num + len; - if (tcp_seq_num >= initial_data_seq_num && - store_block(pkt, tcp_seq_num - initial_data_seq_num, - len) != 0) { + if (store_block(pkt, tcp_seq_num - initial_data_seq_num, len) != 0) { wget_fail("wget: store error\n", tcp_seq_num, tcp_ack_num, action); net_set_state(NETLOOP_FAIL);