diff mbox series

[v3,14/16] adc: add missing depends on ADC for controller drivers

Message ID 20240304-rk3588-saradc-v3-14-7424e2ed5d3b@theobroma-systems.com
State Accepted
Delegated to: Kever Yang
Headers show
Series rockchip: add support for SARADCv2 and RK806 PMIC and regulators | expand

Commit Message

Quentin Schulz March 4, 2024, 11:30 a.m. UTC
From: Quentin Schulz <quentin.schulz@theobroma-systems.com>

The ADC controller drivers are obviously all depending on ADC symbol
being selected.

While they don't seem to fail to build without, they won't be useful
without that symbol selected, so let's make sure the options aren't
shown in menuconfig when ADC isn't selected.

Cc: Quentin Schulz <foss+uboot@0leil.net>
Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
---
 drivers/adc/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Kever Yang March 12, 2024, 3:50 a.m. UTC | #1
On 2024/3/4 19:30, Quentin Schulz wrote:
> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>
> The ADC controller drivers are obviously all depending on ADC symbol
> being selected.
>
> While they don't seem to fail to build without, they won't be useful
> without that symbol selected, so let's make sure the options aren't
> shown in menuconfig when ADC isn't selected.
>
> Cc: Quentin Schulz <foss+uboot@0leil.net>
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   drivers/adc/Kconfig | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/adc/Kconfig b/drivers/adc/Kconfig
> index a01d73846b7..c9cdbe6942d 100644
> --- a/drivers/adc/Kconfig
> +++ b/drivers/adc/Kconfig
> @@ -13,6 +13,7 @@ config ADC
>   
>   config ADC_EXYNOS
>   	bool "Enable Exynos 54xx ADC driver"
> +	depends on ADC
>   	help
>   	  This enables basic driver for Exynos ADC compatible with Exynos54xx.
>   	  It provides:
> @@ -22,6 +23,7 @@ config ADC_EXYNOS
>   
>   config ADC_SANDBOX
>   	bool "Enable Sandbox ADC test driver"
> +	depends on ADC
>   	help
>   	  This enables driver for Sandbox ADC device emulation.
>   	  It provides:
> @@ -31,6 +33,7 @@ config ADC_SANDBOX
>   
>   config SARADC_MESON
>   	bool "Enable Amlogic Meson SARADC driver"
> +	depends on ADC
>   	imply REGMAP
>   	help
>   	  This enables driver for Amlogic Meson SARADC.
> @@ -41,6 +44,7 @@ config SARADC_MESON
>   
>   config SARADC_ROCKCHIP
>   	bool "Enable Rockchip SARADC driver"
> +	depends on ADC
>   	help
>   	  This enables driver for Rockchip SARADC.
>   	  It provides:
>
diff mbox series

Patch

diff --git a/drivers/adc/Kconfig b/drivers/adc/Kconfig
index a01d73846b7..c9cdbe6942d 100644
--- a/drivers/adc/Kconfig
+++ b/drivers/adc/Kconfig
@@ -13,6 +13,7 @@  config ADC
 
 config ADC_EXYNOS
 	bool "Enable Exynos 54xx ADC driver"
+	depends on ADC
 	help
 	  This enables basic driver for Exynos ADC compatible with Exynos54xx.
 	  It provides:
@@ -22,6 +23,7 @@  config ADC_EXYNOS
 
 config ADC_SANDBOX
 	bool "Enable Sandbox ADC test driver"
+	depends on ADC
 	help
 	  This enables driver for Sandbox ADC device emulation.
 	  It provides:
@@ -31,6 +33,7 @@  config ADC_SANDBOX
 
 config SARADC_MESON
 	bool "Enable Amlogic Meson SARADC driver"
+	depends on ADC
 	imply REGMAP
 	help
 	  This enables driver for Amlogic Meson SARADC.
@@ -41,6 +44,7 @@  config SARADC_MESON
 
 config SARADC_ROCKCHIP
 	bool "Enable Rockchip SARADC driver"
+	depends on ADC
 	help
 	  This enables driver for Rockchip SARADC.
 	  It provides: