Message ID | 20231222201617.79950-1-xypron.glpk@gmx.de |
---|---|
State | Superseded, archived |
Delegated to: | Tom Rini |
Headers | show |
Series | [1/1] smbios: type2: contained object handles | expand |
On Fri, Dec 22, 2023 at 8:21 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > The type 2 structure must include information about the contained objects. > It is fine to set the number of contained object handles to 0. > > Add the missing field. > > Fixes: 721e992a8af5 ("x86: Add SMBIOS table support") > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > include/smbios.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/smbios.h b/include/smbios.h > index e601283d29..88c19ae062 100644 > --- a/include/smbios.h > +++ b/include/smbios.h > @@ -139,6 +139,7 @@ struct __packed smbios_type2 { > u8 chassis_location; > u16 chassis_handle; > u8 board_type; > + u8 number_contained_objects; num_contained_objs would be shorter Reviewed-by: Simon Glass <sjg@chromium.org> > char eos[SMBIOS_STRUCT_EOS_BYTES]; > }; > > -- > 2.43.0 >
On Fri, 22 Dec 2023 at 22:16, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > The type 2 structure must include information about the contained objects. > It is fine to set the number of contained object handles to 0. > > Add the missing field. > > Fixes: 721e992a8af5 ("x86: Add SMBIOS table support") > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > include/smbios.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/smbios.h b/include/smbios.h > index e601283d29..88c19ae062 100644 > --- a/include/smbios.h > +++ b/include/smbios.h > @@ -139,6 +139,7 @@ struct __packed smbios_type2 { > u8 chassis_location; > u16 chassis_handle; > u8 board_type; > + u8 number_contained_objects; > char eos[SMBIOS_STRUCT_EOS_BYTES]; > }; > > -- > 2.43.0 > Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
diff --git a/include/smbios.h b/include/smbios.h index e601283d29..88c19ae062 100644 --- a/include/smbios.h +++ b/include/smbios.h @@ -139,6 +139,7 @@ struct __packed smbios_type2 { u8 chassis_location; u16 chassis_handle; u8 board_type; + u8 number_contained_objects; char eos[SMBIOS_STRUCT_EOS_BYTES]; };
The type 2 structure must include information about the contained objects. It is fine to set the number of contained object handles to 0. Add the missing field. Fixes: 721e992a8af5 ("x86: Add SMBIOS table support") Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- include/smbios.h | 1 + 1 file changed, 1 insertion(+) -- 2.43.0