From patchwork Fri Dec 22 15:01:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1879709 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=gmx.de header.i=xypron.glpk@gmx.de header.a=rsa-sha256 header.s=s31663417 header.b=P6+nP/zK; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SxVs10qcWz1ydZ for ; Sat, 23 Dec 2023 02:02:29 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0BCCB877CD; Fri, 22 Dec 2023 16:02:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=gmx.de header.i=xypron.glpk@gmx.de header.b="P6+nP/zK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D95F087846; Fri, 22 Dec 2023 16:02:19 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0578187831 for ; Fri, 22 Dec 2023 16:02:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1703257337; x=1703862137; i=xypron.glpk@gmx.de; bh=9b1bv3sdKY7JP8aLIJGJG6+cgN3CEvTWv8/ifcncweY=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=P6+nP/zKe5iI7qQ9+Cd7FkOlDyS2ec3O56vu6tQ52aX8Wyr336XCEAmIs3elkpR/ sDVQxRgcRzYHT8DYRn8+Nwz4DQP/lOLVOrrmqNc8acVWzzqRQpkKxWG/w/fXwlckP 91ZaYP0JZVYxVEqRuPb5jzHXjrLfsEKRL4WO1MAHt4xDb4AvrR5Vrp3IK1cGN92F0 53t1DkF+0BBp9g+K1BkT6Nulbo8zYBmdlsPcRmVO33zOC6YCD/9MXWSn3c0u3SwBE P+IZ45M2+jWtpXQPO7WeoEkoVgIkfLVa4dv/QC6HaQ9LFtC0g88xgnbudvFuvGey8 /kn4zjaVwj+SB8ijqQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from x13s.fritz.box ([178.202.40.247]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MNbkv-1rfGQl3eJv-00P5gd; Fri, 22 Dec 2023 16:02:16 +0100 From: Heinrich Schuchardt To: Simon Glass Cc: Ilias Apalodimas , AKASHI Takahiro , u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] bootmeth: pass size to efi_binary_run() Date: Fri, 22 Dec 2023 16:01:56 +0100 Message-ID: <20231222150156.39783-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:avBBmwuDi190atLYH7Bjbzmn0a9jjlEoCKnF/adoiibGG+8YsQR 2/xV6IqW6GXn8C7pX2Q22noekrPosSLOU+oUL+X8MIV37UeuJ2eNIJva3LH+GCbiwN0o1jW EK6LZPmzfpMLO0GjA1w5c4Vhd8dzmYb0LC9hoLrCyaED41KU6YGeYOIOjJ/C99oL1hZw6Uv mSVZrCxwUwyc585Ys/eWA== UI-OutboundReport: notjunk:1;M01:P0:V24DXcLmhLI=;aMmhW1fbnTahzIxqgYU2qXF4M0Y O3oND0jL1JeKs3fy7nJN6xCHZ3ox1FVxGdSlgzqhVThba7lQY4V9VJLkHeSQheLSkIgw7OqW2 dxXEkPVR+2RHtNFWFlc40mOGnKPm+pCL5gjYEcOje64BPM7BA+8wbXE99jZdq6wina4mZSL/W StJPeSQUDFDB7FK+PfWeIq+vLq+9vHe2vB+dI5pk9wXSXVjJznYUVjTBsDTzbQjj5bItgi7/3 COSedOeYvvDGKv/BvtwxhDiSBr3p6fGAxTT4ZouDv4B27IHWGU61umrSV5DoJ5+Q1ABZwYvfl QL7Xpe6BNwJQyAUhUcIH2gLVqDWkjEugmIZX++tLRi6Kwqx6IaAJN4jeeJU4q5g70erhs8eo0 nqbmN+1qAvaQA8jxDbwmRdSwVF89FJjtiWHCxrcMmQaRb/G/PfpEP+9dJWyQuU+zG2aQ9Dqwf mFxlpmQ+vDR3/rq4OvR5dE4nAQjTx8H9K6itYfec9trSkDjSRUe+ro9wge3fHHo8UdCD7pgeh zlTya01b5hj7zGpcxJfyrBLqMFW6ZU22iMNTeVPU+Gp+wv78pF1wtXMJknfeYBKZaqmsv8Lo/ K9m0pmViCW/QKvtwOQtshBt9zBSe3o0DY2ulVUYsYLK1bFRYPQ57UmcljViZpBxwoHHG+gvg8 y6705GNzOwM5X4jFVBXOPTmy8u/KLLMI+kaEhyIuEfi2hqJbMFBCR/J6ue4+gGyTIFFeWKB/j pkrKDyEY28ElmGmIzLm8a76miFpULt+vWafAafLaXlZTGBsCQGKvZOAeB1owLDFniGi8CeKw+ xHRZZ2QAup0Yc1y2+KfrSS18MrTbXl40YBYm5Gkb1aqqn6eGo7y/wfQ1CdWhtkKUfpO+IFB/b I6z3IELYECRb9rzlZWqIuoZoryZUHcuYASUPhlZ7pP2adnsPHM/ytOnAkWFYcz/17mOg6b8jv YU4SvH7EJn4g8cwg1QS/o1z7GDE= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean If we call efi_binary_run() with size parameter set to zero, we get an error Not a PE-COFF file Fill the missing value. Fixes: 1373ffde52e1 ("Merge tag 'v2024.01-rc5' into next") Fixes: 7017fc54a5bc ("bootmeth: use efi_loader interfaces instead of bootefi command") Signed-off-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas --- boot/bootmeth_efi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.43.0 diff --git a/boot/bootmeth_efi.c b/boot/bootmeth_efi.c index 00060f7d25..c4eb331d69 100644 --- a/boot/bootmeth_efi.c +++ b/boot/bootmeth_efi.c @@ -454,12 +454,12 @@ static int distro_efi_boot(struct udevice *dev, struct bootflow *bflow) if (bflow->flags & BOOTFLOWF_USE_BUILTIN_FDT) { log_debug("Booting with built-in fdt\n"); - if (efi_binary_run(map_sysmem(kernel, 0), 0, + if (efi_binary_run(map_sysmem(kernel, 0), bflow->size, EFI_FDT_USE_INTERNAL)) return log_msg_ret("run", -EINVAL); } else { log_debug("Booting with external fdt\n"); - if (efi_binary_run(map_sysmem(kernel, 0), 0, + if (efi_binary_run(map_sysmem(kernel, 0), bflow->size, map_sysmem(fdt, 0))) return log_msg_ret("run", -EINVAL); }