diff mbox series

[v1,1/2] poplar: use random mac address

Message ID 20231109223435.706053-1-igor.opaniuk@foundries.io
State Accepted
Commit 01201dbd3babf93ea9a99bb329107208da66683b
Delegated to: Tom Rini
Headers show
Series [v1,1/2] poplar: use random mac address | expand

Commit Message

Igor Opaniuk Nov. 9, 2023, 10:34 p.m. UTC
Set CONFIG_NET_RANDOM_ETHADDR=y, which sets random eth address in
case there is no configuration provided neither in CONFIG_ETHADDR
nor in "ethaddr" env variable.

This fixes the problem:
poplar# dhcp
Error: ethernet@9841000 address not set.

Signed-off-by: Igor Opaniuk <igor.opaniuk@foundries.io>
---

 configs/poplar_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Sam Protsenko Nov. 10, 2023, 1:55 a.m. UTC | #1
On Thu, Nov 9, 2023 at 4:34 PM Igor Opaniuk <igor.opaniuk@foundries.io> wrote:
>
> Set CONFIG_NET_RANDOM_ETHADDR=y, which sets random eth address in
> case there is no configuration provided neither in CONFIG_ETHADDR
> nor in "ethaddr" env variable.
>
> This fixes the problem:
> poplar# dhcp
> Error: ethernet@9841000 address not set.
>
> Signed-off-by: Igor Opaniuk <igor.opaniuk@foundries.io>
> ---

Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>

>
>  configs/poplar_defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/configs/poplar_defconfig b/configs/poplar_defconfig
> index f0ab2319a4..b6e0c3166c 100644
> --- a/configs/poplar_defconfig
> +++ b/configs/poplar_defconfig
> @@ -22,6 +22,7 @@ CONFIG_CMD_USB=y
>  # CONFIG_ISO_PARTITION is not set
>  CONFIG_ENV_IS_IN_MMC=y
>  CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> +CONFIG_NET_RANDOM_ETHADDR=y
>  CONFIG_USB_FUNCTION_FASTBOOT=y
>  CONFIG_FASTBOOT_BUF_ADDR=0x20000000
>  CONFIG_FASTBOOT_BUF_SIZE=0x10000000
> --
> 2.34.1
>
Tom Rini Nov. 17, 2023, 1:42 p.m. UTC | #2
On Thu, Nov 09, 2023 at 11:34:34PM +0100, Igor Opaniuk wrote:

> Set CONFIG_NET_RANDOM_ETHADDR=y, which sets random eth address in
> case there is no configuration provided neither in CONFIG_ETHADDR
> nor in "ethaddr" env variable.
> 
> This fixes the problem:
> poplar# dhcp
> Error: ethernet@9841000 address not set.
> 
> Signed-off-by: Igor Opaniuk <igor.opaniuk@foundries.io>
> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>

Applied to u-boot/next, thanks!
diff mbox series

Patch

diff --git a/configs/poplar_defconfig b/configs/poplar_defconfig
index f0ab2319a4..b6e0c3166c 100644
--- a/configs/poplar_defconfig
+++ b/configs/poplar_defconfig
@@ -22,6 +22,7 @@  CONFIG_CMD_USB=y
 # CONFIG_ISO_PARTITION is not set
 CONFIG_ENV_IS_IN_MMC=y
 CONFIG_SYS_RELOC_GD_ENV_ADDR=y
+CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_USB_FUNCTION_FASTBOOT=y
 CONFIG_FASTBOOT_BUF_ADDR=0x20000000
 CONFIG_FASTBOOT_BUF_SIZE=0x10000000