Message ID | 20231014204805.439009-17-seanga2@gmail.com |
---|---|
State | Accepted |
Commit | 7ccc6044e964829459fa089da01b742a442df65e |
Delegated to: | Tom Rini |
Headers | show |
Series | test: spl: Test some load methods | expand |
Am 14. Oktober 2023 22:47:52 MESZ schrieb Sean Anderson <seanga2@gmail.com>: >These defines are useful when testing bootp. > >Signed-off-by: Sean Anderson <seanga2@gmail.com> >Reviewed-by: Simon Glass <sjg@chromium.org> >Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de> >--- > >(no changes since v1) > > net/bootp.c | 3 --- > net/bootp.h | 3 +++ > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/net/bootp.c b/net/bootp.c >index 8b1a4ae2ef8..2053cce88c6 100644 >--- a/net/bootp.c >+++ b/net/bootp.c >@@ -41,9 +41,6 @@ > */ > #define TIMEOUT_MS ((3 + (CONFIG_NET_RETRY_COUNT * 5)) * 1000) > >-#define PORT_BOOTPS 67 /* BOOTP server UDP port */ >-#define PORT_BOOTPC 68 /* BOOTP client UDP port */ >- > #ifndef CFG_DHCP_MIN_EXT_LEN /* minimal length of extension list */ > #define CFG_DHCP_MIN_EXT_LEN 64 > #endif >diff --git a/net/bootp.h b/net/bootp.h >index 567340ec5d4..4e32b19d424 100644 >--- a/net/bootp.h >+++ b/net/bootp.h >@@ -15,6 +15,9 @@ > > /**********************************************************************/ > >+#define PORT_BOOTPS 67 /* BOOTP server UDP port */ Reading code I would have a hard time to immediately see what this constant name stands for. Shouldn't this be renamed BOOTP_SERVER_PORT to create readable code? Regards Heinrich >+#define PORT_BOOTPC 68 /* BOOTP client UDP port */ >+ > /* > * BOOTP header. > */
On Sat, Oct 14, 2023 at 11:20:31PM +0200, Heinrich Schuchardt wrote: > > > Am 14. Oktober 2023 22:47:52 MESZ schrieb Sean Anderson <seanga2@gmail.com>: > >These defines are useful when testing bootp. > > > >Signed-off-by: Sean Anderson <seanga2@gmail.com> > >Reviewed-by: Simon Glass <sjg@chromium.org> > >Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > >--- > > > >(no changes since v1) > > > > net/bootp.c | 3 --- > > net/bootp.h | 3 +++ > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > >diff --git a/net/bootp.c b/net/bootp.c > >index 8b1a4ae2ef8..2053cce88c6 100644 > >--- a/net/bootp.c > >+++ b/net/bootp.c > >@@ -41,9 +41,6 @@ > > */ > > #define TIMEOUT_MS ((3 + (CONFIG_NET_RETRY_COUNT * 5)) * 1000) > > > >-#define PORT_BOOTPS 67 /* BOOTP server UDP port */ > >-#define PORT_BOOTPC 68 /* BOOTP client UDP port */ > >- > > #ifndef CFG_DHCP_MIN_EXT_LEN /* minimal length of extension list */ > > #define CFG_DHCP_MIN_EXT_LEN 64 > > #endif > >diff --git a/net/bootp.h b/net/bootp.h > >index 567340ec5d4..4e32b19d424 100644 > >--- a/net/bootp.h > >+++ b/net/bootp.h > >@@ -15,6 +15,9 @@ > > > > /**********************************************************************/ > > > >+#define PORT_BOOTPS 67 /* BOOTP server UDP port */ > > Reading code I would have a hard time to immediately see what this constant name stands for. > > Shouldn't this be renamed BOOTP_SERVER_PORT to create readable code? We're just moving the code around for now, and this should get replaced by lwip in time.
diff --git a/net/bootp.c b/net/bootp.c index 8b1a4ae2ef8..2053cce88c6 100644 --- a/net/bootp.c +++ b/net/bootp.c @@ -41,9 +41,6 @@ */ #define TIMEOUT_MS ((3 + (CONFIG_NET_RETRY_COUNT * 5)) * 1000) -#define PORT_BOOTPS 67 /* BOOTP server UDP port */ -#define PORT_BOOTPC 68 /* BOOTP client UDP port */ - #ifndef CFG_DHCP_MIN_EXT_LEN /* minimal length of extension list */ #define CFG_DHCP_MIN_EXT_LEN 64 #endif diff --git a/net/bootp.h b/net/bootp.h index 567340ec5d4..4e32b19d424 100644 --- a/net/bootp.h +++ b/net/bootp.h @@ -15,6 +15,9 @@ /**********************************************************************/ +#define PORT_BOOTPS 67 /* BOOTP server UDP port */ +#define PORT_BOOTPC 68 /* BOOTP client UDP port */ + /* * BOOTP header. */