| Message ID | 20231001141529.1784336-1-massimo.pegorer+oss@gmail.com |
|---|---|
| State | Accepted |
| Commit | b9155e754e124b1fce407f526db7782943c16227 |
| Delegated to: | Kever Yang |
| Headers | show |
| Series | [v2] configs: rockchip: add DOS_PARTITION to RK3308 boards defconfig | expand |
On 2023/10/1 22:15, Massimo Pegorer wrote: > Without DOS_PARTITION support U-Boot is not able to boot an OS stored > into an SD card with MBR partitions table. This is still a quite common > case so add DOS_PARTITION (only for U-Boot proper build) to Rockchip > RK3308 EVB, Radxa ROCK Pi S and Firefly roc-rk3308-cc boards: they are > the only RK boards missing of DOS_PARTITION. > > Reported-by: Jayantajit Gogoi <jayanta.gogoi525@gmail.com> > Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com> Reviewed-by: Kever Yang <kever.yang@rock-chips.com> Thanks, - Kever > --- > configs/evb-rk3308_defconfig | 2 +- > configs/roc-cc-rk3308_defconfig | 2 +- > configs/rock-pi-s-rk3308_defconfig | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/configs/evb-rk3308_defconfig b/configs/evb-rk3308_defconfig > index a13a809c1e..c6472a2c9c 100644 > --- a/configs/evb-rk3308_defconfig > +++ b/configs/evb-rk3308_defconfig > @@ -47,7 +47,7 @@ CONFIG_CMD_USB_MASS_STORAGE=y > # CONFIG_CMD_ITEST is not set > # CONFIG_CMD_SETEXPR is not set > # CONFIG_CMD_SLEEP is not set > -# CONFIG_DOS_PARTITION is not set > +# CONFIG_SPL_DOS_PARTITION is not set > # CONFIG_ISO_PARTITION is not set > CONFIG_EFI_PARTITION_ENTRIES_NUMBERS=64 > CONFIG_SPL_OF_CONTROL=y > diff --git a/configs/roc-cc-rk3308_defconfig b/configs/roc-cc-rk3308_defconfig > index 9a789b212f..ca92b8f744 100644 > --- a/configs/roc-cc-rk3308_defconfig > +++ b/configs/roc-cc-rk3308_defconfig > @@ -47,7 +47,7 @@ CONFIG_CMD_USB_MASS_STORAGE=y > # CONFIG_CMD_ITEST is not set > # CONFIG_CMD_SETEXPR is not set > # CONFIG_CMD_SLEEP is not set > -# CONFIG_DOS_PARTITION is not set > +# CONFIG_SPL_DOS_PARTITION is not set > # CONFIG_ISO_PARTITION is not set > CONFIG_EFI_PARTITION_ENTRIES_NUMBERS=64 > CONFIG_SPL_OF_CONTROL=y > diff --git a/configs/rock-pi-s-rk3308_defconfig b/configs/rock-pi-s-rk3308_defconfig > index cc3274a98b..1c1fdc6611 100644 > --- a/configs/rock-pi-s-rk3308_defconfig > +++ b/configs/rock-pi-s-rk3308_defconfig > @@ -48,7 +48,7 @@ CONFIG_CMD_USB_MASS_STORAGE=y > # CONFIG_CMD_ITEST is not set > # CONFIG_CMD_SETEXPR is not set > # CONFIG_CMD_SLEEP is not set > -# CONFIG_DOS_PARTITION is not set > +# CONFIG_SPL_DOS_PARTITION is not set > # CONFIG_ISO_PARTITION is not set > CONFIG_EFI_PARTITION_ENTRIES_NUMBERS=64 > CONFIG_SPL_OF_CONTROL=y
diff --git a/configs/evb-rk3308_defconfig b/configs/evb-rk3308_defconfig index a13a809c1e..c6472a2c9c 100644 --- a/configs/evb-rk3308_defconfig +++ b/configs/evb-rk3308_defconfig @@ -47,7 +47,7 @@ CONFIG_CMD_USB_MASS_STORAGE=y # CONFIG_CMD_ITEST is not set # CONFIG_CMD_SETEXPR is not set # CONFIG_CMD_SLEEP is not set -# CONFIG_DOS_PARTITION is not set +# CONFIG_SPL_DOS_PARTITION is not set # CONFIG_ISO_PARTITION is not set CONFIG_EFI_PARTITION_ENTRIES_NUMBERS=64 CONFIG_SPL_OF_CONTROL=y diff --git a/configs/roc-cc-rk3308_defconfig b/configs/roc-cc-rk3308_defconfig index 9a789b212f..ca92b8f744 100644 --- a/configs/roc-cc-rk3308_defconfig +++ b/configs/roc-cc-rk3308_defconfig @@ -47,7 +47,7 @@ CONFIG_CMD_USB_MASS_STORAGE=y # CONFIG_CMD_ITEST is not set # CONFIG_CMD_SETEXPR is not set # CONFIG_CMD_SLEEP is not set -# CONFIG_DOS_PARTITION is not set +# CONFIG_SPL_DOS_PARTITION is not set # CONFIG_ISO_PARTITION is not set CONFIG_EFI_PARTITION_ENTRIES_NUMBERS=64 CONFIG_SPL_OF_CONTROL=y diff --git a/configs/rock-pi-s-rk3308_defconfig b/configs/rock-pi-s-rk3308_defconfig index cc3274a98b..1c1fdc6611 100644 --- a/configs/rock-pi-s-rk3308_defconfig +++ b/configs/rock-pi-s-rk3308_defconfig @@ -48,7 +48,7 @@ CONFIG_CMD_USB_MASS_STORAGE=y # CONFIG_CMD_ITEST is not set # CONFIG_CMD_SETEXPR is not set # CONFIG_CMD_SLEEP is not set -# CONFIG_DOS_PARTITION is not set +# CONFIG_SPL_DOS_PARTITION is not set # CONFIG_ISO_PARTITION is not set CONFIG_EFI_PARTITION_ENTRIES_NUMBERS=64 CONFIG_SPL_OF_CONTROL=y
Without DOS_PARTITION support U-Boot is not able to boot an OS stored into an SD card with MBR partitions table. This is still a quite common case so add DOS_PARTITION (only for U-Boot proper build) to Rockchip RK3308 EVB, Radxa ROCK Pi S and Firefly roc-rk3308-cc boards: they are the only RK boards missing of DOS_PARTITION. Reported-by: Jayantajit Gogoi <jayanta.gogoi525@gmail.com> Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com> --- configs/evb-rk3308_defconfig | 2 +- configs/roc-cc-rk3308_defconfig | 2 +- configs/rock-pi-s-rk3308_defconfig | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)