| Message ID | 20230909093324.11954-1-massimo.pegorer+oss@gmail.com |
|---|---|
| State | Accepted |
| Commit | 9e13fef00b8dc90c6e6bcf46012773a5497d0196 |
| Delegated to: | Kever Yang |
| Headers | show |
| Series | rockchip: Use an external TPL binary on RK3308 | expand |
hi, On 9/9/23 18:33, Massimo Pegorer wrote: > There is no support to initialize DRAM on rk3308 SoC using U-Boot > TPL or SPL, and therefore an external TPL binary must be used to > package a bootable u-boot-rockchip.bin image. > > Default ROCKCHIP_EXTERNAL_TPL to yes if ROCKCHIP_RK3308. > Remove useless TPL_SERIAL. > > Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com> > --- > arch/arm/mach-rockchip/Kconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Tested-by: FUKAUMI Naoki <naoki@radxa.com> thank you very much for your work! > diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig > index a279582f4f..3b044269bd 100644 > --- a/arch/arm/mach-rockchip/Kconfig > +++ b/arch/arm/mach-rockchip/Kconfig > @@ -166,7 +166,6 @@ config ROCKCHIP_RK3308 > imply SPL_SYSCON > imply SPL_RAM > imply SPL_SERIAL > - imply TPL_SERIAL > imply SPL_SEPARATE_BSS > help > The Rockchip RK3308 is a ARM-based Soc which embedded with quad > @@ -436,7 +435,7 @@ config TPL_ROCKCHIP_COMMON_BOARD > > config ROCKCHIP_EXTERNAL_TPL > bool "Use external TPL binary" > - default y if ROCKCHIP_RK3568 || ROCKCHIP_RK3588 > + default y if ROCKCHIP_RK3308 || ROCKCHIP_RK3568 || ROCKCHIP_RK3588 > help > Some Rockchip SoCs require an external TPL to initialize DRAM. > Enable this option and build with ROCKCHIP_TPL=/path/to/ddr.bin to
On 2023/9/9 17:33, Massimo Pegorer wrote: > There is no support to initialize DRAM on rk3308 SoC using U-Boot > TPL or SPL, and therefore an external TPL binary must be used to > package a bootable u-boot-rockchip.bin image. > > Default ROCKCHIP_EXTERNAL_TPL to yes if ROCKCHIP_RK3308. > Remove useless TPL_SERIAL. > > Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com> Reviewed-by: Kever Yang <kever.yang@rock-chips.com> Thanks, - Kever > --- > arch/arm/mach-rockchip/Kconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig > index a279582f4f..3b044269bd 100644 > --- a/arch/arm/mach-rockchip/Kconfig > +++ b/arch/arm/mach-rockchip/Kconfig > @@ -166,7 +166,6 @@ config ROCKCHIP_RK3308 > imply SPL_SYSCON > imply SPL_RAM > imply SPL_SERIAL > - imply TPL_SERIAL > imply SPL_SEPARATE_BSS > help > The Rockchip RK3308 is a ARM-based Soc which embedded with quad > @@ -436,7 +435,7 @@ config TPL_ROCKCHIP_COMMON_BOARD > > config ROCKCHIP_EXTERNAL_TPL > bool "Use external TPL binary" > - default y if ROCKCHIP_RK3568 || ROCKCHIP_RK3588 > + default y if ROCKCHIP_RK3308 || ROCKCHIP_RK3568 || ROCKCHIP_RK3588 > help > Some Rockchip SoCs require an external TPL to initialize DRAM. > Enable this option and build with ROCKCHIP_TPL=/path/to/ddr.bin to
diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig index a279582f4f..3b044269bd 100644 --- a/arch/arm/mach-rockchip/Kconfig +++ b/arch/arm/mach-rockchip/Kconfig @@ -166,7 +166,6 @@ config ROCKCHIP_RK3308 imply SPL_SYSCON imply SPL_RAM imply SPL_SERIAL - imply TPL_SERIAL imply SPL_SEPARATE_BSS help The Rockchip RK3308 is a ARM-based Soc which embedded with quad @@ -436,7 +435,7 @@ config TPL_ROCKCHIP_COMMON_BOARD config ROCKCHIP_EXTERNAL_TPL bool "Use external TPL binary" - default y if ROCKCHIP_RK3568 || ROCKCHIP_RK3588 + default y if ROCKCHIP_RK3308 || ROCKCHIP_RK3568 || ROCKCHIP_RK3588 help Some Rockchip SoCs require an external TPL to initialize DRAM. Enable this option and build with ROCKCHIP_TPL=/path/to/ddr.bin to
There is no support to initialize DRAM on rk3308 SoC using U-Boot TPL or SPL, and therefore an external TPL binary must be used to package a bootable u-boot-rockchip.bin image. Default ROCKCHIP_EXTERNAL_TPL to yes if ROCKCHIP_RK3308. Remove useless TPL_SERIAL. Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com> --- arch/arm/mach-rockchip/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)