diff mbox series

configs: am65x_evm: Use envboot before distro_bootcmd

Message ID 20230908115615.3829854-1-devarsht@ti.com
State Changes Requested
Delegated to: Tom Rini
Headers show
Series configs: am65x_evm: Use envboot before distro_bootcmd | expand

Commit Message

Devarsh Thakkar Sept. 8, 2023, 11:56 a.m. UTC
Use envboot cmd before issuring distro_bootcmd as otherwise
environment variables from uEnv.txt are not getting imported.

The commands after distro_bootcmd have no impact since board starts
booting after distro_bootcmd, so it need to run last after all
environment variables are configured correctly.

Fixes: bde6ac54905 ("configs: am65x_evm: Switch envboot out for
distro_bootcmd")

Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
---
Boot logs (with display overlay) :
https://gist.github.com/devarsht/2bac56933847d3e954d6ee275d711e27
---
 configs/am65x_evm_a53_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini Sept. 8, 2023, 1:42 p.m. UTC | #1
On Fri, Sep 08, 2023 at 05:26:15PM +0530, Devarsh Thakkar wrote:

> Use envboot cmd before issuring distro_bootcmd as otherwise
> environment variables from uEnv.txt are not getting imported.
> 
> The commands after distro_bootcmd have no impact since board starts
> booting after distro_bootcmd, so it need to run last after all
> environment variables are configured correctly.
> 
> Fixes: bde6ac54905 ("configs: am65x_evm: Switch envboot out for
> distro_bootcmd")
> 
> Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
> ---
> Boot logs (with display overlay) :
> https://gist.github.com/devarsht/2bac56933847d3e954d6ee275d711e27
> ---
>  configs/am65x_evm_a53_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configs/am65x_evm_a53_defconfig b/configs/am65x_evm_a53_defconfig
> index 4301553af8..4f1ef10e69 100644
> --- a/configs/am65x_evm_a53_defconfig
> +++ b/configs/am65x_evm_a53_defconfig
> @@ -34,7 +34,7 @@ CONFIG_SPL_LOAD_FIT=y
>  CONFIG_SPL_LOAD_FIT_ADDRESS=0x81000000
>  CONFIG_OF_SYSTEM_SETUP=y
>  CONFIG_DISTRO_DEFAULTS=y
> -CONFIG_BOOTCOMMAND="run findfdt; run distro_bootcmd; run init_${boot}; run boot_rprocs; run get_kern_${boot}; run get_fdt_${boot}; run get_overlay_${boot}; run run_kern"
> +CONFIG_BOOTCOMMAND="run envboot; run distro_bootcmd;"
>  CONFIG_LOGLEVEL=7
>  CONFIG_CONSOLE_MUX=y
>  CONFIG_SPL_MAX_SIZE=0x58000

This should just be switched to standard boot instead.
diff mbox series

Patch

diff --git a/configs/am65x_evm_a53_defconfig b/configs/am65x_evm_a53_defconfig
index 4301553af8..4f1ef10e69 100644
--- a/configs/am65x_evm_a53_defconfig
+++ b/configs/am65x_evm_a53_defconfig
@@ -34,7 +34,7 @@  CONFIG_SPL_LOAD_FIT=y
 CONFIG_SPL_LOAD_FIT_ADDRESS=0x81000000
 CONFIG_OF_SYSTEM_SETUP=y
 CONFIG_DISTRO_DEFAULTS=y
-CONFIG_BOOTCOMMAND="run findfdt; run distro_bootcmd; run init_${boot}; run boot_rprocs; run get_kern_${boot}; run get_fdt_${boot}; run get_overlay_${boot}; run run_kern"
+CONFIG_BOOTCOMMAND="run envboot; run distro_bootcmd;"
 CONFIG_LOGLEVEL=7
 CONFIG_CONSOLE_MUX=y
 CONFIG_SPL_MAX_SIZE=0x58000