From patchwork Mon Aug 7 01:41:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathew McBride X-Patchwork-Id: 1817589 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=traverse.com.au header.i=@traverse.com.au header.a=rsa-sha256 header.s=fm2 header.b=a/dRJYXz; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=bpLXMqBr; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RJzZC4f4yz1yYl for ; Mon, 7 Aug 2023 11:41:39 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CA183868E0; Mon, 7 Aug 2023 03:41:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=traverse.com.au Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=traverse.com.au header.i=@traverse.com.au header.b="a/dRJYXz"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="bpLXMqBr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7E380868E7; Mon, 7 Aug 2023 03:41:34 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A064C868D0 for ; Mon, 7 Aug 2023 03:41:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=traverse.com.au Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=matt@traverse.com.au Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 4AD8B5C0081; Sun, 6 Aug 2023 21:41:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 06 Aug 2023 21:41:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=traverse.com.au; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to; s=fm2; t=1691372490; x=1691458890; bh=ny LxyeXRhm9faOgIJwHOr+K4Trfk22CynHk+Cq5d0qU=; b=a/dRJYXzx9y1JaLuIm ndF6vr6/PXlYl9MJCO3Si6hVUDsBxg+GoFDN2/JoGiUBxAi1S+rSrauy2KD1jFpE oTXukSBOyn1duw+Z4+r6ga9bqw/37f+b7kjqzgCXHwAOFaXLHumPmV5jGtz1dtRM y2BIYim5GtPQx7thQtUsos5Of4Loxn6p14czmRUfBDBnK4u3L0w+mdmaNT4aiTfI FqUBspI1jvMbrIw5ChZ+mbNgT4uzspzSwzsUDScXNjOBBRvpV1jYepp++vUYkSwP j2jKXUPAnUiCpZON+K9l0DCE9RiN1Ga77+BcPpldxARIhoGSaqukrFR+ROd/GbRp uCDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1691372490; x=1691458890; bh=nyLxyeXRhm9fa OgIJwHOr+K4Trfk22CynHk+Cq5d0qU=; b=bpLXMqBrH2csMnfFhKKmE5oT8R5oK 8+1CvvfrwzhfkVI5im0qFbnnjdCSyp8540I2MatZltZH8AXIiDtsMQUW3g85wGB3 G8xp0x/BfkBhGVAFbDGX/gyLY47Exst2srWQjyszaeVwX5TtUSUdmkGJYsygVuLe Ec43/LAoMBzF56rqZmAP+TwiofP+yFRV9GWTLN+Nb/RQAcuy2UZaYGUtfmOg7B5J FwpEWFc0FN28pLGN4+RLW0tJuS9MEru1JLQ+u1P77RsVpY9GbdhnMKNx44mWByPE 8ProKb7E7XyfyhNMcPSF7R3fHOZeEKmUMy+cAG34LXPcdRhmJDh9cH26w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrkeelgdeglecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpeforghthhgvficu ofgtuehrihguvgcuoehmrghtthesthhrrghvvghrshgvrdgtohhmrdgruheqnecuggftrf grthhtvghrnhepgfekteegudffgfdtvedvjeejffdtgffhteefgfeuhefhleejfffgfeeu ueejleffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrthhtsehtrhgrvhgvrhhsvgdrtghomhdrrghu X-ME-Proxy: Feedback-ID: i426947f3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 6 Aug 2023 21:41:28 -0400 (EDT) From: Mathew McBride To: u-boot@lists.denx.de, Peng Fan Cc: Mathew McBride Subject: [PATCH] board: ten64: add missing error checks for retimer power on Date: Mon, 7 Aug 2023 01:41:08 +0000 Message-Id: <20230807014108.28451-1-matt@traverse.com.au> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean The retimer reset/power on logic was changed in a recent commit, however, it neglected to check if the commands sent to the board microcontroller (to control power to the retimer chip) actually completed. Add return checks for these operations so any failures will be reported to the user. Signed-off-by: Mathew McBride Fixes: 7a041fea2 ("board: traverse: ten64: ensure retimer reset is done on new board revisions") --- board/traverse/ten64/ten64.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/board/traverse/ten64/ten64.c b/board/traverse/ten64/ten64.c index 52daae6e24..df9f0afe1a 100644 --- a/board/traverse/ten64/ten64.c +++ b/board/traverse/ten64/ten64.c @@ -383,10 +383,15 @@ static int board_cycle_retimer(struct udevice **retim_dev) puts("(retimer on, resetting...) "); ret = misc_call(uc_dev, TEN64_CNTRL_10G_OFF, NULL, 0, NULL, 0); + if (ret) + return ret; mdelay(1000); } + /* Turn on the retimer */ ret = misc_call(uc_dev, TEN64_CNTRL_10G_ON, NULL, 0, NULL, 0); + if (ret) + return ret; } // Wait for retimer to come back