From patchwork Mon Jul 31 22:42:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 1815290 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=seco.com header.i=@seco.com header.a=rsa-sha256 header.s=selector1 header.b=GMFzfW5k; dkim=pass (2048-bit key) header.d=seco.com header.i=@seco.com header.a=rsa-sha256 header.s=selector1 header.b=GMFzfW5k; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RFCvf1Fs4z1yfC for ; Tue, 1 Aug 2023 08:43:42 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5F17F86ACC; Tue, 1 Aug 2023 00:43:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=seco.com header.i=@seco.com header.b="GMFzfW5k"; dkim=pass (2048-bit key) header.d=seco.com header.i=@seco.com header.b="GMFzfW5k"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D055E8682B; Tue, 1 Aug 2023 00:43:29 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20608.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1a::608]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A2E7786AB6 for ; Tue, 1 Aug 2023 00:43:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sean.anderson@seco.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seco.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ESEKwm2uwUGuwW4FVb+1YnaAvrMtgK5yPv6bIalGuDI=; b=GMFzfW5koOnj76gYyib5Ke1sBe/HCMxTyQkDdDCaQOOk5sQWGjqOh+8mvJKPAptqPPXszr3mMkaB26own96qNohBBqIAyx4g2jWL7JrCR3zgbFG7j4UYLi1v0COjj/foVibnGbfeh7Tn1kuNM45higaEGmOXcm2pTusDqDDSWvGf99w6hYKc2mJyBBX5zuR03s6V33jyzPFzqd76RDW90sZAphOgJgUb12TYboNOiJhUP56pLApkgpn2i0oBfHNrV8+bmiIpwsLtnLkkXPLsOmqbPtdCM+qrrS8I7fdlpHeyDsZqRk/6PWehuKgSV+yJm+LpcQCERKKrrrEormpsBA== Received: from DB8PR06CA0055.eurprd06.prod.outlook.com (2603:10a6:10:120::29) by PAXPR03MB7965.eurprd03.prod.outlook.com (2603:10a6:102:218::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.43; Mon, 31 Jul 2023 22:43:25 +0000 Received: from DB8EUR05FT025.eop-eur05.prod.protection.outlook.com (2603:10a6:10:120:cafe::21) by DB8PR06CA0055.outlook.office365.com (2603:10a6:10:120::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.41 via Frontend Transport; Mon, 31 Jul 2023 22:43:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 20.160.56.82) smtp.mailfrom=seco.com; dkim=pass (signature was verified) header.d=seco.com;dmarc=pass action=none header.from=seco.com; Received-SPF: Pass (protection.outlook.com: domain of seco.com designates 20.160.56.82 as permitted sender) receiver=protection.outlook.com; client-ip=20.160.56.82; helo=inpost-eu.tmcas.trendmicro.com; pr=C Received: from inpost-eu.tmcas.trendmicro.com (20.160.56.82) by DB8EUR05FT025.mail.protection.outlook.com (10.233.239.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29 via Frontend Transport; Mon, 31 Jul 2023 22:43:25 +0000 Received: from outmta (unknown [192.168.82.133]) by inpost-eu.tmcas.trendmicro.com (Trend Micro CAS) with ESMTP id A431C2008008C; Mon, 31 Jul 2023 22:43:24 +0000 (UTC) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown [104.47.17.168]) by repre.tmcas.trendmicro.com (Trend Micro CAS) with ESMTPS id 093622008006F; Mon, 31 Jul 2023 22:43:17 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O+A4pPDaQMJINAWowzyIk+cJvq70uxYPMEmYv2Pjbl1ofsxGC/F69gxj+cAeivOfn2u8v+Ea9jjRSCefBfCRtcTGgoPQzfOOfmMZobmxrbeNOlOdyEQXd2+GZRkJrOhhwVVHBWAo7dD6mZ8zYM850cnJojk0vrMKsyn4fHmV2dxf90xhl4k5y+OegfzRnzGUFBeb+hNNdsIJ7n2W7dUwy4KWAtAfNCWQbYCjWAm2RvJ/ma6JzjY4gTHuXkNbJT/1FGFn45c4205RTM3h+np+i1W4S6AWy5OFOZ2TKuUcB/rffxzjkB2xFDP1uWI7rOM0Z1rGGanOZemT4scgESTLpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ESEKwm2uwUGuwW4FVb+1YnaAvrMtgK5yPv6bIalGuDI=; b=i7+aPoZc67WdOq2JtdMdkYd8f3k5exkzKVPZ6dzwLCjCV+plmLx/okha30xk+F4dI8dKFWecuCtrL4pd87T8XQSBipBvuuy7j1SN/Q3/qoPIazWfMPifzAim0SxqRvw4PtnUQeebyqTNON2lNpBKYOal5R57gvSF/LXSGr2E2FgKmsrWUWN+/cG+n7XR1M7CLAL25+alTeCSOrvoVi2glfT+ATD+Idyki/evqL5b1F12n2lDQwy7+HtVeu3M54kReK1YpWGFMwdE8wHhqF5mvjVsy+RFI6OnGbHW7fTug1sMXieAJHJ6mCg8T93p9z7s/RIb09rvxjUq+6Q8O+iGew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seco.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ESEKwm2uwUGuwW4FVb+1YnaAvrMtgK5yPv6bIalGuDI=; b=GMFzfW5koOnj76gYyib5Ke1sBe/HCMxTyQkDdDCaQOOk5sQWGjqOh+8mvJKPAptqPPXszr3mMkaB26own96qNohBBqIAyx4g2jWL7JrCR3zgbFG7j4UYLi1v0COjj/foVibnGbfeh7Tn1kuNM45higaEGmOXcm2pTusDqDDSWvGf99w6hYKc2mJyBBX5zuR03s6V33jyzPFzqd76RDW90sZAphOgJgUb12TYboNOiJhUP56pLApkgpn2i0oBfHNrV8+bmiIpwsLtnLkkXPLsOmqbPtdCM+qrrS8I7fdlpHeyDsZqRk/6PWehuKgSV+yJm+LpcQCERKKrrrEormpsBA== Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=seco.com; Received: from DB9PR03MB8847.eurprd03.prod.outlook.com (2603:10a6:10:3dd::13) by PAVPR03MB9163.eurprd03.prod.outlook.com (2603:10a6:102:32f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.42; Mon, 31 Jul 2023 22:43:16 +0000 Received: from DB9PR03MB8847.eurprd03.prod.outlook.com ([fe80::65d7:d7d8:711b:2514]) by DB9PR03MB8847.eurprd03.prod.outlook.com ([fe80::65d7:d7d8:711b:2514%5]) with mapi id 15.20.6631.043; Mon, 31 Jul 2023 22:43:16 +0000 From: Sean Anderson To: Tom Rini , u-boot@lists.denx.de Cc: =?utf-8?q?Pali_Roh=C3=A1r?= , Stefan Roese , =?utf-8?q?Marek_Beh=C3=BAn?= , Simon Glass , Xavier Drudis Ferran , Heinrich Schuchardt , Marek Vasut , Sean Anderson Subject: [PATCH v5 01/11] spl: Make SHOW_ERRORS depend on LIBCOMMON Date: Mon, 31 Jul 2023 18:42:53 -0400 Message-Id: <20230731224304.111081-2-sean.anderson@seco.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230731224304.111081-1-sean.anderson@seco.com> References: <20230731224304.111081-1-sean.anderson@seco.com> X-ClientProxiedBy: MN2PR15CA0013.namprd15.prod.outlook.com (2603:10b6:208:1b4::26) To DB9PR03MB8847.eurprd03.prod.outlook.com (2603:10a6:10:3dd::13) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR03MB8847:EE_|PAVPR03MB9163:EE_|DB8EUR05FT025:EE_|PAXPR03MB7965:EE_ X-MS-Office365-Filtering-Correlation-Id: 8332e29f-2647-4967-68b6-08db92178d01 X-TrendMicro-CAS-OUT-LOOP-IDENTIFIER: 656f966764b7fb185830381c646b41a1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3PPwPxHBRONz3Yc7OdGANHdHG9L7HdJX4LH3YBolbCLLyoTXmSAHnSh7t+OyHpF8knN3hBko43+FwuVSEeGnsFvC90OtJhNySXvS8GzQnBGiq6Ifpq9nbRyZ11VYWvovfNfcki66Co1P6RvjaGmzizZkQAZWxgTin9rsCWu+isWGFgqFwWrV/VjeDnW0xxpCcCQgA72rbaq5tU4dKR82GKTi2y12gqqUhIGMhe5iayqfUDsm7eCJIdKFVdorrM2LButCtRDHib4CumA+mrAoS7EiALOpjDVrPBfIB4BaxXtledzp96eWiFCKTayGJc2nlZxJ6b+vizKion/5wN+FpzzuaIa4qcopE2XHeXq8HJ48MLBbMwSKPq6DS0r/68+8h5LZIfLDQAWjoYVKudupUkCCvodogoIUCcu/6m2uNFbvBw9cx4V1f3BwtagMFJfznxbtpTUVtGIQoFr2HntVlPeADkyujR2fR0iz0+kf8h1xNoeFp8b2C5rEmeDUAjD7s2NYQFPMVLJ9vT7vHhMuqXWHyaD52Gyy09pHtDKqNRCnPuVk5e4fQAW2xkjTc2i3NwADW46nWmCJtYb0wMGBm6GrWTLpvZnbXxeWM2gtDKiWn9N5zn8fPlUAx4Sgk0rK X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR03MB8847.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39850400004)(136003)(396003)(366004)(376002)(346002)(451199021)(36756003)(478600001)(38350700002)(38100700002)(86362001)(6512007)(52116002)(6486002)(6666004)(2616005)(186003)(107886003)(8676002)(1076003)(26005)(8936002)(6506007)(5660300002)(44832011)(4326008)(2906002)(66476007)(66946007)(66556008)(54906003)(41300700001)(316002)(83380400001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR03MB9163 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB8EUR05FT025.eop-eur05.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7cdd5954-a05c-4a02-d0b2-08db9217877b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /C+qUIiB8+CKhov+lyXXMVHPlh4k9LAv/tswORxmk41o6SOeqTc3O6uKcq3LwUXIH7Rn/ldjP6qcRa/QuhZuWOMwZPhyhE6ezQgnWbYvQj9P5NksEGazvW4siTE4V9k+MI1aVn32PIUIhn3cpzgZxLuxlaJDRJ9snsi5uziLBPwQcylp9GU40p948tTrgkWVxzv/nm4zfBQo2ssYoj5jCJmDjhLJdpJUaAdR+ugQjvA9oOVW/TUptf1L5DqXiiNPLSx9ja1fynQLCddqzY6vonpPiCiSaJkf4kW2tJT/HqfM8nQJNytC6KgoaZnANdeFehHv9hXqR6Hg4AnamQqZKVJUPgjY0dTzBcbQbINeSEvFESbPIiLPY+DaUR/wLo0VlkWT3aev76mr+R6tfd8zbIASgrhVmRwPjdCKrTP3F4wK+C6p6rFjygCRUe6jeoQWBvW8wA8F1BAfxA5RXVKZR2iRAs/oG0mOFPLhIpAb31r1MF6uJ+97AqfA7ahYR3bJ8TkXUAHA5DirOyOyieP9X/OYMd74hZt75uSvbFBZHgL4VQispq0o8R+37Rfx+R0qYgrXQHIsOpjps+Urd8bY6KDVDPWODr7Yw/Q6kD+S9QgOylPrUYR4/n9cF6zgRSyMuQs3T0IiUUK1RMX/HItFIafNwoV5g6YFQuCOgeYh8LPGnhE/oNSOm0toROHAgJYor+cpi/XJcLzfCiQiUWA6n5D69UbFWn3QpT2alk+dMZkFizb5cvqgSc6JJw9QpgcUjCbcAqJOE/bG1kzw4B6UCQ== X-Forefront-Antispam-Report: CIP:20.160.56.82; CTRY:NL; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:inpost-eu.tmcas.trendmicro.com; PTR:inpost-eu.tmcas.trendmicro.com; CAT:NONE; SFS:(13230028)(39850400004)(376002)(396003)(136003)(346002)(82310400008)(451199021)(36840700001)(46966006)(40470700004)(6512007)(40460700003)(6486002)(6666004)(36860700001)(34070700002)(186003)(83380400001)(2616005)(47076005)(36756003)(86362001)(336012)(356005)(82740400003)(26005)(7596003)(7636003)(1076003)(6506007)(40480700001)(5660300002)(4326008)(41300700001)(8936002)(8676002)(70206006)(70586007)(2906002)(316002)(107886003)(478600001)(54906003)(44832011); DIR:OUT; SFP:1101; X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2023 22:43:25.0015 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8332e29f-2647-4967-68b6-08db92178d01 X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bebe97c3-6438-442e-ade3-ff17aa50e733; Ip=[20.160.56.82]; Helo=[inpost-eu.tmcas.trendmicro.com] X-MS-Exchange-CrossTenant-AuthSource: DB8EUR05FT025.eop-eur05.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB7965 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean The purpose of SHOW_ERRORS is to print extra information. Make it depend on LIBCOMMON to avoid having to check for two configs. Signed-off-by: Sean Anderson Reviewed-by: Tom Rini --- Changes in v5: - New common/spl/Kconfig | 1 + common/spl/spl.c | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/spl/Kconfig b/common/spl/Kconfig index bee231b583..ce3efeb0ce 100644 --- a/common/spl/Kconfig +++ b/common/spl/Kconfig @@ -183,6 +183,7 @@ config SPL_SYS_REPORT_STACK_F_USAGE config SPL_SHOW_ERRORS bool "Show more information when something goes wrong" + depends on SPL_LIBCOMMON_SUPPORT help This enabled more verbose error messages and checking when something goes wrong in SPL. For example, it shows the error code when U-Boot diff --git a/common/spl/spl.c b/common/spl/spl.c index d74acec10b..b98a9a062a 100644 --- a/common/spl/spl.c +++ b/common/spl/spl.c @@ -820,8 +820,7 @@ void board_init_r(gd_t *dummy1, ulong dummy2) ret = boot_from_devices(&spl_image, spl_boot_list, ARRAY_SIZE(spl_boot_list)); if (ret) { - if (CONFIG_IS_ENABLED(SHOW_ERRORS) && - CONFIG_IS_ENABLED(LIBCOMMON_SUPPORT)) + if (CONFIG_IS_ENABLED(SHOW_ERRORS)) printf(SPL_TPL_PROMPT "failed to boot from all boot devices (err=%d)\n", ret); else