From patchwork Tue Jul 25 14:06:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tanmay Shah X-Patchwork-Id: 1812711 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=wxRD9hj4; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4R9Lqc19Lwz1yYc for ; Wed, 26 Jul 2023 01:41:48 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E22AF8679B; Tue, 25 Jul 2023 17:40:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="wxRD9hj4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EF92386679; Tue, 25 Jul 2023 16:08:12 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2060d.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe59::60d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 640AB86378 for ; Tue, 25 Jul 2023 16:08:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=tanmay.shah@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EXePg8NUalc7BxvsZzwcDS+xcaH/NWHEUXkVqfCBpZlwlY/QJIfLcAuQSCZ8ftgZzp+i5qzvuPELUVlRK9a4kpoaEawIii3rwofdFFi1dT3QgIoADa9w6blVXfMuq05/6aTW1kLWpfnmN8YDWt8E2lbFlDOCqHiCZqCTC4nmPox3KmZ78L4nwvWrqORLOTiMl5oxclSvKvhyZmNG1sbZEA4+PZm6dPHo2Svy1LUzx95Etggcck3AAXMO7w4zppv4E49q5KiPqXNF46hUVqRAb+OloUOPwFXfYIqpJlfAuQ+/j149PJCpopab5Qh3McMMrRlUijHYVvqv9Q7xPsxrsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j+UsPYeLhBPyyjSsxi04syhVHJ1kPOILa2Oz7+6nS0M=; b=TZjBxvTYOlC1MKTAyhB1NUx8ZjPGRQhGhZVzQ3qoD9P8ndy7raBSZMm8q0av5GiAyzTju/wRwAM68UiaV7E2OzA3P/+06+T+QbFWgLYJ3TMqrQFpqQEW+pC0GbddorxpM2bpZ8UHPKvP5xw7WWuSoxLSL3FWQl4p/ffOi5mQcQniWPitvIH8TDwoKZ3cIgJqYM7bMc1WEQL/TAGAcihRQ3QsGwACbROLh4HVXYgfjGTr/NaEObT0uMfXAKP5d8pmG1mgbvZzdLB7utJ7vwt+tT9mYx/fjBwcgqCFwK9/HGneuhGVQdY4PqC9csgeEa/KR6BfU6qterBbWX3dyNdy/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=chromium.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j+UsPYeLhBPyyjSsxi04syhVHJ1kPOILa2Oz7+6nS0M=; b=wxRD9hj4rZ1ckMeA0vEJTeTFdsl1DoIr7KpiIMs14SIlap9mSEeX38f5vGdE3shaAbM1YUkep4z3EiImekBoXi2ElGqh5vJCBunMwxrNmDJ61TMurwXSljCqeR7zvQdVJ/YnMj1z4EAc0s4dr+jb9SbtRUA/6uo0i0KUrorXZtE= Received: from SJ0PR13CA0012.namprd13.prod.outlook.com (2603:10b6:a03:2c0::17) by MN0PR12MB6128.namprd12.prod.outlook.com (2603:10b6:208:3c4::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Tue, 25 Jul 2023 14:08:03 +0000 Received: from DM6NAM11FT014.eop-nam11.prod.protection.outlook.com (2603:10b6:a03:2c0:cafe::35) by SJ0PR13CA0012.outlook.office365.com (2603:10b6:a03:2c0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.25 via Frontend Transport; Tue, 25 Jul 2023 14:08:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT014.mail.protection.outlook.com (10.13.173.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6631.25 via Frontend Transport; Tue, 25 Jul 2023 14:08:02 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 25 Jul 2023 09:08:01 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 25 Jul 2023 09:07:50 -0500 Received: from xsjtanmays50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Tue, 25 Jul 2023 09:07:49 -0500 From: Tanmay Shah To: Simon Glass , Tom Rini CC: , , , Michal Simek , Venkatesh Abbarapu , Mathieu Poirier , Nishanth Menon , Tanmay Shah Subject: [RFC PATCH 02/10] firmware: zynqmp: move zynqmp_pm_request_node API Date: Tue, 25 Jul 2023 07:06:42 -0700 Message-ID: <20230725140650.951581-3-tanmay.shah@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230725140650.951581-1-tanmay.shah@amd.com> References: <20230725140650.951581-1-tanmay.shah@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT014:EE_|MN0PR12MB6128:EE_ X-MS-Office365-Filtering-Correlation-Id: 0f0e4dea-cd1e-41ef-2de7-08db8d188f42 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dzL88GHE7bM2uT7sSdBnm151Icz9QP4jhvA8Jc7YIbH3NvkU8oEYYewgfyHOZn6xKYQqK/ShRrNtA45oM8U4hIfTjL377zWC7QlrsAHk71IXiH1l/PxY/zYGhoKf0lvRcO3tAymoxbxcna7OpSRPkvbTv2djxPg4+QIvwZXsZwp4u5eRHOolVwmIQXAl+o4Udac9+qoOtFSjnVOlMVofUHUrz14boY8MAetgGFPwLdG/Fr/Od4SVJPkLDoU2P6N/WE8k6+3G3Q2lO03HPiUi+xHPX2Hp7CeYXGY3JANvpuDGzUldQdkqrwP0kjpLjFySECcugtXFFRWS/brL+y3p4tmmWA6+vnZFqq6DomiPFRV8613AwZ5kB2otR2NcLV89R9MMsImPKebCcvDmwXkphrlcKAhK3LnAUCznZpL7ka9768EtI4VQq/VacI1iRzJvK6RjO/j40FXQFL5CXEC860acBACqQRADUMojA+f0BY/SVRjKQbGj29RJfxRNZqIMZRUFhD0TwqnhpctuSi55TOwUX4UuHrlScMSySX8xVcrN/7EzlOEmhAlX5pBUeEZqaB/tG2v1QZ5K8+RXStIi15AfmIj9sMLz47/lSkNSyTTKokWrX400qBU4/Qi4A+Qp73lnyx7OeepxZrKzWSDtCTMPT6oUYPDLPzyEM0fnHzjdkKH++4tHfMObyTCG9PlBXihn9vAQdsBQDRRPUL/j9+nR+J8anr/QpnbAOjG6pAgk90mlOJPwtcad7g3r6RDnZC5EUoi2gNa9iRGBVjqvqQ== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB03.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230028)(4636009)(396003)(376002)(346002)(39860400002)(136003)(82310400008)(451199021)(46966006)(40470700004)(36840700001)(54906003)(2906002)(70206006)(70586007)(426003)(2616005)(47076005)(36756003)(83380400001)(36860700001)(82740400003)(40480700001)(86362001)(81166007)(356005)(478600001)(110136005)(336012)(6666004)(26005)(186003)(1076003)(40460700003)(41300700001)(5660300002)(316002)(4326008)(44832011)(8676002)(8936002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2023 14:08:02.4486 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0f0e4dea-cd1e-41ef-2de7-08db8d188f42 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT014.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6128 X-Mailman-Approved-At: Tue, 25 Jul 2023 17:40:30 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Requesting node to firmware can be used by multiple drivers. Move this API to firmware driver from power driver so others can use the same interface. Signed-off-by: Tanmay Shah --- drivers/firmware/firmware-zynqmp.c | 7 +++++++ drivers/power/domain/zynqmp-power-domain.c | 7 ------- include/zynqmp_firmware.h | 14 ++++++++------ 3 files changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/firmware/firmware-zynqmp.c b/drivers/firmware/firmware-zynqmp.c index ab4c4f1a69..0897992405 100644 --- a/drivers/firmware/firmware-zynqmp.c +++ b/drivers/firmware/firmware-zynqmp.c @@ -195,6 +195,13 @@ int zynqmp_pm_set_sd_config(u32 node, enum pm_sd_config_type config, u32 value) return ret; } +int zynqmp_pm_request_node(const u32 node, const u32 capabilities, + const u32 qos, const enum zynqmp_pm_request_ack ack) +{ + return xilinx_pm_request(PM_REQUEST_NODE, node, capabilities, + qos, ack, NULL); +} + int zynqmp_pm_is_function_supported(const u32 api_id, const u32 id) { int ret; diff --git a/drivers/power/domain/zynqmp-power-domain.c b/drivers/power/domain/zynqmp-power-domain.c index 5ee9e020fb..d385dc5530 100644 --- a/drivers/power/domain/zynqmp-power-domain.c +++ b/drivers/power/domain/zynqmp-power-domain.c @@ -14,13 +14,6 @@ #include -static int zynqmp_pm_request_node(const u32 node, const u32 capabilities, - const u32 qos, const enum zynqmp_pm_request_ack ack) -{ - return xilinx_pm_request(PM_REQUEST_NODE, node, capabilities, - qos, ack, NULL); -} - static int zynqmp_power_domain_request(struct power_domain *power_domain) { int ret = 0; diff --git a/include/zynqmp_firmware.h b/include/zynqmp_firmware.h index 18a87d2749..ce086f48d4 100644 --- a/include/zynqmp_firmware.h +++ b/include/zynqmp_firmware.h @@ -444,12 +444,20 @@ enum pm_gem_config_type { */ #define PAYLOAD_ARG_CNT 5U +enum zynqmp_pm_request_ack { + ZYNQMP_PM_REQUEST_ACK_NO = 1, + ZYNQMP_PM_REQUEST_ACK_BLOCKING = 2, + ZYNQMP_PM_REQUEST_ACK_NON_BLOCKING = 3, +}; + unsigned int zynqmp_firmware_version(void); int zynqmp_pmufw_node(u32 id); int zynqmp_pmufw_config_close(void); int zynqmp_pmufw_load_config_object(const void *cfg_obj, size_t size); int xilinx_pm_request(u32 api_id, u32 arg0, u32 arg1, u32 arg2, u32 arg3, u32 *ret_payload); +int zynqmp_pm_request_node(const u32 node, const u32 capabilities, + const u32 qos, enum zynqmp_pm_request_ack ack); int zynqmp_pm_set_sd_config(u32 node, enum pm_sd_config_type config, u32 value); int zynqmp_pm_set_gem_config(u32 node, enum pm_gem_config_type config, u32 value); @@ -474,12 +482,6 @@ int zynqmp_mmio_write(const u32 address, const u32 mask, const u32 value); #define PM_CONFIG_IPI_PSU_CORTEXR5_0_MASK 0x00000100 #define PM_CONFIG_IPI_PSU_CORTEXR5_1_MASK 0x00000200 -enum zynqmp_pm_request_ack { - ZYNQMP_PM_REQUEST_ACK_NO = 1, - ZYNQMP_PM_REQUEST_ACK_BLOCKING = 2, - ZYNQMP_PM_REQUEST_ACK_NON_BLOCKING = 3, -}; - /* Node capabilities */ #define ZYNQMP_PM_CAPABILITY_ACCESS 0x1U #define ZYNQMP_PM_CAPABILITY_CONTEXT 0x2U