diff mbox series

[v3,3/3] fixup! net: ti: am65-cpsw-nuss: Enforce pinctrl state on the MDIO child node

Message ID 20230724-ti-mdio-pinmux-v3-3-fc8359b0014b@kernel.org
State Superseded
Delegated to: Ramon Fried
Headers show
Series net: ti: am65-cpsw-nuss: Fix DT binding handling of pinctrl | expand

Commit Message

Maxime Ripard July 24, 2023, 1:52 p.m. UTC 
---
 drivers/net/ti/am65-cpsw-nuss.c | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)
diff mbox series

Patch

diff --git a/drivers/net/ti/am65-cpsw-nuss.c b/drivers/net/ti/am65-cpsw-nuss.c
index 29a4284a9b70..51a8167d14a9 100644
--- a/drivers/net/ti/am65-cpsw-nuss.c
+++ b/drivers/net/ti/am65-cpsw-nuss.c
@@ -627,21 +627,14 @@  static int am65_cpsw_mdio_setup(struct udevice *dev)
 
 	mdio = am65_cpsw_find_mdio(dev_ofnode(cpsw_common->dev));
 	if (!ofnode_valid(mdio))
-		return -ENODEV;
+		return 0;
 
 	/*
 	 * The MDIO controller is represented in the DT binding by a
 	 * subnode of the MAC controller.
 	 *
-	 * Our driver largely ignores that and supports MDIO by
-	 * hardcoding the register offsets.
-	 *
-	 * However, some resources (clocks, pinctrl) might be tied to
-	 * the MDIO node, and thus ignored.
-	 *
-	 * Clocks are not a concern at the moment since it's shared
-	 * between the MAC and MDIO, so the driver handles both at the
-	 * same time.
+	 * We don't have a DM driver for the MDIO device yet, and thus any
+	 * pinctrl setting on its node will be ignored.
 	 *
 	 * However, we do need to make sure the pins states tied to the
 	 * MDIO node are configured properly. Fortunately, the core DM