From patchwork Fri Jun 16 08:28:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Herbrechtsmeier X-Patchwork-Id: 1795742 X-Patchwork-Delegate: xypron.glpk@gmx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=weidmueller.onmicrosoft.com header.i=@weidmueller.onmicrosoft.com header.a=rsa-sha256 header.s=selector1-weidmueller-onmicrosoft-com header.b=UxQImuZ1; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QjC3y1yKlz20X8 for ; Fri, 16 Jun 2023 18:28:44 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 67D878474E; Fri, 16 Jun 2023 10:28:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=weidmueller.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=weidmueller.onmicrosoft.com header.i=@weidmueller.onmicrosoft.com header.b="UxQImuZ1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8407384706; Fri, 16 Jun 2023 10:28:33 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FORGED_SPF_HELO,SPF_HELO_PASS,T_SCC_BODY_TEXT_LINE, T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2062c.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe13::62c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 593A084706 for ; Fri, 16 Jun 2023 10:28:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=weidmueller.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=stefan.herbrechtsmeier-oss@weidmueller.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cfTtqp2Hg7FYWbyCxaYVeVtVSEImPa9lqmxMqALULyhzxaeozlXXW/VXeLUmnugsXUBXt5hIn7dogLghmAaxtacL1Q9T9eD5x8jsaab7DjjGFHRE2d3yK6UO9GA4wroXcqO1Hf2nx6NZikCB6/2XGBFLpWQBSgB7EfJYC6aToyHqluIk+670/X55On92+iRBv1mr8NKjWe8d3nQM6JnP2WRO/+upydzDjE+Q4JkM9O+x6EGXQ62Xi0c0VV9Aul5BTsdVkvjMDAwX2hxssqgPX4sJ+dZw5E8pH68QrUA0ZTFVasY1xVYpdNLreenXMNhbNkK2AT7048UtigBhN4UH8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sZ6NL6T/y6S47U44ch8ckhfi5o/ivYhQ5lJo7vdJg6I=; b=THRKfS1hzqnFej0Lp1EYofXJtEyf0MmxHadwVTOTgy+WTkF17QlsD7lnnG8xiOLK4j1Db09V/RF1dE9pMUR1002F4lzVJ19TmEDVHrA24wkIyi5f/M1LdGDm15XRfR4F0WCGPYfLTJ3HgZKHUDYm3S+4GL7bfckSL9kDTV9LWkGLQbhu4/losomdph4GPwOGtuTP+Bbvy792YyboGANzEkeIVwWzV6NrByQ6cYucF/9x60Hr1gAa2ius7dSXj4xh4qXRtgUuCSb61jM428TdItbuSbTy+yV27+gOhG83v1vyavrBd0vYmB8zoKWTSniSQCnWc/WjmiEhxp45TAa6PA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.onmicrosoft.com; s=selector1-weidmueller-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sZ6NL6T/y6S47U44ch8ckhfi5o/ivYhQ5lJo7vdJg6I=; b=UxQImuZ1nOr7yCFfB8oeNj2PBz2DoqPFrcYshFA9CfvjZPKQrBJhV9jQc9ZJd7Z0/w51Gsno8TbgXrfNpBY0Yss809XI1iTlPOkPVdY05hncnU5cJl1q2/F14foqGdSIxrkNYrz3+NIsmbtpaB9xZ5IuypVkqHUwxdENGYLoZzo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from PAXPR08MB6969.eurprd08.prod.outlook.com (2603:10a6:102:1d8::23) by AS8PR08MB7792.eurprd08.prod.outlook.com (2603:10a6:20b:52c::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Fri, 16 Jun 2023 08:28:28 +0000 Received: from PAXPR08MB6969.eurprd08.prod.outlook.com ([fe80::7501:6f07:8ffe:f389]) by PAXPR08MB6969.eurprd08.prod.outlook.com ([fe80::7501:6f07:8ffe:f389%4]) with mapi id 15.20.6500.025; Fri, 16 Jun 2023 08:28:28 +0000 From: Stefan Herbrechtsmeier To: u-boot@lists.denx.de Cc: Malte Schmidt , Malte Schmidt , Stefan Herbrechtsmeier , Etienne Carriere , Ilias Apalodimas , Masahisa Kojima , Sughosh Ganu Subject: [PATCH v1] mkeficapsule: fix efi_firmware_management_capsule_header data type Date: Fri, 16 Jun 2023 10:28:05 +0200 Message-Id: <20230616082805.4652-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-Mailer: git-send-email 2.30.2 X-ClientProxiedBy: FR0P281CA0121.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::19) To PAXPR08MB6969.eurprd08.prod.outlook.com (2603:10a6:102:1d8::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR08MB6969:EE_|AS8PR08MB7792:EE_ X-MS-Office365-Filtering-Correlation-Id: 09f31ed8-f4ce-4a65-cc0f-08db6e43a8e6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RExtuMgYprQC5OKVv8+Ma9B85wnNcTkLfqCr8EItjpjwOHdqm00G6PlwH86NV65qIDoCSwS3B8hQ9dh6lNPhfW2kva88Y/s+HigLHEOlqaz0H5hKux2DS95RmJwTQz3KBcALW9tR68RIbq1CsKtyr9XW+ybk0zbx7Zr8vsaGfNuMniEpZUWsSW619dpgMH635Rf25aa051M9J44GgL9TwV+1XtCH+Ppuxonm62raYEOTRB4uCSLKaUHHuGn/Cz8qzfHy4wBfFEKu3rbxIn/UaBj9AEoXjQMd/wO3DPY0eskbvVIyDkR3l7LG7PBE4Ff1uJU130ESUzoZC/K1IV+DND2rr+SU8AAMrcly+WrLVoHxm839UGDHPR2j3NG5DuPhgWUEOrOo0Mt5akbVa7szNAvjNhxhXlGAavPR57dgO36bgC4UG+toJ/6aIVL4XrvWMCh+kRUYajb4Y3jiugSxPoGeytdD0R/uhJDpjkooQtpB+bSfDcrwcaUTjMX6zLDs5Jv84+rw767mrP3TwQkTYenRQWUw+BIr6Ah6bBdHdD3A2tYZT3oa5N3w3fI+xCTzwUaUW9nwvilKDHhY4DfOxqT4oyVzRHBiua2nv2WIfSI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR08MB6969.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(39860400002)(346002)(376002)(366004)(396003)(451199021)(66946007)(66476007)(8676002)(6916009)(316002)(8936002)(478600001)(5660300002)(41300700001)(66556008)(4326008)(6666004)(2906002)(4744005)(6486002)(52116002)(966005)(186003)(1076003)(26005)(6506007)(6512007)(83380400001)(2616005)(54906003)(86362001)(38100700002)(38350700002)(36756003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Qrdp5ycsyyd2SSSPjIrDkV9nnbodqz9ARB/mb+x/DmcAnzO5gb8BSxZaaDlEO6ftNUCj7nsHu2BR2CTsZnqIdnKz81UmsmG4/Quo0QF0r/ibeSfQhWFnYYO+1SnB4aaxBA9kvdlA7G4qFh3XXZ31UsADR92nOb+bBwj6pDYzuxrKz8t2VGYNwuLShQKMCe0zATb+MtnzJksm5tNwL6KiM7GDaIYuASCxrmdfBFTSC7muCcOkJmxEpEHsQ5yBg3tjP42PMvK6LE+1a9zzGNnosovpNgtDdMk3HwlFDizww2q2j8ddr3Ti0tkvmk2V4AgtaWVwm/+zf7+w9fZhrTVQ8YHHgzkMh3lNANBbVVWky6eYEuw6ZrWBEzdVC8JXNB68oGwyJUBAkguwIHxKB5+fRi068ro1vFYCpN0DI7hYtlnDoFjsVVqm5G0MVcNBxCz0oUjFHKB5fHR7Ojuf1qgMzDEC/YaGAVtuliUFs1jjQzRi5yeTBE9YGOLuoj47xQ2W91eQukv58v0MKDBhff4DbC+w0/Yv0yb8D93POb2Cd0Um0TiBDAN87VKoyTpyf5RWZ0M3Opu8nPoY1UhD+TvwD1lgMsaBcJVIF2cF1UvTlInLHJqrX7SaNcUH55O1uWOcKMDjC5MNfSLu3typNOGifzOu4kBBjgbUC/iH0Lco8NZAAtxUqbzXXhNCbHVJCHu+6ld1LJ7lohmxq8pg68wxi0eXiM4E1C4Lq5BrS02gCXYLgzshRsUXrlMmxBXBMRc6uGa18ES1/cBMVOga+qBFFpSYsLnWOEp0uO2BxG4hfprIqAJCiICHuwgKwsiG4QesMH2aGO/sruvxkgxSjoqSItmd3iULUUTHUJ/SetB9+2FkHJpJiAAfrQrhNGP+C3R4Ml5d7MgPpjFEFDfXX8ofKDkdegx0P1hwwPAJsLN8ddgxzeqyNn12I0rM1jyt+TU9XydbAT6e5AakVn4T3YdIbNh7cQGlEtInMi+7+rYiSaVjJahM8HxxENXTWTfS/TbRf4Z0cgDO9sGpjbTfT1NnpL1Gx121BFm7vtEqL7tj1/HmVd0pcbtAFvF7FevSnTZja8U50PzpzD9izOSRLc7tqZ6GKnlh/7XL5ZrMBjk1kWwb9IJiMoHkX9znS9pKI5z+C+gGWhldL4PSWdJTgrD7ZtbCkayFpe01kezXcBWQfMPd5dKWiP2NP20QoLcBaBo1ewLcQjfjdHHCxIRwZuESxbPv2kB6GXGTTap9rptFhDzorvylrTejL+RZfJvfYmv80UIilWjH+hjLuYNPckmG5myzqD/gxuiB4/Mu5JrtxJ4n0k/NZr/7z06UEOW7kCmgscWc1TVixExNF/+Q8pJGLEMzJYQ/4Vyd94/KGA+Za9cSGg2YSHLG9GZsuWkmr/Vzbu1LTcSuGq5pbX3BJ9M5HqiXNA4VQS+dZSBmarUNYNUNsqDgecdWwSnrSpPzg1E0utlhYQXgi7WgCOOZrbB6o1rTBImnutAN4XxOsYrC92Kw5IyO+ULyhnRlsdrTA4r65pmvRucTWR8QLSL/MDUqHKxNWhfWhL7BUVBvxplCSeHXUUCGQgDrExw012D1SPaoNiMNf8Pw4Old2r22RfYaIQ== X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09f31ed8-f4ce-4a65-cc0f-08db6e43a8e6 X-MS-Exchange-CrossTenant-AuthSource: PAXPR08MB6969.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 08:28:28.0829 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3Wc/CtwshJUSDVG+z33xEEHbgC5TTZX4pXl+pfwGuA5cTMsTvRjhqmO7Ogmgq/2IJN6AGIndN1glTUdngAz2wQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7792 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean From: Malte Schmidt The data type of item_offset_list shall be UINT64 according to the UEFI [1] specifications. In include/efi_api.h the correct data type is used. The bug was probably never noticed because of little endianness. [1] https://uefi.org/specs/UEFI/2.10/index.html Signed-off-by: Malte Schmidt Signed-off-by: Stefan Herbrechtsmeier Reviewed-by: Heinrich Schuchardt --- tools/eficapsule.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/eficapsule.h b/tools/eficapsule.h index 753fb73313..2099a2e9b8 100644 --- a/tools/eficapsule.h +++ b/tools/eficapsule.h @@ -63,7 +63,7 @@ struct efi_firmware_management_capsule_header { uint32_t version; uint16_t embedded_driver_count; uint16_t payload_item_count; - uint32_t item_offset_list[]; + uint64_t item_offset_list[]; } __packed; /* image_capsule_support */