From patchwork Wed Jun 14 09:03:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ashok Reddy Soma X-Patchwork-Id: 1794868 X-Patchwork-Delegate: monstr@monstr.eu Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=iP/t8wzW; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Qh00P5LFxz20QH for ; Wed, 14 Jun 2023 19:06:29 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3315C86181; Wed, 14 Jun 2023 11:05:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="iP/t8wzW"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 87D068609B; Wed, 14 Jun 2023 11:04:51 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20606.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe59::606]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EFEBA85FF0 for ; Wed, 14 Jun 2023 11:04:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=ashok.reddy.soma@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HpMTUmjfiUxw7jj5wy4XEM4+KuCYHFju29ASSTCXOQ9lNvmsGqDxYj9SlKeAYMwkbk7aFWp7dHtEaXgTKRxfuXLZfzvnpY0p3j5nJFqJmNtbey54yXM4f7tEFHocCT6Kj+7aobx0uijFexef18IGvbCbaFDlY3TNWuVQ/yYDwU+p1hYdy2tYBh+nboRnj/AF2uwfBx/8kYzWQvU5F5f56Uo0j7oxotkiGM0tlnLNhexVL6tTXKPZRWQJVA2dZIxALiZPndKuoKgGpJfpiJshNdDOr4Rt8j2Jjtz1v0TcXkzufHX7hjzFd9ZWLkFML6FhLQC+8e2tHIunihT7VDDbqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vc8RnV6ySF1ajo7lMgPmRGcmLwchmbuTVIJA6R6Zzz8=; b=WMhU3FlllHHWfvP5ZyDLAe5QC9tkD3m+5CF9U3xOEspWeH904GObrRrS+Vnjtu8QR63M8LZUUCee00/81fLPNYDIyszpP4jVgzRkmPpubgVMgxXQbgF7MsCxs6OYA304zvq4SqbuVmNY69WQq0I8GVarqaU+om2QdaN8PZoc9T0Mr+e1Uy3S3GyeUcq5Tq1ra2QcDo3ufXj6b8eYkqJ0P4Rds9bUpxuV1W0dx9n4yFt893QVo5YyjZWXX7FOOsMYwoNpKShhuTDEGz/Cd9VW8GFwf7wFwdsqqg7b9rAz+ERojtdfJwuFVw1nsUQf4avvc5+r/Pn+HI1zmdhd88lWAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.denx.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vc8RnV6ySF1ajo7lMgPmRGcmLwchmbuTVIJA6R6Zzz8=; b=iP/t8wzWjPdStJ0lnbihrRv4ZfDdNb+5L9/dh8d2qHMlPZSlRUUwNSBGfrp28n5AwQVXfSSSpB8SqykiuA1UTaUQE29o+el8mB2F2AaxvXy7PPmfXNqG67qpMay1QR/q/TCdoo3RpiLnaBQf24d4t0fIdab+s9oqOTq57bTYw+Y= Received: from DM6PR06CA0081.namprd06.prod.outlook.com (2603:10b6:5:336::14) by SN7PR12MB7786.namprd12.prod.outlook.com (2603:10b6:806:349::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.38; Wed, 14 Jun 2023 09:04:31 +0000 Received: from DM6NAM11FT009.eop-nam11.prod.protection.outlook.com (2603:10b6:5:336:cafe::c1) by DM6PR06CA0081.outlook.office365.com (2603:10b6:5:336::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.35 via Frontend Transport; Wed, 14 Jun 2023 09:04:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT009.mail.protection.outlook.com (10.13.173.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6500.23 via Frontend Transport; Wed, 14 Jun 2023 09:04:30 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 14 Jun 2023 04:04:30 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 14 Jun 2023 04:04:29 -0500 Received: from xhdashokred41.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 14 Jun 2023 04:04:26 -0500 From: Ashok Reddy Soma To: CC: , , , , , Algapally Santosh Sagar , Ashok Reddy Soma Subject: [PATCH v2 4/6] mtd: nand: zynq_nand: Change datatype of status and ecc_status to int Date: Wed, 14 Jun 2023 03:03:57 -0600 Message-ID: <20230614090359.10809-5-ashok.reddy.soma@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230614090359.10809-1-ashok.reddy.soma@amd.com> References: <20230614090359.10809-1-ashok.reddy.soma@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT009:EE_|SN7PR12MB7786:EE_ X-MS-Office365-Filtering-Correlation-Id: a22b3048-551f-4eb2-70bf-08db6cb65d1b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5yx8/A/WqLy4XBR0mPXSNUR8uJxrOsx9IBNMJInrs7jytTEVxEF/bmXzYZtA6lAvE2u90c33dAGD7TcUIW3s4oYKiTWp0PjWNiKbVdLcBDBcNFw5TSBRMP+47av5qJTW034MnLnR+nX/vtKvL7gH9OKUntAGehTu2Vi7OqVR9knrk+eUvokaVQllDGoJ0ojAxU77SSpvWnvSO8b8UXb6iBjlTdSIWbDFF0ml9eLTOQqtiVka2lpqZgNrKgN3BH9tW+9Ilk/VR3PJdNvuRycA7eVYAtVVJux03VJocxbmrO2iuzoQt6tC987igrBQ7ZozjyDchA4FoOEKD0cvuQ2got1BhPXZSTMHr0LOW6vXJqaf2mjAolxPxz8kXtljBkS7JFvvoeFBzWgvRNV2YL4ovbJYhhA69jQYzl6JFlsiNPrbp5AqPRmkMsEZ1NOl7RSH5XEHvY9Ag4tDnThF+M7knmKpQXy8cgUWBPaLFfgJ5VeGp0G8hGLX5gDRLhCx2nRdsVJkrf+WQkl8aWCbcCEilrYztinEa4ge6kSo6mtPzln77Lr89k+IFP1PMp5eg9ra3GXMYwKATM8tIm7SWXqPG8BvrVENMPvotk16nHh37RBP7ln2H7GRLGDLKCjVZXh1rRApu3t2Ik7aoFDekW+7sfQCQaWY0+ym7RsihKlOnNjnk1rTQxC1VtPdj4SF8SaykqO5bP+fIutaDyxr+3H0Y7AMUw0/loVXE2alOf2qY9f+g7csIpJUchrYduoszw+4WvfMLvx6gLsl85auHxgk/A== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB03.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230028)(4636009)(136003)(376002)(396003)(346002)(39860400002)(451199021)(36840700001)(46966006)(40470700004)(2906002)(5660300002)(478600001)(41300700001)(54906003)(70206006)(6916009)(8676002)(70586007)(4326008)(8936002)(316002)(6666004)(2616005)(1076003)(40460700003)(26005)(186003)(356005)(82740400003)(40480700001)(36756003)(83380400001)(36860700001)(47076005)(81166007)(82310400005)(426003)(336012)(103116003)(86362001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 09:04:30.4203 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a22b3048-551f-4eb2-70bf-08db6cb65d1b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT009.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7786 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean From: Algapally Santosh Sagar status and ecc_status are of unsigned type where they are compared for negative value. This is pointed by below sparse warning. Change datatype to int to fix this. warning: comparison of unsigned expression in '< 0' is always false [-Wtype-limits] Signed-off-by: Algapally Santosh Sagar Reviewed-by: Michael Trimarchi Signed-off-by: Ashok Reddy Soma --- (no changes since v1) drivers/mtd/nand/raw/zynq_nand.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/raw/zynq_nand.c b/drivers/mtd/nand/raw/zynq_nand.c index 9e3ee7412d..545fdd7b69 100644 --- a/drivers/mtd/nand/raw/zynq_nand.c +++ b/drivers/mtd/nand/raw/zynq_nand.c @@ -285,7 +285,7 @@ static int zynq_nand_init_nand_flash(struct mtd_info *mtd, int option) { struct nand_chip *nand_chip = mtd_to_nand(mtd); struct nand_drv *smc = nand_get_controller_data(nand_chip); - u32 status; + int status; /* disable interrupts */ writel(ZYNQ_NAND_CLR_CONFIG, &smc->reg->cfr); @@ -332,7 +332,7 @@ static int zynq_nand_calculate_hwecc(struct mtd_info *mtd, const u8 *data, struct nand_drv *smc = nand_get_controller_data(nand_chip); u32 ecc_value = 0; u8 ecc_reg, ecc_byte; - u32 ecc_status; + int ecc_status; /* Wait till the ECC operation is complete */ ecc_status = zynq_nand_waitfor_ecc_completion(mtd);