From patchwork Fri Jun 2 21:49:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Edwards X-Patchwork-Id: 1789836 X-Patchwork-Delegate: marek.vasut@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=o9jLJclp; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QXxX26JtBz20Tk for ; Sat, 3 Jun 2023 07:50:58 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2A994862FA; Fri, 2 Jun 2023 23:50:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="o9jLJclp"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 00001865C1; Fri, 2 Jun 2023 23:50:38 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7417F863D7 for ; Fri, 2 Jun 2023 23:50:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=cfsworks@gmail.com Received: by mail-il1-x12b.google.com with SMTP id e9e14a558f8ab-33b921e4e8fso9600255ab.3 for ; Fri, 02 Jun 2023 14:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685742634; x=1688334634; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YaVpu67HDqjJmZD/H4F1/fpD9t2Q4BlqI3Jw1vxiAn8=; b=o9jLJclpV7BlW5FHY8X/OX1rRPCfMFrxD5xvDEfeM2Tehs3ZUfy1fvJbBS1SahfY5c ecPccS1ppVaJsHftOJaXO+rPWlIZEw9DiKngtQPHM7YGiXrjyzlDk/iPLgMAPY84ENpW gd5BRn9hmcem1MyGmahN4+HZDSRe3T7dXDtMch4Lv6cIxNjohOn6MoE+jAwu/ph1g3nb HwrKZXsMH6/VbJRo91RSeeOBBsc5SWiz1GZynvPrKu8nGXOYfNj5mEcAwhlnMjIOCOU+ PjGnOk1IPwJECpxZO6dmV5kG0AUgb0yQ5NCBO5+m1ULXkWV9e9a1TjkS0WpFtBtLg297 xELg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685742634; x=1688334634; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YaVpu67HDqjJmZD/H4F1/fpD9t2Q4BlqI3Jw1vxiAn8=; b=f9rLHyoTDoWcFwz5MGEguGI41S2c8pySRqCt1ziMxHCKZ4Np62u42W/qRtBuZPGJ8z mvC+45DgVQrtL9ffOtyDdy8AXqoHpVekG+NTN/xBUgClqVIa2+1hXkjRn6gSFX366wNC 6qwkFCFlP3bSA2t+ywdL2t6RPEEREnIpEMT8jVdVaLOCmCjBZ5GHe1l1eOCNeO4lFCCE S+nfqVGxf+174s+WpHIW7L/UmkN8knxintOXiXlyNCyWR+zhKxULpmCIs1KOSrvebgff E9ouFnBEvIFwCkRYEMSRsn1CEqrEP+rbTpAJONrfYSeA1lAej+WyHvwh8IAOlLWX4Pz/ qG/A== X-Gm-Message-State: AC+VfDwQsqHNLawKJIZatZ3DLkP1pHY7mJPmnQTf18u0y9kX0E5h25HX Mt5lJT8i1tOQf6wQOX4ccki6QV272ky8yKNg X-Google-Smtp-Source: ACHHUZ5RR6xH6G33D3JlVqtuHo8Y8HcrzOycmbX25HefztAfYYrGV9epkCKIepIlFwfQiqOnlEJEKA== X-Received: by 2002:a92:cc43:0:b0:33b:820:41ad with SMTP id t3-20020a92cc43000000b0033b082041admr7260902ilq.9.1685742633911; Fri, 02 Jun 2023 14:50:33 -0700 (PDT) Received: from celestia.nettie.lan ([2001:470:42c4:101:7b1d:313:b371:dfda]) by smtp.gmail.com with ESMTPSA id r4-20020a02c6c4000000b004164fe77c06sm566672jan.26.2023.06.02.14.50.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jun 2023 14:50:33 -0700 (PDT) From: Sam Edwards X-Google-Original-From: Sam Edwards To: u-boot@lists.denx.de Cc: Andre Przywara , Jagan Teki , Marek Vasut , Maksim Kiselev , Sam Edwards Subject: [PATCH 2/3] usb: musb-new: sunxi: fix error check Date: Fri, 2 Jun 2023 15:49:57 -0600 Message-Id: <20230602214958.167909-3-CFSworks@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230602214958.167909-1-CFSworks@gmail.com> References: <20230602214958.167909-1-CFSworks@gmail.com> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean The `musb_register` function returns some ERR_PTR(...) on failure, not NULL, so update the check here appropriately. Signed-off-by: Sam Edwards Reviewed-by: Marek Vasut --- drivers/usb/musb-new/sunxi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb-new/sunxi.c b/drivers/usb/musb-new/sunxi.c index 6e60dd47e0..65a528e229 100644 --- a/drivers/usb/musb-new/sunxi.c +++ b/drivers/usb/musb-new/sunxi.c @@ -488,7 +488,7 @@ static int musb_usb_probe(struct udevice *dev) #else pdata.mode = MUSB_PERIPHERAL; host->host = musb_register(&pdata, &glue->dev, base); - if (!host->host) + if (IS_ERR_OR_NULL(host->host)) return -EIO; printf("Allwinner mUSB OTG (Peripheral)\n");