From patchwork Tue May 16 14:05:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Herbrechtsmeier X-Patchwork-Id: 1782079 X-Patchwork-Delegate: monstr@monstr.eu Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=weidmueller.onmicrosoft.com header.i=@weidmueller.onmicrosoft.com header.a=rsa-sha256 header.s=selector1-weidmueller-onmicrosoft-com header.b=lnRXq7Pg; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QLJ1G5VCtz20dg for ; Wed, 17 May 2023 00:05:54 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BDF6E86114; Tue, 16 May 2023 16:05:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=weidmueller.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=weidmueller.onmicrosoft.com header.i=@weidmueller.onmicrosoft.com header.b="lnRXq7Pg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 93FF2860ED; Tue, 16 May 2023 16:05:49 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FORGED_SPF_HELO,SPF_HELO_PASS,T_SCC_BODY_TEXT_LINE, T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on062f.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0d::62f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1F5E6860ED for ; Tue, 16 May 2023 16:05:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=weidmueller.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=stefan.herbrechtsmeier-oss@weidmueller.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=duMji5cD+ENQTfXfJuMoqeIa29cI8bLNpJfHWDMEHf3lJdKb6lcadCtnLUr6hT1m8KLksO9hzBoMuN4AX9vKcQnZejvlhhhAcOXYrib8KoiMB3mu058QTHLNYppdbrs59r/PwnDqaIURwGowvmfHIuKPGQME2ofXq9EreFqBUYiHOuD5mqsTiXM44Z+KOw7Nituq33n0g2R9PnsaLkEjvSj5+Bp7vtOXgTtULtnQt5mDlVxOk62fIEGyt+yKqZdqbV4/Mapkpx/CamJLJqtz9vFXOEaACPx2SxYR5KgRAkG+GF79UCDd0C6nBaoNwEIHb+5mM48MJx3/3p+imlvOWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zJ94O4N7kGl6s4ntEZ3V5Ovv4DB9AXowTjjRVno7/j4=; b=bDGIv3DY1Q+4+CRxraSyCTUb1t7Io6oAdz+JN9+gBDYRhdmkEF7GV1gq0xgXtakxORphL1FqKBjfSY7fBVhUNUFv4jogqLV93hYNl5bmK6ngr+4oGJgnj3Z5Hp/qwv7mynN0m9F7qlcAhYBvBF71cyeDoStkEqC5pIXOb91nxkUZKD7rqfURdxTT9jY8CQ1wM14GqLieEhkwyfBvBhwlMd1IuTHA3QXDPYgYQFlDvBarZlbaQEi4Rlfh7WUHIwOv6im7/+7tss1oK6caYJ2ZlIF6ZSfVhiklOc5dUg+mym7aPiDRGpbA3+XQ0kHJQYVr/X/wpoboj7wpheqZrPGSgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.onmicrosoft.com; s=selector1-weidmueller-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zJ94O4N7kGl6s4ntEZ3V5Ovv4DB9AXowTjjRVno7/j4=; b=lnRXq7Pg4ZVKrSFoOiiKkb3yCPuA/c6hPE+fPPP/yXQ0V1f/CEal4WUz8DlWcd+oH/sgx7ElLhAmf5nWW/EeAHETPpXTrDmHBTMmew3K9nu7cEy9v8kFnUb4iExQKhQMK3U/dY3F96IYRnrBQMn73q++QCPXeCgR7Fv0VG0LYgg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from PAXPR08MB6969.eurprd08.prod.outlook.com (2603:10a6:102:1d8::23) by GV2PR08MB8365.eurprd08.prod.outlook.com (2603:10a6:150:bd::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.32; Tue, 16 May 2023 14:05:43 +0000 Received: from PAXPR08MB6969.eurprd08.prod.outlook.com ([fe80::5979:132b:6e3:cfb2]) by PAXPR08MB6969.eurprd08.prod.outlook.com ([fe80::5979:132b:6e3:cfb2%6]) with mapi id 15.20.6387.030; Tue, 16 May 2023 14:05:42 +0000 From: Stefan Herbrechtsmeier To: u-boot@lists.denx.de Cc: Stefan Herbrechtsmeier , Ashok Reddy Soma , Jay Buddhabhatti , Michal Simek Subject: [PATCH v3 1/2] firmware: zynqmp: Remove extraordinary return value Date: Tue, 16 May 2023 16:05:30 +0200 Message-Id: <20230516140531.20722-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-Mailer: git-send-email 2.30.2 X-ClientProxiedBy: FR2P281CA0106.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::18) To PAXPR08MB6969.eurprd08.prod.outlook.com (2603:10a6:102:1d8::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR08MB6969:EE_|GV2PR08MB8365:EE_ X-MS-Office365-Filtering-Correlation-Id: 6458676d-b8f4-4e3a-6104-08db5616a2ad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aRWMnlph3x+1QmCj3/k8xs33upV5MwR9VE1U1kvUoKl5sNERuoFEJ4W7zhL96X4qb9J3gekzHaNRSrkX7pLMX59LYDRPAyRIqnop7IWzeo70bvZWDb4s5/PmvnG4NASAU17zQm5s8XKk7SPdSW+qFpinTbzUdSjzuZTilwEWr1VqADh1ZT81AsKDUwE5SCIWWdzpPw4sqthxWcz+WgnIdahL/NtyJKYLp9xqezMJXUmbMH2zhQv1qpFUmkRISL0icHpzks4x5+8a1j4LH9n2096rc0ZntRnx18VFiGdz7PuhvSngYgWJDgBJ+qVwGcN+tuHiW3fdGHnZE0HKZtYFrjt44urn2h4gaHtWuuw+3UNyAccushHle7fm+NEyTcgQN4J7vl6XgbSYCkP7r4mO0wnjqxx11S1zwluOBLtK8Eli0Z+oqHWYLgqkNXV+DVQfwy2VNTioqYLejXO5FsWWFh4fta9YKUNWLq8vqTxPADDpYg8IHEcVAfAbcWtrPdX38RfuDrFdht25/Xo99sSUDZJlxkXfZqZ4oo9qqCNY0fLPA67h71LjtKz0e8xKim3oRj90LFaLeOsnmmhKKy3UDCar/Ai2+xqrFqTv1I/lyproCuZ1HrPO/JO+QvUp0Yyn X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR08MB6969.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(39860400002)(366004)(396003)(346002)(136003)(451199021)(52116002)(6666004)(6486002)(83380400001)(36756003)(186003)(26005)(2616005)(6512007)(38350700002)(86362001)(1076003)(38100700002)(6506007)(8676002)(5660300002)(8936002)(41300700001)(66476007)(66556008)(66946007)(4326008)(6916009)(316002)(2906002)(478600001)(54906003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: h5jEHx4kuqQQrPQXyOGdNpHzflEYf+mtaC19WqsqW1UPQK+LcaFEBWyctAODMX1vxoMSg1o5x0goemx2hGUT1lgKX87/7zu+to9JQuBizue1HTFQXR9DVQCx6eXuzpKSXjFFTYyuCbrGnQouDMob6QCt7CPwaWkzPRt+uNDrG3aR5f5tXJu/YYlGUmbW3Zhrc1sBsSraY+4URKqMCwKX+1itvUSZ+FK9K1S1HSCw1KhxRR/2fpkOMTrw7Vbl9zKsqEftcAIER2IPhhe37trETtSzmSr/uJVaXNfvJs5eNUmeY/F3vUfJqnHfPytCcbSwcjy9CMzPM+dhdrLnU3wc6llHMMWNXmhT3yCzImSshtRAHGP+rkNCWPTYAbF8p9vRFSrzIdsZHoMkoOHtDCu8LYZR61Rsr57bGBmOXJGsX8auxKLZRwfk7TbWzqkxwd+LaJcVYXsWoOOdMX9DrT6hGbntkFZeAzf4gw6J+QYfDGEK6+66QR8Emlv00AHZzX0bG8QEOzoYr2qPjp+D+hyMiATbgM6YZGyHbcXzBgs7Ru0Yrcy15BSjs1bL96qzukl12uvDouJ8DFuetrUWyIRFiz9c7B9dtlo3jM8lUcMd9r42cUg+KPabXvPysIXt/5fP+ucCXbsFmR2x0+p9jTMxyiDcKDBPlwTz0vJX3g64SeEV3hEo4KoCWFWEwICFaH/V77OlStx8IK5SaNXJEBCbFTU65D3HRwGK0JfYScNdAOV+SZMpJprBk7LzmkBT4poVtANTKHGvVYXw9QxyMhG1TmpzyzkWaTlVMWjjVta02kSTEjCf1RP6aa/i4ffdXYaASHPktb43aN6fNCNd1oCvOAzkKVG5VNDpmD7u6mNcLRv8rfYcHId7bNoZSrZyPhfUedE+H7jps/wXg5xTjSKOpeMOAaC0cF++Cy2R/76u/7X9JYcWXK0PbhURL4M59pJCvAAzfaJ3CY6AI0KasQn8YeQWc+ss209qWCMixTOzr8KpEqiBz+/FXEaainEK/N3u39HV9lox1w6LQgiwzdwLL6Noyer1ReGxCqlgt0O313cdugk4Cbwq9jiqH78FmRoqoQpmoPwsMB1XdaoARdX8GCXIUzmswEKnUCNu/PqqtS+Q4mbCHKp+mGt002IFfjb9zoPWFAdPOhJqKUvx+eCMZRAIJAe8l9vuFT+/68xZWo6tmlT4NdGK2dwZWIts0pCgwFj/72jAhPDV9oRMWbXSiz6gSri/P0AYZ4MeZMEDnJnFLN4oelIc1UKr/frhuc7o7A5rzR7mFBHz1vxsqEd3xhkdlLqDO49LS1LR1XBJ7ezAQSmtCfClzoGjGkOZXp+RCA8454+6IjTbdGtJUm3mWtKqO3pG5jBep6Q2kWgxFtTIshksPCeuWw/qhzr94GRGPOC/kiTPKJ72UcGgZIkVDJ5PUNYOGO+a79I7DY6P43aOI2s/dgPOODpbzF0DxWdGAJqylXxAHgjq1U955TiTkDLgkuY0q43qb8YM3jFl1IsGvtDWy1rlDdKaiuAzxanHmx/GgCcKaz+daiEALmd3bNoTJgXGKGo30hUsBL88ttFC1PzKQx7KTzLz8Qsa8g9SbqXzeNZx03xQLPVtBH2zbA== X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6458676d-b8f4-4e3a-6104-08db5616a2ad X-MS-Exchange-CrossTenant-AuthSource: PAXPR08MB6969.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 14:05:42.4344 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tPcgsb4KHJEW7ix/+kOzDCnfbzUgy9kvTiBD3ZH8x33w5dLynq83+jZuQKCZi+JRh/Ob8VS+dP3ayHN4iVN5oA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8365 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean From: Stefan Herbrechtsmeier Return a common -EACCES error value instead of a positive private error value XST_PM_NO_ACCESS (2002) in zynqmp_pmufw_load_config_object function if the config object is not loadable to simplify the error checking. Signed-off-by: Stefan Herbrechtsmeier --- (no changes since v3) Changes in v3: - Rebase Changes in v2: - Use macro for node id drivers/firmware/firmware-zynqmp.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/firmware/firmware-zynqmp.c b/drivers/firmware/firmware-zynqmp.c index dc8e3ad2b9..2b1ad5d2c3 100644 --- a/drivers/firmware/firmware-zynqmp.c +++ b/drivers/firmware/firmware-zynqmp.c @@ -82,7 +82,7 @@ int zynqmp_pmufw_node(u32 id) ret = zynqmp_pmufw_load_config_object(xpm_configobject, sizeof(xpm_configobject)); - if (ret == XST_PM_NO_ACCESS && id == NODE_OCM_BANK_0) + if (ret == -EACCES && id == NODE_OCM_BANK_0) skip_config = true; return 0; @@ -235,8 +235,7 @@ int zynqmp_pm_is_function_supported(const u32 api_id, const u32 id) * * @cfg_obj: Pointer to the configuration object * @size: Size of @cfg_obj in bytes - * Return: 0 on success otherwise negative errno. If the config object - * is not loadable returns positive errno XST_PM_NO_ACCESS(2002) + * Return: 0 on success otherwise negative errno. */ int zynqmp_pmufw_load_config_object(const void *cfg_obj, size_t size) { @@ -251,10 +250,8 @@ int zynqmp_pmufw_load_config_object(const void *cfg_obj, size_t size) err = xilinx_pm_request(PM_SET_CONFIGURATION, (u32)(u64)cfg_obj, 0, 0, 0, ret_payload); if (err == XST_PM_NO_ACCESS) { - if (((u32 *)cfg_obj)[NODE_ID_LOCATION] == NODE_OCM_BANK_0) { + if (((u32 *)cfg_obj)[NODE_ID_LOCATION] == NODE_OCM_BANK_0) printf("PMUFW: No permission to change config object\n"); - return err; - } return -EACCES; }