From patchwork Fri May 12 22:31:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Edwards X-Patchwork-Id: 1780920 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=XXZNRRhJ; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QJKMX1qrYz20KF for ; Sat, 13 May 2023 18:59:52 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D05588623F; Sat, 13 May 2023 10:59:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="XXZNRRhJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 58608860A9; Sat, 13 May 2023 00:31:38 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B2ADA860A9 for ; Sat, 13 May 2023 00:31:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=cfsworks@gmail.com Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-643995a47f7so10793164b3a.1 for ; Fri, 12 May 2023 15:31:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683930694; x=1686522694; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pA8fzUK3hJcsMMc3CuYvFSGK0BrqrH3fqRzdOd7unTo=; b=XXZNRRhJw1MMAGT+MsE8pJxTyOealHX0PFVK7+5RtPoPy4t2aqzY9gUL0CdoinJMZq IzRWJTkOD8aJOqGP99PQQw52qDpFTA98K1sqG9QfsJynKOunJOUHWipKFcdvvp6mwzv6 vk4M0YftlMj3se7uBr8jT2wy96VBNAJegvQNwJWYFn3DBIyfeEr7vU9q9/wdMv1tzgQ6 LmsynwkgPiSsvZ9W5Row60N6eBvk7zT7VG1UqhN8PUd3I7Ksn3EBbVSkN9a55w/t1r/p VkpJyfqlLtY6exZyq5iBIylkKb9TddtLElVvvzE23PzQHwpIDRHFFQHEY8JKirmto5EJ HvfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683930694; x=1686522694; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pA8fzUK3hJcsMMc3CuYvFSGK0BrqrH3fqRzdOd7unTo=; b=ClbIAv+V/+Idibyfm5KqH5uCmkuqkEyQ03+eNBipqee3ER/OqzYR5ffdo4uSIXTBBx l40c0VgmNjdZOKpt9Rd2JRpty7qpvKoRgSERSmLEHSNhGyPu+r5XirqPCCJ1b8y9WaXu gX7bKoyAlWXG1KnfgoXyaSji2Q0LvRfyqkg/9woitcdV+knjT27wnGmXpQZcTC1zAgGM peNvEbswF4nlJNL4cLYbK2X496FhMPwQXzzPF03JkHp8y/vjYjNukhaYqzODdvg9Lpsp 2xs7ODlRFq92OQptT5pqapxN0r4Enl+YkzdjMC+ynxsxe3IqNkFbN7ghz1IC8OyvyceA 5yEA== X-Gm-Message-State: AC+VfDzkkLjquRAfBW8714+0TVDjV1kDoiAUKKINhRxmpnsAok2ZrECL fgsUT7v5Yr6ap4NZRGyRl65Od/PAfrG4aw== X-Google-Smtp-Source: ACHHUZ7kwpplyr61co1HIy+/J6L0xeL/4NklhXcEH9qF1b983W0Ti4lMFD65BrodQiLGx/tgFxagUg== X-Received: by 2002:a05:6a00:2311:b0:63a:ea82:b7b7 with SMTP id h17-20020a056a00231100b0063aea82b7b7mr39004318pfh.28.1683930693670; Fri, 12 May 2023 15:31:33 -0700 (PDT) Received: from celestia.nettie.lan (static-198-54-134-172.cust.tzulo.com. [198.54.134.172]) by smtp.gmail.com with ESMTPSA id j13-20020aa78dcd000000b0064aebd39fe9sm1505032pfr.44.2023.05.12.15.31.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 May 2023 15:31:33 -0700 (PDT) From: Sam Edwards X-Google-Original-From: Sam Edwards To: u-boot@lists.denx.de Cc: Tom Rini , Sam Edwards Subject: [PATCH] arm: set alignment properly for asm funcs Date: Fri, 12 May 2023 16:31:05 -0600 Message-Id: <20230512223105.131678-1-CFSworks@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Mailman-Approved-At: Sat, 13 May 2023 10:59:35 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean ARM requires a 4-byte alignment on all ARM code (though this requirement is relaxed to 2-byte for some THUMB code) and we should be explicit about that here. GAS has its own fix for this[1] that forces proper alignment on any section containing assembled instructions, but this is not universal: Clang's and other gaslike assemblers lack this implicit alignment. Whether or not this is considered a bug in those assemblers, it is better to ask directly for what we want. [1]: https://sourceware.org/bugzilla/show_bug.cgi?id=12931 Signed-off-by: Sam Edwards --- arch/arm/include/asm/linkage.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/include/asm/linkage.h b/arch/arm/include/asm/linkage.h index dbe4b4e31a..73bf25ba4e 100644 --- a/arch/arm/include/asm/linkage.h +++ b/arch/arm/include/asm/linkage.h @@ -1,7 +1,7 @@ #ifndef __ASM_LINKAGE_H #define __ASM_LINKAGE_H -#define __ALIGN .align 0 -#define __ALIGN_STR ".align 0" +#define __ALIGN .p2align 2 +#define __ALIGN_STR ".p2align 2" #endif