diff mbox series

[v1,07/17] colibri-imx8x: extract is_imx8dx() from ram detection

Message ID 20230303132642.15574-8-andrejs.cainikovs@toradex.com
State Accepted
Commit 7689fc5524a6fff2c0d70c0d855aece85a5acd21
Delegated to: Stefano Babic
Headers show
Series colibri-imx8x: support refresh | expand

Commit Message

Andrejs Cainikovs March 3, 2023, 1:26 p.m. UTC 
From: Max Krummenacher <max.krummenacher@toradex.com>

Refactor the detection of QXP vs. DX SoC into its own helper function.

Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
Signed-off-by: Andrejs Cainikovs <andrejs.cainikovs@toradex.com>
---
 board/toradex/colibri-imx8x/colibri-imx8x.c | 22 ++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

Comments

Stefano Babic March 30, 2023, 11:42 a.m. UTC | #1 
> From: Max Krummenacher <max.krummenacher@toradex.com>
> Refactor the detection of QXP vs. DX SoC into its own helper function.
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
> Signed-off-by: Andrejs Cainikovs <andrejs.cainikovs@toradex.com>
Applied to u-boot-imx, next, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/board/toradex/colibri-imx8x/colibri-imx8x.c b/board/toradex/colibri-imx8x/colibri-imx8x.c
index 169d4d04b16..88eddbddaef 100644
--- a/board/toradex/colibri-imx8x/colibri-imx8x.c
+++ b/board/toradex/colibri-imx8x/colibri-imx8x.c
@@ -40,21 +40,25 @@  static void setup_iomux_uart(void)
 	imx8_iomux_setup_multiple_pads(uart3_pads, ARRAY_SIZE(uart3_pads));
 }
 
-void board_mem_get_layout(u64 *phys_sdram_1_start,
-			  u64 *phys_sdram_1_size,
-			  u64 *phys_sdram_2_start,
-			  u64 *phys_sdram_2_size)
+static int is_imx8dx(void)
 {
-	u32 is_dualx = 0, val = 0;
-	sc_err_t scierr = sc_misc_otp_fuse_read(-1, 6, &val);
+	u32 val = 0;
+	sc_err_t sc_err = sc_misc_otp_fuse_read(-1, 6, &val);
 
-	if (scierr == SC_ERR_NONE) {
+	if (sc_err == SC_ERR_NONE) {
 		/* DX has two A35 cores disabled */
-		is_dualx = (val & 0xf) != 0x0;
+		return (val & 0xf) != 0x0;
 	}
+	return false;
+}
 
+void board_mem_get_layout(u64 *phys_sdram_1_start,
+			  u64 *phys_sdram_1_size,
+			  u64 *phys_sdram_2_start,
+			  u64 *phys_sdram_2_size)
+{
 	*phys_sdram_1_start = PHYS_SDRAM_1;
-	if (is_dualx)
+	if (is_imx8dx())
 		/* Our DX based SKUs only have 1 GB RAM */
 		*phys_sdram_1_size = SZ_1G;
 	else