From patchwork Tue Nov 29 11:41:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ashok Reddy Soma X-Patchwork-Id: 1710097 X-Patchwork-Delegate: monstr@monstr.eu Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=EKQyb/1s; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NM0mr0hGLz23nQ for ; Tue, 29 Nov 2022 22:42:02 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0C4238521C; Tue, 29 Nov 2022 12:41:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="EKQyb/1s"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D27878524D; Tue, 29 Nov 2022 12:41:51 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=0.9 required=5.0 tests=AC_FROM_MANY_DOTS,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS, SPF_PASS autolearn=no autolearn_force=no version=3.4.2 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on20613.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eb2::613]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 350C5851AB for ; Tue, 29 Nov 2022 12:41:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=ashok.reddy.soma@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fA3sRs8/9jBNk8brWi/pdJ/qy9IssL0t0pQbce5JHuT88OrWp6F/mJ9ffSbmYrS25KnE0aIGUM/ZvsQx5pfbzpn84r2qWRrWSZ6pZ+7m0FdfWcWhGcKs6EBeHtAMT5pQHmMn/Hw0h4CZA3uWRV2XvYUB/e6RaVoRJenD+fWvrNpIOE1Q1iBRmJCU6ZDzIpTfVWijyesepX79hRk1CDoaznXRxngA5O6CTKdfuCY94qSBXug9y0RcsGkZPUKQpM4fJ+vGG5oTWWZXfd8toVYSqgjXPmJqVmgmCZoK8mCvBzKQdlrsoH3bKTpGSuCdJPp3AWpZaI9tz5bClEcuZQXqvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9b8FvYRpk5RxbPjNYWdLG53F8e/j20uk9tC9cufMLsg=; b=hQZHxjBdq3t6GLUd6yqSytoBY08y7GmDqAxOW52cg+aGsFeD5mPo6lCrZLMMr5ZRLOzJHYDRuGq9GREfeFi+f5btFWrS8DeqL+f/yk83oNz0PCq8fqhaOVAO1T5QmqRqU5MdtLSXv261Yvahhc1nl92inRVHW6jV5iWMTI3UquPWmEzHjvyripD9YriburNhLWkKCqivCsnKg5nOEMuBWo25XhrrX9Pn5Qk5rdIB0tbkiBbhuvcAjbu28l5GhcnDbFeqD4JMDGehVN1hZzygX2LxWgcTrVrmg2+6huc5uJfqwhD2h6ztszOapxyRYGFexXzRltKs5SMEWhhb36GBXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.denx.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9b8FvYRpk5RxbPjNYWdLG53F8e/j20uk9tC9cufMLsg=; b=EKQyb/1sVHiFb6HnmW6FlMs+dQrpDbYzZbA4QSaWSFLxLTxKowKdsf1EaWHMhAv+yldAuORpvvLKWCLXh2vp+0teF9z8VHnMOVX+mOFyP9UqPAkPKUw3T0oOMd5WCyS3Mzrshf8Ev6bqRmDCUh6UBKT/KxLxLgon6cpgRMMq4h8= Received: from BN1PR12CA0010.namprd12.prod.outlook.com (2603:10b6:408:e1::15) by BL1PR12MB5336.namprd12.prod.outlook.com (2603:10b6:208:314::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 11:41:46 +0000 Received: from BN8NAM11FT010.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e1:cafe::6c) by BN1PR12CA0010.outlook.office365.com (2603:10b6:408:e1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Tue, 29 Nov 2022 11:41:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT010.mail.protection.outlook.com (10.13.177.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5857.17 via Frontend Transport; Tue, 29 Nov 2022 11:41:45 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 29 Nov 2022 05:41:44 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 29 Nov 2022 05:41:44 -0600 Received: from xhdashokred41.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34 via Frontend Transport; Tue, 29 Nov 2022 05:41:42 -0600 From: Ashok Reddy Soma To: CC: , , , "Ashok Reddy Soma" Subject: [PATCH] spi: cadence-qspi: Remove condition for calling enable linear mode Date: Tue, 29 Nov 2022 04:41:34 -0700 Message-ID: <20221129114134.18909-1-ashok.reddy.soma@amd.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT010:EE_|BL1PR12MB5336:EE_ X-MS-Office365-Filtering-Correlation-Id: 17f940d3-2524-43c2-07a0-08dad1feb154 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F3b3JlLhmwEZRgA4ulwdOh6Zi+GVdCPvtocOadnlc6IfPjvHw/6f2d15xwyyhnqehmkgYk5/Z1yqGifVbjXOuDK2I/tLgnHUZqfjnkwSJTUUK5LBzMbGSfMhMHj6Qq9BIVZZ/g214ZRuqk+jN1NljTa3rk+xLn3ihVBSL9em/mwl8qarcuNp52Q6Kmjf7lu+p1KmBcPCnfI33f7Bc5ki8SgNa2T8ClFpIpw+o1df5pSSaWXKi3OHjdTngoRR509Md+7aZaad/QTLx4NjR0WtRXM4zrYtnyATFXUCX/Yk8T91y9NyvcDeXG+nSXGp9wC2s7MtwWHcf0FGElBrnDEBZT/1o4B5VC/Jibzm6GtwOceSy3+mCH9q5uZMnMHazGdRlDoQIuCMS/5JlBuawLiPfquONSSf+xUjwmOhA5ULf9TTd5u/LkUuKnRWciyCAM31oJQsYgIJC3WenMBolHETDlor/bdsPkDKHaGKBVvD0PY3041FDqnfaDEtaq8CGTqrMLTg+gV5oMy33etq/CK1zSDxFlsuTLekgk0IcP2OU9H2sXLVe9AQFclum9z5o+206QAiABn97tC84TqYIQRNdkqhALZa3DyRCaEF28y6Mq3hndr7UV8poEyR71kl2noiGNwMwjjfvnkhNJBBxHtB3bYv6biLCnsHmO7uM4NyIkX4hPSpLKBgU4seZn543KDPatIpTM9RRG/X5LL5hmoeDRoSr1lyCQS9nqFRZqXIWHU= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(376002)(346002)(396003)(136003)(451199015)(36840700001)(46966006)(40470700004)(8936002)(5660300002)(103116003)(316002)(8676002)(70586007)(70206006)(4326008)(54906003)(6916009)(36756003)(41300700001)(36860700001)(426003)(47076005)(40460700003)(83380400001)(82740400003)(40480700001)(81166007)(356005)(6666004)(86362001)(478600001)(82310400005)(2616005)(26005)(336012)(1076003)(186003)(2906002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 11:41:45.2850 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 17f940d3-2524-43c2-07a0-08dad1feb154 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT010.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5336 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean cadence_qspi_apb_enable_linear_mode() has a weak function defined, so no need to gaurd this under if (CONFIG_IS_ENABLED(ARCH_VERSAL)). In cadence_qspi_apb_write_execute(), enable linear mode is called twice by mistake, remove extra one. Signed-off-by: Ashok Reddy Soma --- drivers/spi/cadence_qspi_apb.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/spi/cadence_qspi_apb.c b/drivers/spi/cadence_qspi_apb.c index cfae5dcbda..d1f89138ef 100644 --- a/drivers/spi/cadence_qspi_apb.c +++ b/drivers/spi/cadence_qspi_apb.c @@ -735,8 +735,7 @@ int cadence_qspi_apb_read_execute(struct cadence_spi_priv *priv, void *buf = op->data.buf.in; size_t len = op->data.nbytes; - if (CONFIG_IS_ENABLED(ARCH_VERSAL)) - cadence_qspi_apb_enable_linear_mode(true); + cadence_qspi_apb_enable_linear_mode(true); if (priv->use_dac_mode && (from + len < priv->ahbsize)) { if (len < 256 || @@ -905,9 +904,6 @@ int cadence_qspi_apb_write_execute(struct cadence_spi_priv *priv, const void *buf = op->data.buf.out; size_t len = op->data.nbytes; - if (CONFIG_IS_ENABLED(ARCH_VERSAL)) - cadence_qspi_apb_enable_linear_mode(true); - /* * Some flashes like the Cypress Semper flash expect a dummy 4-byte * address (all 0s) with the read status register command in DTR mode.