From patchwork Mon Oct 24 15:42:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 1693965 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=seco.com header.i=@seco.com header.a=rsa-sha256 header.s=selector1 header.b=NlE59tuS; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MwzqH2yTYz23l5 for ; Tue, 25 Oct 2022 02:42:51 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5068883F4E; Mon, 24 Oct 2022 17:42:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=seco.com header.i=@seco.com header.b="NlE59tuS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DCA2684225; Mon, 24 Oct 2022 17:42:36 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80045.outbound.protection.outlook.com [40.107.8.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8B34280F70 for ; Mon, 24 Oct 2022 17:42:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sean.anderson@seco.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kV4Cgdd9wsZDOVvT6UTZdryjID8D8TBy6g/xymVAThiSBxjs6BcmNzuq5HwL6eEZg0gpZJzqm6dPKLh1tycjRzCjv2I7rCZ13HveSrHEQwyvlMS6Cvz4ur30kXplBNx7fzuxMfyNifXSQWBvkP09RP5l//ddkk/mDoWPB0NPbMMyub5rzLTPLSuj/8+FexvNzk3gvCtsdh4eOA1mTeJ1r7oDgkAzPveYpYaxkRbObDKQX84Xv38xcBGNTna4Nh0ezCf0YDE+HNP8KJehJ6y/PRb3g7Cu090BWqqAL2g4T7FEAaiNzG5peVg8A68blyPecSI+GVI1n1BnxStvLZIvnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gAHlQh/asX2hupa3TIK8UoU+P3W43hjF7O2NqU23/dg=; b=R78RuIjCc3utoa45XtRy8NsMHg06E0sxUz+ygUxezb3HguLOUyR+XalRgPPg314RxNMnlboDD/yYVP5sw9HcCbkecW40bIwoj5lleJiu48/GXbr0yfT+tl68IO8iLhOiGATUfmN1l9ZRbYg5NdkGcHRH9lUQ597JKY7zgCPHaKfe2UeE/D48RMjvCCjfWZRBNRiPTCKlgyk7RSuzN18ypTiF0Tpp3S40rsEYCQhHnJZpX6Ah0hwXmlbjl+rxyctQSxS1Q0X316Lc/Ctpon0YS9zFUX6a3EEkcarymxohiG3kTTwrRmBOlk5W6ZT3+TMuoHRGKr3JYAXB0un568XB5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seco.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gAHlQh/asX2hupa3TIK8UoU+P3W43hjF7O2NqU23/dg=; b=NlE59tuS2r40jbXg+flD+kI+zZn9jcqCisOLhnjmy8HtdSVVNOUyUoPfMhqEzQQGHf+HDE9b2Fu8esJdaYPh9HXgCtPlbn1s9OtFtNhpHA30trLwEyRceMeGJMzXL0tIUNJmFaI5onBK5MI1+KuboN8O6+KON0sKG6OrDu/RpkNLpEcO2RE62ZZhj5qtUf/ALAFCguxJJhqLfJ5CLB8ZVW7+GkBDbafSggFRHhgCK92m3WTKK4F76b0XdPA3cEAuYmAVBXxUYdZNfjwN8l9fPwFNJwmq9HrnRNxjQVQ3yzk1+9ri9SvX1VXvU1XtIynuLOITH5vwIPjxX+DeMLMsmg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=seco.com; Received: from DB7PR03MB4972.eurprd03.prod.outlook.com (2603:10a6:10:7d::22) by AS8PR03MB7190.eurprd03.prod.outlook.com (2603:10a6:20b:2ed::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Mon, 24 Oct 2022 15:42:32 +0000 Received: from DB7PR03MB4972.eurprd03.prod.outlook.com ([fe80::204a:de22:b651:f86d]) by DB7PR03MB4972.eurprd03.prod.outlook.com ([fe80::204a:de22:b651:f86d%6]) with mapi id 15.20.5723.034; Mon, 24 Oct 2022 15:42:31 +0000 From: Sean Anderson To: u-boot@lists.denx.de, Tom Rini Cc: Simon Glass , Rasmus Villemoes , Sean Anderson , Bin Meng Subject: [PATCH v3 1/2] x86: fsp: Depend on DM_RTC Date: Mon, 24 Oct 2022 11:42:03 -0400 Message-Id: <20221024154204.2133777-2-sean.anderson@seco.com> X-Mailer: git-send-email 2.35.1.1320.gc452695387.dirty In-Reply-To: <20221024154204.2133777-1-sean.anderson@seco.com> References: <20221024154204.2133777-1-sean.anderson@seco.com> X-ClientProxiedBy: BYAPR02CA0051.namprd02.prod.outlook.com (2603:10b6:a03:54::28) To DB7PR03MB4972.eurprd03.prod.outlook.com (2603:10a6:10:7d::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB7PR03MB4972:EE_|AS8PR03MB7190:EE_ X-MS-Office365-Filtering-Correlation-Id: 1598cec0-f37a-49ec-1b75-08dab5d65d1e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZbTZmNS43LohSbQcpQmjw6drkeArMM81dckvDn4KAkZS8+zj5jcpxCIMPOypmvuvG9R2TQ1OY2iZwJ9KqzMlQCPrY41jfJterH89Szu06dBYIfwHMOhxhPhdnA+l+abB0EJpqZEDcUH478SKFuSswKngkNGrkLeJw62U6BNDLq8GAPqL//3KCeudqXQjemI4Hg34f2cMkJnn2W8VYbo9q5c7QOEKMiVYOIMyBGKUxOIoVPGsF/LEAiz23oKX1AhqgjuKOqO/C93k3HRU9A1ci8+rFVutVlx5Wnjp1+eNKxyCI1R10OreftfqMLl1IHEyXTFwt8KHvHuKswmSlKgSav3ykNFrXyiaoy+A5sNRCedgBLbBRdKnpdH3nRBsWLS6KsvvmbwIIP7YoP4yowu5uHHPa/LyjInO37KolKgsHWdxUbzFX35CNiLu0KJrKSbFKpQe42pldRdYMDnTgDXveT9r5xfxx/C6CC/mWdK/N7q1qp1ISYSNca6PE3rIXR6Ba8peZLeJUFWw/qiqYUNwtkt0RQo4GfzDQhnYDgPWuiKjbiGhYv6y7lzeEbF7AQtuwN7owvoSFE9WYKWT/7yx6lStRZjYNQTSWcNtLxlFXfcZmPVYDAV9fBGsrGF2qZA5YZ5Xcmrg6r19qSgkmKckHLmBYI457OKeo3gJqO28IgZVaSKvIUkCxfhPaiDH2AFg6uX4HxuZ/4BPnB6/mLASd0ZLyjPivWyrhswat8/q65wRfwRs1HyIktrWzXBTsyBAyIb0WhvgghVbWBz5s1qoAA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR03MB4972.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(39850400004)(346002)(136003)(396003)(376002)(451199015)(86362001)(316002)(54906003)(6916009)(6512007)(41300700001)(8936002)(36756003)(26005)(186003)(5660300002)(2616005)(44832011)(4744005)(2906002)(8676002)(4326008)(66946007)(66556008)(6666004)(52116002)(6506007)(1076003)(6486002)(38350700002)(478600001)(38100700002)(66476007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: k0vxtpy5llggJF6+A+16qnx0aMPSMlOTNg8sy32cfpO1OsKyEQy+e4vRrqGY+TbjR9t+/MTrN2CfP38PTWEZhCdUdssTBBDt1BngdI5ShIA0MUKZe4GmCFxJgPYCan6bzr+wxTG/c7nbFOhgwYch1hXbFTZhoDV/wixoMXP4Hq1ZNzGyG6mybCwR3EGyImVOvbE7ZNTpN+/jU3/mTqt2T4qXJzvebqJGD2bMnDobik8a7tbxkfjF17S+BKNDReks9pb7BzXCWiQJoePMh46B4pZw6n0J7r2q5u8RfwiTTP3SNgdHIKVlqUvFiLLVoKFJnIto0WF2pL1bViYfXLL1PsaXg57I/E1N6BxSL1CEVd40URpZkjhVqdv66TpCLvaxHI3rcB36B2uAYJEEVxwXeD2OTkbq8slgp03nhTRWcydJArO1l0lHrUfBIK3Qpy5MJNAUql32LQ3Ux7HOXaH3Z8ocgXIv50dfMNUkrdZ9tnRZtMCL2Zu2/ZqaOGTAPp6H8I/EYEs773OhByXOxwtBG/GWK8i9rfNpIKMwKgpNaO2bpToMf4XkgtI5N2Lue9wTk54NrX010uQesuQT6EcJxS9q5U74Jq332Gh7aj8YCU6SYuHJWpCT9efUddeLTc42uFCuVKWvHLrbXFzJ2YHvskYRqPYuQ9fMEKl6wgK243CqeDFkqfUNpoZ1qCe8n7AMQKUcaiqITwBlMGpLxtQUoJQN7bOJzJgW00jlqdADwZwcr5DDM5zWZzhjaMkDtJSs+yRwku1ZcRjvKncLw3Pfe/SZV+EOeSZN3X6gYedn0fA6KjZ3sY3pyMaD/BszIOjPnm5wQn1iMhpaIjBC6fZXQ5zcDraZhYbpOtrnWNQkL6m5d3MerF6QSLLouifEBtDRxPsF9+MlT9vHTVzDxnz/rqKuPNgo8lUoAq3rKVGrH6vzQ1dJ57dodHCt9vGCrSgzpB+ufpCd3fo28KjwQympCYeSI0J4ejTLHztfC/pqwMK7ybZDimir1teHTFyvTbVNcaoNvgSR9KRE94EKdWho3GwoEv3d6EiORR3K19LEF+CCfnNM9FFkf1mZRuLqyVvaGf5ganBIYyaen6hTFJoVeAIgMWFXjj8/RK/qZRf26npwCpNwCvrnaHLfXY0SSSvYzYB+YWn1G/O2jdi1IVZa/IJh7Bxx6bJKBqWKprbs533ATZpyIHAtmTd2wqEhBqrXOyCFy/o+pH9tELzQnGYl4A/tBB/GdDybw50oLEO4k3MFbYc2PsUpwwH+JdRfQ/LO5yS63oZYMkE/0OTH2aukaISmHOBIq/Rqarql7bmfJ0zEnqmPS8c1Xqc5GvtbbZlM0TcCL0BQ4nB4luEbFep4GNh/Qr/XG205vVV4rUn/f9W0DguWqfM7Z8jLAmPEuJ3fGArpYIoqSKOYnbuuUBmh64ffu0zfRnGDPn8VmmbGXKiOU1xjXKFg3IyMp5Z52/sKLZNDFYn1Yvhccqp7+rWnMTO6mpvTvEquGZ814Zm4u8JZ+8hcGtmXEN8mE0N3SgZUmoRw8MKvF5QNbePwKjq/7QUKP7ClRnrTGDMbKxbh5lIBgdLXxsD6r56z7xEpndE+/1xi93BD4OFe378EXnVHnQ== X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1598cec0-f37a-49ec-1b75-08dab5d65d1e X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 15:42:31.9041 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0pOgq6iK3hy3+lW0Vw/A2Pz35fNkc468j2sb3iwTmxFFUE0Ls7C0xFHKOtlapTo0r7BbiB/qjlXHrsYEbkTL1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7190 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean FSP support requires DM_RTC for rtc_write32. Select it. Fixes: ba65808e7d0 ("x86: fsp: Save stack address to CMOS for next S3 boot") Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- This seems like it would never have worked. Does fsp_save_s3_stack even get called in SPL? Maybe it should be converted to use dm_rtc_write instead. Changes in v3: - New arch/x86/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 7cbfd6c9720..ed8216d9ad0 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -362,6 +362,8 @@ config HAVE_FSP depends on !EFI select USE_HOB select HAS_ROM + select DM_RTC + select SPL_DM_RTC help Select this option to add an Firmware Support Package binary to the resulting U-Boot image. It is a binary blob which U-Boot uses