| Message ID | 20220830195049.1068973-1-jorge@foundries.io |
|---|---|
| State | Superseded |
| Delegated to: | Patrice Chotard |
| Headers | show |
| Series | configs: stm32mp*: reset via CONFIG_RESET_SCMI | expand |
On 30/08/22, Jorge Ramirez-Ortiz wrote: > Enabling CONFIG_SYSRESET_PSCI prevents CONFIG_RESET_SCMI > from executing. > > The side effect observed are I2C devices no longer being > accessible from U-boot after a soft reset. I think this PR should get a bit more of attention. The current reset configuration is broken, this is a fix. Do I need to rename the PR? TIA jorge > > Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io> > --- > configs/stm32mp13_defconfig | 1 - > configs/stm32mp15_defconfig | 1 - > configs/stm32mp15_trusted_defconfig | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/configs/stm32mp13_defconfig b/configs/stm32mp13_defconfig > index 673b468d31..44cee2e656 100644 > --- a/configs/stm32mp13_defconfig > +++ b/configs/stm32mp13_defconfig > @@ -69,7 +69,6 @@ CONFIG_RNG_OPTEE=y > CONFIG_DM_RTC=y > CONFIG_RTC_STM32=y > CONFIG_SERIAL_RX_BUFFER=y > -CONFIG_SYSRESET_PSCI=y > CONFIG_TEE=y > CONFIG_OPTEE=y > # CONFIG_OPTEE_TA_AVB is not set > diff --git a/configs/stm32mp15_defconfig b/configs/stm32mp15_defconfig > index e5a2996c2c..2ad02f3652 100644 > --- a/configs/stm32mp15_defconfig > +++ b/configs/stm32mp15_defconfig > @@ -133,7 +133,6 @@ CONFIG_SPI=y > CONFIG_DM_SPI=y > CONFIG_STM32_QSPI=y > CONFIG_STM32_SPI=y > -CONFIG_SYSRESET_PSCI=y > CONFIG_TEE=y > CONFIG_OPTEE=y > # CONFIG_OPTEE_TA_AVB is not set > diff --git a/configs/stm32mp15_trusted_defconfig b/configs/stm32mp15_trusted_defconfig > index e14668042f..9e24e82920 100644 > --- a/configs/stm32mp15_trusted_defconfig > +++ b/configs/stm32mp15_trusted_defconfig > @@ -134,7 +134,6 @@ CONFIG_SPI=y > CONFIG_DM_SPI=y > CONFIG_STM32_QSPI=y > CONFIG_STM32_SPI=y > -CONFIG_SYSRESET_PSCI=y > CONFIG_TEE=y > CONFIG_OPTEE=y > # CONFIG_OPTEE_TA_AVB is not set > -- > 2.34.1 >
Jorge, I think, renaming the patch to "fix" and adding a field "Fixes:" should help accept it faster. On Mon, Sep 5, 2022 at 7:32 PM Jorge Ramirez-Ortiz, Foundries <jorge@foundries.io> wrote: > > On 30/08/22, Jorge Ramirez-Ortiz wrote: > > Enabling CONFIG_SYSRESET_PSCI prevents CONFIG_RESET_SCMI > > from executing. > > > > The side effect observed are I2C devices no longer being > > accessible from U-boot after a soft reset. > > I think this PR should get a bit more of attention. > > The current reset configuration is broken, this is a fix. > Do I need to rename the PR? > > TIA > jorge > > > > > > Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io> > > --- > > configs/stm32mp13_defconfig | 1 - > > configs/stm32mp15_defconfig | 1 - > > configs/stm32mp15_trusted_defconfig | 1 - > > 3 files changed, 3 deletions(-) > > > > diff --git a/configs/stm32mp13_defconfig b/configs/stm32mp13_defconfig > > index 673b468d31..44cee2e656 100644 > > --- a/configs/stm32mp13_defconfig > > +++ b/configs/stm32mp13_defconfig > > @@ -69,7 +69,6 @@ CONFIG_RNG_OPTEE=y > > CONFIG_DM_RTC=y > > CONFIG_RTC_STM32=y > > CONFIG_SERIAL_RX_BUFFER=y > > -CONFIG_SYSRESET_PSCI=y > > CONFIG_TEE=y > > CONFIG_OPTEE=y > > # CONFIG_OPTEE_TA_AVB is not set > > diff --git a/configs/stm32mp15_defconfig b/configs/stm32mp15_defconfig > > index e5a2996c2c..2ad02f3652 100644 > > --- a/configs/stm32mp15_defconfig > > +++ b/configs/stm32mp15_defconfig > > @@ -133,7 +133,6 @@ CONFIG_SPI=y > > CONFIG_DM_SPI=y > > CONFIG_STM32_QSPI=y > > CONFIG_STM32_SPI=y > > -CONFIG_SYSRESET_PSCI=y > > CONFIG_TEE=y > > CONFIG_OPTEE=y > > # CONFIG_OPTEE_TA_AVB is not set > > diff --git a/configs/stm32mp15_trusted_defconfig b/configs/stm32mp15_trusted_defconfig > > index e14668042f..9e24e82920 100644 > > --- a/configs/stm32mp15_trusted_defconfig > > +++ b/configs/stm32mp15_trusted_defconfig > > @@ -134,7 +134,6 @@ CONFIG_SPI=y > > CONFIG_DM_SPI=y > > CONFIG_STM32_QSPI=y > > CONFIG_STM32_SPI=y > > -CONFIG_SYSRESET_PSCI=y > > CONFIG_TEE=y > > CONFIG_OPTEE=y > > # CONFIG_OPTEE_TA_AVB is not set > > -- > > 2.34.1 > >
Hi, On 9/5/22 19:01, Oleksandr Suvorov wrote: > Jorge, > > I think, renaming the patch to "fix" and adding a field "Fixes:" > should help accept it faster. > > On Mon, Sep 5, 2022 at 7:32 PM Jorge Ramirez-Ortiz, Foundries > <jorge@foundries.io> wrote: >> On 30/08/22, Jorge Ramirez-Ortiz wrote: >>> Enabling CONFIG_SYSRESET_PSCI prevents CONFIG_RESET_SCMI >>> from executing. >>> >>> The side effect observed are I2C devices no longer being >>> accessible from U-boot after a soft reset. >> I think this PR should get a bit more of attention. >> >> The current reset configuration is broken, this is a fix. >> Do I need to rename the PR? >> >> TIA >> jorge >> >> >>> Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io> >>> --- >>> configs/stm32mp13_defconfig | 1 - >>> configs/stm32mp15_defconfig | 1 - >>> configs/stm32mp15_trusted_defconfig | 1 - >>> 3 files changed, 3 deletions(-) >>> >>> diff --git a/configs/stm32mp13_defconfig b/configs/stm32mp13_defconfig >>> index 673b468d31..44cee2e656 100644 >>> --- a/configs/stm32mp13_defconfig >>> +++ b/configs/stm32mp13_defconfig >>> @@ -69,7 +69,6 @@ CONFIG_RNG_OPTEE=y >>> CONFIG_DM_RTC=y >>> CONFIG_RTC_STM32=y >>> CONFIG_SERIAL_RX_BUFFER=y >>> -CONFIG_SYSRESET_PSCI=y >>> CONFIG_TEE=y >>> CONFIG_OPTEE=y >>> # CONFIG_OPTEE_TA_AVB is not set >>> diff --git a/configs/stm32mp15_defconfig b/configs/stm32mp15_defconfig >>> index e5a2996c2c..2ad02f3652 100644 >>> --- a/configs/stm32mp15_defconfig >>> +++ b/configs/stm32mp15_defconfig >>> @@ -133,7 +133,6 @@ CONFIG_SPI=y >>> CONFIG_DM_SPI=y >>> CONFIG_STM32_QSPI=y >>> CONFIG_STM32_SPI=y >>> -CONFIG_SYSRESET_PSCI=y >>> CONFIG_TEE=y >>> CONFIG_OPTEE=y >>> # CONFIG_OPTEE_TA_AVB is not set >>> diff --git a/configs/stm32mp15_trusted_defconfig b/configs/stm32mp15_trusted_defconfig >>> index e14668042f..9e24e82920 100644 >>> --- a/configs/stm32mp15_trusted_defconfig >>> +++ b/configs/stm32mp15_trusted_defconfig >>> @@ -134,7 +134,6 @@ CONFIG_SPI=y >>> CONFIG_DM_SPI=y >>> CONFIG_STM32_QSPI=y >>> CONFIG_STM32_SPI=y >>> -CONFIG_SYSRESET_PSCI=y >>> CONFIG_TEE=y >>> CONFIG_OPTEE=y >>> # CONFIG_OPTEE_TA_AVB is not set >>> -- >>> 2.34.1 >>> > > This patch it is superseded by "configs: stm32mp*: fix system reset" http://patchwork.ozlabs.org/project/uboot/list/?series=316914&state=* http://patchwork.ozlabs.org/project/uboot/patch/20220905173357.2231466-1-jorge@foundries.io/ with the added "Fixes:" Regards Patrick
diff --git a/configs/stm32mp13_defconfig b/configs/stm32mp13_defconfig index 673b468d31..44cee2e656 100644 --- a/configs/stm32mp13_defconfig +++ b/configs/stm32mp13_defconfig @@ -69,7 +69,6 @@ CONFIG_RNG_OPTEE=y CONFIG_DM_RTC=y CONFIG_RTC_STM32=y CONFIG_SERIAL_RX_BUFFER=y -CONFIG_SYSRESET_PSCI=y CONFIG_TEE=y CONFIG_OPTEE=y # CONFIG_OPTEE_TA_AVB is not set diff --git a/configs/stm32mp15_defconfig b/configs/stm32mp15_defconfig index e5a2996c2c..2ad02f3652 100644 --- a/configs/stm32mp15_defconfig +++ b/configs/stm32mp15_defconfig @@ -133,7 +133,6 @@ CONFIG_SPI=y CONFIG_DM_SPI=y CONFIG_STM32_QSPI=y CONFIG_STM32_SPI=y -CONFIG_SYSRESET_PSCI=y CONFIG_TEE=y CONFIG_OPTEE=y # CONFIG_OPTEE_TA_AVB is not set diff --git a/configs/stm32mp15_trusted_defconfig b/configs/stm32mp15_trusted_defconfig index e14668042f..9e24e82920 100644 --- a/configs/stm32mp15_trusted_defconfig +++ b/configs/stm32mp15_trusted_defconfig @@ -134,7 +134,6 @@ CONFIG_SPI=y CONFIG_DM_SPI=y CONFIG_STM32_QSPI=y CONFIG_STM32_SPI=y -CONFIG_SYSRESET_PSCI=y CONFIG_TEE=y CONFIG_OPTEE=y # CONFIG_OPTEE_TA_AVB is not set
Enabling CONFIG_SYSRESET_PSCI prevents CONFIG_RESET_SCMI from executing. The side effect observed are I2C devices no longer being accessible from U-boot after a soft reset. Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io> --- configs/stm32mp13_defconfig | 1 - configs/stm32mp15_defconfig | 1 - configs/stm32mp15_trusted_defconfig | 1 - 3 files changed, 3 deletions(-)