diff mbox series

fpga: zynq: Remove post config info message for SPL

Message ID 20220808145331.24723-1-stefan.herbrechtsmeier-oss@weidmueller.com
State Accepted
Commit 7a0bc18b6309be421b7968ee70efb54c9e3d59dd
Delegated to: Michal Simek
Headers show
Series fpga: zynq: Remove post config info message for SPL | expand

Commit Message

Stefan Herbrechtsmeier Aug. 8, 2022, 2:53 p.m. UTC
From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>

The drivers informs the user that a post config was not run after FPGA
configuration. This message is unnecessary in SPL because the
ps7_post_config function is called via spl_board_prepare_for_boot
function before jump_to_image_no_args function from board_init_r
function.

Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>

---

 drivers/fpga/zynqpl.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Michal Simek Aug. 9, 2022, 2:16 p.m. UTC | #1
On 8/8/22 16:53, Stefan Herbrechtsmeier wrote:
> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
> 
> The drivers informs the user that a post config was not run after FPGA
> configuration. This message is unnecessary in SPL because the
> ps7_post_config function is called via spl_board_prepare_for_boot
> function before jump_to_image_no_args function from board_init_r
> function.
> 
> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
> 
> ---
> 
>   drivers/fpga/zynqpl.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/zynqpl.c b/drivers/fpga/zynqpl.c
> index d8ebd542ab..0c83df46da 100644
> --- a/drivers/fpga/zynqpl.c
> +++ b/drivers/fpga/zynqpl.c
> @@ -413,7 +413,8 @@ static int zynq_load(xilinx_desc *desc, const void *buf, size_t bsize,
>   	if (bstype != BIT_PARTIAL)
>   		zynq_slcr_devcfg_enable();
>   
> -	puts("INFO:post config was not run, please run manually if needed\n");
> +	if (!IS_ENABLED(CONFIG_SPL_BUILD))
> +		puts("INFO:post config was not run, please run manually if needed\n");
>   
>   	return FPGA_SUCCESS;
>   }

Applied.
M
diff mbox series

Patch

diff --git a/drivers/fpga/zynqpl.c b/drivers/fpga/zynqpl.c
index d8ebd542ab..0c83df46da 100644
--- a/drivers/fpga/zynqpl.c
+++ b/drivers/fpga/zynqpl.c
@@ -413,7 +413,8 @@  static int zynq_load(xilinx_desc *desc, const void *buf, size_t bsize,
 	if (bstype != BIT_PARTIAL)
 		zynq_slcr_devcfg_enable();
 
-	puts("INFO:post config was not run, please run manually if needed\n");
+	if (!IS_ENABLED(CONFIG_SPL_BUILD))
+		puts("INFO:post config was not run, please run manually if needed\n");
 
 	return FPGA_SUCCESS;
 }