Message ID | 20220722100908.3853994-2-foss+uboot@0leil.net |
---|---|
State | Accepted |
Commit | e5422ea51290db9de0d3a48ec4bfbdf6d27c2662 |
Delegated to: | Kever Yang |
Headers | show |
Series | [v2,1/2] spl: enable regulator-boot-on and disable regulator-force-boot-off | expand |
Hi all, Gentle ping on the series. Cheers, Quentin On 7/22/22 12:09, Quentin Schulz wrote: > From: Quentin Schulz <quentin.schulz@theobroma-systems.com> > > An earlier commit makes the common SPL code call > regulators_enable_boot_on and regulators_enable_boot_off before > iterating over possible boot media for U-Boot proper. There is therefore > no need to do this in the rk3399-specific code, so let's remove it. > > Cc: Quentin Schulz <foss+uboot@0leil.net> > Tested-by: Xavier Drudis Ferran <xdrudis@tinet.cat> > Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com> > --- > > This patch depends on: > - https://urldefense.proofpoint.com/v2/url?u=https-3A__lore.kernel.org_u-2Dboot_20220722093014.3850165-2D1-2Dfoss-2Buboot-400leil.net_&d=DwIDAg&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=tN3yjAlaBf8feDQRU2WyKBEH_wplRDDMlbjvLOk5c2B1O74m9e5VmLNibPUvEanQ&s=_eg_QaLIJjw9hvQOrnFP1GJtrrgxnKP2feaC1mWG4i0&e= > - https://urldefense.proofpoint.com/v2/url?u=https-3A__lore.kernel.org_u-2Dboot_20220722093014.3850165-2D2-2Dfoss-2Buboot-400leil.net_&d=DwIDAg&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=tN3yjAlaBf8feDQRU2WyKBEH_wplRDDMlbjvLOk5c2B1O74m9e5VmLNibPUvEanQ&s=Sb2uWDQ7C0ZeT6n0AP5oOGVE0-_dMvOpEh4uUPfGy5U&e= > > v2: > - added Tested-by, > > arch/arm/mach-rockchip/rk3399/rk3399.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/arch/arm/mach-rockchip/rk3399/rk3399.c b/arch/arm/mach-rockchip/rk3399/rk3399.c > index fc1acaf4bd..94d0fa58c4 100644 > --- a/arch/arm/mach-rockchip/rk3399/rk3399.c > +++ b/arch/arm/mach-rockchip/rk3399/rk3399.c > @@ -280,15 +280,5 @@ void spl_board_init(void) > if (cru->glb_rst_st != 0) > rk3399_force_power_on_reset(); > } > - > - if (IS_ENABLED(CONFIG_SPL_DM_REGULATOR)) { > - /* > - * Turning the eMMC and SPI back on (if disabled via the Qseven > - * BIOS_ENABLE) signal is done through a always-on regulator). > - */ > - if (regulators_enable_boot_on(false)) > - debug("%s: Cannot enable boot on regulator\n", > - __func__); > - } > } > #endif
On Fri, Jul 22, 2022 at 3:39 PM Quentin Schulz <foss+uboot@0leil.net> wrote: > > From: Quentin Schulz <quentin.schulz@theobroma-systems.com> > > An earlier commit makes the common SPL code call > regulators_enable_boot_on and regulators_enable_boot_off before > iterating over possible boot media for U-Boot proper. There is therefore > no need to do this in the rk3399-specific code, so let's remove it. > > Cc: Quentin Schulz <foss+uboot@0leil.net> > Tested-by: Xavier Drudis Ferran <xdrudis@tinet.cat> > Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com> > --- Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
diff --git a/arch/arm/mach-rockchip/rk3399/rk3399.c b/arch/arm/mach-rockchip/rk3399/rk3399.c index fc1acaf4bd..94d0fa58c4 100644 --- a/arch/arm/mach-rockchip/rk3399/rk3399.c +++ b/arch/arm/mach-rockchip/rk3399/rk3399.c @@ -280,15 +280,5 @@ void spl_board_init(void) if (cru->glb_rst_st != 0) rk3399_force_power_on_reset(); } - - if (IS_ENABLED(CONFIG_SPL_DM_REGULATOR)) { - /* - * Turning the eMMC and SPI back on (if disabled via the Qseven - * BIOS_ENABLE) signal is done through a always-on regulator). - */ - if (regulators_enable_boot_on(false)) - debug("%s: Cannot enable boot on regulator\n", - __func__); - } } #endif