From patchwork Wed Jun 15 12:34:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaurav Jain X-Patchwork-Id: 1643728 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=M0kNVlUC; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LNPsk1h7Zz9tlf for ; Wed, 15 Jun 2022 22:35:36 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E00D084400; Wed, 15 Jun 2022 14:35:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="M0kNVlUC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 34468843EA; Wed, 15 Jun 2022 14:35:24 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,SPF_HELO_PASS, T_SCC_BODY_TEXT_LINE,T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0611.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1f::611]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B010D84400 for ; Wed, 15 Jun 2022 14:35:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=gaurav.jain@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lpy576lncMDsZ07IKB3xT7li8Kbq2hs1FHf0ZvHkMJTg7fwt4JsWJqQe8is2xo3j4gP0qBgSqFhEUQfvqJJxxlFpFLaaJYZ1rHCSmVTGjQTER80YjAbvxHeDW1IiX1tGYvihNS//tS/lnxUGvbCm5UToEzQ0ZD6NoYwI1DPNaIyEQz7wJ8v0sIjvbqFjpCEyA6I1qp8CCzXeT8x90h1pJ6MveDKdmf6Tv5TWmce1E8Uk5jNFWpLx6KveBFjG5Z+gm++WftAKvKdL4bi+GKHI+azO0jODcqOUt6m+ovOnq2F+0euNpv146fhsXHTD/StpUaSOCLFbmGlGJ21AWMclGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CjaiquU84pj8Vyf/AxP2/BJXakqXH3q7tfjJh9mmB0U=; b=k9ylcsirNWy7DU1H6XI2xd7VXH1HU0OCkZxZ5AnsBPXcJK4emfB3fbuXWA9Bhj+3k6d9ZkZPr66x7i7NJjFWOSMEcWka5KAlCTIh+/mZOs91aWscKwvQducxksM/IPAsLQC64QQohxxMiIQa8c7Wd+3OgYxSueHSkH14Wu26UXUuKOEiA7ITyyvSBD4CTBZIJt51bmw+9fzf9UoWZ4fraL7b8GK5FsiIJRYC4lpey64Vpae2Vl4FYLNhUrmk4S9O3/Gs+exkeRZ7J09koPDHoa0v0W9+uptaoMDR4Y+KDm9xdZwhjy3vCkQfyKn60UwHTz6DZJfgMCmrjA7+gUqBKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CjaiquU84pj8Vyf/AxP2/BJXakqXH3q7tfjJh9mmB0U=; b=M0kNVlUC+NS1QvFYw4CfLiW7NugkQebbLqzPS6iqe5TXZMO2gpV8p00Bg71qZ0/cAdkReSyymgxVosJjSBfkBCmHxp5PWwoS5ax4QpKQ8g3iMDgySc14BSaAIbl9fZL6uuJg8UscyglAA2d/Yr//42nYTfWc1PCnD+EMrjliVBk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5342.eurprd04.prod.outlook.com (2603:10a6:803:46::16) by DB7PR04MB4011.eurprd04.prod.outlook.com (2603:10a6:5:1d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.21; Wed, 15 Jun 2022 12:35:19 +0000 Received: from VI1PR04MB5342.eurprd04.prod.outlook.com ([fe80::f0cf:687e:22d3:5eb9]) by VI1PR04MB5342.eurprd04.prod.outlook.com ([fe80::f0cf:687e:22d3:5eb9%6]) with mapi id 15.20.5332.022; Wed, 15 Jun 2022 12:35:19 +0000 From: Gaurav Jain To: u-boot@lists.denx.de, Stefano Babic Cc: Peng Fan , Fabio Estevam , "NXP i . MX U-Boot Team" , Horia Geanta , Varun Sethi , Ye Li , Gaurav Jain Subject: [PATCH v3] crypto/fsl: fsl_rsa: Fix dcache issue in the driver Date: Wed, 15 Jun 2022 18:04:47 +0530 Message-Id: <20220615123447.4087910-1-gaurav.jain@nxp.com> X-Mailer: git-send-email 2.25.1 X-ClientProxiedBy: SI2PR02CA0050.apcprd02.prod.outlook.com (2603:1096:4:196::11) To VI1PR04MB5342.eurprd04.prod.outlook.com (2603:10a6:803:46::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 92e2dee4-044d-48ba-1fea-08da4ecb8157 X-MS-TrafficTypeDiagnostic: DB7PR04MB4011:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oJVxj4CsY1n50KVtz76XCGXzev5sGsFpX6qTx0w3entkfrHVhF5+KKvHbx9UKBuqYNRA9Q0FpbPdRObE37s/K3WRJO6JuV+LeXAkD6+wxBjUkOno5Z1MbJDdR2niGxZUS6MnpbtSOAYCWgE26z31wH9NXNqygX/yqry/6B2d7Q2j8mPFSkr5FWcTZs8d7ZGP/i5CfxJ1o8xPfEDEMgR4BOjGlMJ/SQRA36ewQXO2hhIDZUuH3oHwwmjREoSVqzufH8kxfDU4WSlOM9IM9/11WeaL4qbgu7H3iNtciehr1PhHUg2LEYxvyPtZySMjMi9av5WU54UpmqkqB/rhw0+NV5JOCFXzbxHGYQT5xFpOmxx+WBw8dKZgtOUDMLrQU73ErSLOkw92UQd7g/fH9uC7I2aoehe/bHj3Ce7pDla9XEY6Xa/wpXjRwjkcMMcU1WNFRJE18Ttl46wJzQc18597vIje/AQ8yJXNeDDgkjvGjBwOikm8h23cwfSIFyDman1q5wxDRldSeisINAuFcvPvnLY5acKEn4aAgTT+TuRGFz0p2aoz+8KIz9zlADOsCccf1vyaTNrQtTNXLtY0DK1WjVxjC5GjS+dwUszxGPR5YW5sL5CHzg1eUapyq7osLFIYKLkAFZxsAfM9Olb4yTBEAf17Twpw/chXs8VeknHYiqQ+T308o2+8CHWZdzL+9YYzJkyC5bZUC8adrxyviNaj/A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5342.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(86362001)(5660300002)(8936002)(36756003)(6506007)(66556008)(66476007)(4326008)(2906002)(8676002)(6486002)(83380400001)(66946007)(52116002)(508600001)(55236004)(38350700002)(38100700002)(316002)(1076003)(44832011)(6916009)(54906003)(6512007)(186003)(2616005)(26005)(6666004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: HtWNRrStBiMBuoAha6j9Bzh8TFSlG4RvDYdigtj73uwENbNmfwNrCzc9AydTP/QM5KxgWSQUJC79vXDdscEcSn/YTCdkLmuTBhfxd8Di6VoOHkdB/OIHZD9WKmRd52OGy2l1IytEye7VMdgzlER5CHqY2r6aQNVkT4fU6hP0ATwbFyejtycyemVkLN5mLEq3XKL3fgW03wZcy9Aoq92PT8eYWTTPypsO1X1bjJEBUp/WOm9+oTTPAZim0w/hT7xdQ+e9Ufg8ppeVf35cSjXDSjWNBZtKmJ1RaUXYI6FPoQrmV3ta/xPtR3eUvFh5Ksd+lV71MpaQe8C3Utex044y1hQiG/Zug+J2FK8rMctu091wmCeu5cvy29oFsnpvsnbjakdgLAQUDxZGyMPGZoLS3qMMMwU6ZKI21pjkuVdWz6TC3aCxvyCue75C6qVlcyvOALE+x4rKeSHSGhXC05lHUtV90Lkf3K/pXHpP94C4QUiF2VIsKnUuqOs6yLn8GFK0DQ5oExtY2k71WTflYyP2wvfes1G6Prjl3rrqsJDkg8ZGWiJyocuwHNWqXJgpBJ/8NljNWuVsgqOpAqKG7AYP5t7Gcx/I2oDZUJGiwpe7DvnZcStUz1shk/fEO/IoR6yg2KVwnjzXt7J2GC7F5M6oyWlteEtsI3wRjTAHvPI4sjy8cWxPkc+dy6DDnFdu5n/N2S0x09DwlPXUAJafaqVt910zU+EUcKk0/3ByoOveIX6Gw14F4PxMhBN+DWLzVibfekIqXIg9MTaN+hjNPGkStmxCMI/bz/ldqfZzEGzxY4ElKny6m3JXv06r0cp0GPF9veYU6pOBYT90y52x3uuYsUf9z5Vr+Wnl/zcQUXL7iEZoochCi8BPxWwDsX6cNgAM0flg0enfdqMNomTk4cMYQvYT0K8mQH0geAh9qAzTDk+B1PL3SeU6tfbMW7GqvWuyIbY1+8P0RtDeAOAPCguMZKrtqldlTSzPOCDMYRImucy0nPHYfPZNtaScwR4DE2xnTIGkFdMfAmXF6BICVKIIaTSaQkf//RIcVhHnoaYLB7Zqk9l3DAwmdWGJgrfcB+dclWqM1VqQ0OlJM7cIPq0LDuPh+31noWf/H6+/d8TMDUclRw+P83rkBW6SjtF3kjZgoSfmw7szBbKVwriXSJ6V8y/3HAq2bPLecKRDPszPg+wROlq0XVDsBHZ7FvJPtjMjKbgt01fQ4lnmm35i19G+mApHksf22oUj1cZShhyjTJ4A3qX79ibYD7xe4SQ8Eq/FffyPQYN34v6uSRfjE0SfphnHL4B4GmlhqyfgmSFcDpJYL2MOPXw+fyOgGxjxUGR5CZA01MRdWNhNHk685kI7/Iwor6iDEhu5wh2JHAuwcvtE8y4pOTdBwcuvbqlFhG1ZEmQCg42++AjdES72mA2xOaGAz1sXGSFO/Qlk8GGQC1XnNdA+iofq7y5ENrF6shWIBd1cjNFrsS1uixKkg27MMnrEQITzqLbuIW/EPLeIG7sXisAdW465mMm2HrMXEwfVl217rdph6zkSKMfEfLVp1QB5xH9YMDzNHj8wpdC08moisS5X/ObuCDdiS8/ObAR9WSUirJhBBEiRj1mxKkXeQJ8v2EhDZOEt8Mi8pcoLoGxY1I06u5tEP13TCBGlKE9JS4LUi5oZmCTBNowlBY1ZqksWMTVYDCD1u4nBVKywLgk8jzsWG3qh1qfVhyr+tDO4QRnW6ftsXeyXWaTB2relqQ== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92e2dee4-044d-48ba-1fea-08da4ecb8157 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5342.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2022 12:35:18.9300 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Al20dsGDtpvcBKQ6DhnBeD62v78e2hJj7Whl/9zaR09zCfMwPkt+9pa7KCPawTiX64xxPoKwXfuuIyTcnhfJgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4011 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean From: Ye Li issue: CAAM fails with key error when perform Modular Exponentiation using PKHA Block in CAAM Fix: add flush and invalidate dcache for keys, signature and output decrypted data processed by CAAM. Fixes: 34276478f7 (DM: crypto/fsl - Add Freescale rsa DM driver) Signed-off-by: Ye Li Reviewed-by: Gaurav Jain Acked-by: Peng Fan --- drivers/crypto/fsl/fsl_rsa.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/crypto/fsl/fsl_rsa.c b/drivers/crypto/fsl/fsl_rsa.c index 897ee855ea..335b7fe25a 100644 --- a/drivers/crypto/fsl/fsl_rsa.c +++ b/drivers/crypto/fsl/fsl_rsa.c @@ -6,6 +6,7 @@ #include #include +#include #include #include #include @@ -36,12 +37,21 @@ int fsl_mod_exp(struct udevice *dev, const uint8_t *sig, uint32_t sig_len, inline_cnstr_jobdesc_pkha_rsaexp(desc, &pkin, out, sig_len); + flush_dcache_range((ulong)sig, (ulong)sig + sig_len); + flush_dcache_range((ulong)prop->modulus, (ulong)(prop->modulus) + keylen); + flush_dcache_range((ulong)prop->public_exponent, + (ulong)(prop->public_exponent) + prop->exp_len); + flush_dcache_range((ulong)desc, (ulong)desc + (sizeof(uint32_t) * MAX_CAAM_DESCSIZE)); + flush_dcache_range((ulong)out, (ulong)out + sig_len); + ret = run_descriptor_jr(desc); if (ret) { debug("%s: RSA failed to verify: %d\n", __func__, ret); return -EFAULT; } + invalidate_dcache_range((ulong)out, (ulong)out + sig_len); + return 0; }