From patchwork Tue Jun 14 13:21:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Herbrechtsmeier X-Patchwork-Id: 1643301 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=weidmueller.onmicrosoft.com header.i=@weidmueller.onmicrosoft.com header.a=rsa-sha256 header.s=selector1-weidmueller-onmicrosoft-com header.b=ERGBSY4k; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LMpyK1MVGz9sGJ for ; Tue, 14 Jun 2022 23:22:33 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4E3B984328; Tue, 14 Jun 2022 15:22:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=weidmueller.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=weidmueller.onmicrosoft.com header.i=@weidmueller.onmicrosoft.com header.b="ERGBSY4k"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CC00484328; Tue, 14 Jun 2022 15:22:19 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FORGED_SPF_HELO,SPF_HELO_PASS,T_SCC_BODY_TEXT_LINE, T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02on0615.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe07::615]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3536584314 for ; Tue, 14 Jun 2022 15:22:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=weidmueller.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=stefan.herbrechtsmeier-oss@weidmueller.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gXupuAhQd7y5xolC8ATypAH1HUX5pIQI50jsKI7FriYP5BnuY3q18qEKXGyWChO70fyydJMY4rdzaoruC0UaOyDphp/umwS2IuDYMaPeLezrcMUys3+HrCdUeCvKIxPrX3c6fZ4N8hCv4SgpqbNo6DLYAjZ3ZJKzffZ/4vxcP4Lcuq76zU4ZmR6IEeKy+8GufzfqUYsqFnbx9OErjcaleuGhoH391MZ8JBIbPaUYJRtdqkGuh90vuqxuUiv+d8UBwvvw9LXVWnBpFPK2iddH3MuFEx1jlNMGVQ0f9SfRttzYMLKWpZmaWr+8WsErfRATVseL0TLEpfSYXCjVTx6pXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3Yv9lNyAviI/DQDI2yMRjLGzlA6AaV0KREosval4s+s=; b=hGYYq85R7P7D1dbKnSEpa3LJ13HS14MPPKCDd3wYOEZsDMm3PDO8Cxzf1cdH7t2HIedDQZ553k7LGYBxp+AvNHWv3PHP85njz2Yk5v22nwYEQxvVa2yxUzN03g20WGfhiyAPSwdKpZN2mpVwVTiJkqxkgvN44dm/09n7E9XZHvv2aHrEwBA1X+HrH6qLkLhXnVYyxReKhYB/BddLHBla/YLBsStc32uTtkhbr5YdWpmHW39q6eBp1aLQHdNh8qNjirb93H5lBaWKGCRulzCjQdXzbtSCWppo6/kx9m68mnEIQONxqu4LUN3V5oYEIEHe+tqriGs4aTjxn3KAV4Jaww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.onmicrosoft.com; s=selector1-weidmueller-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Yv9lNyAviI/DQDI2yMRjLGzlA6AaV0KREosval4s+s=; b=ERGBSY4krWvH7ajX7xFmaMyXWyiezx8efGPtNx4xcV/drnv73z+LHLE3xOnzBt+FHyAHfHP4MqM52b2MHAzowo78q2RFqraBfvOxczYl2bwkIwE1lIGbqNQtOKjABWZ6gJOP8o6qDo/Zby/duxOcnM7W1l3AWbXjIfQbTR+lWkA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from PAXPR08MB6969.eurprd08.prod.outlook.com (2603:10a6:102:1d8::23) by DBAPR08MB5846.eurprd08.prod.outlook.com (2603:10a6:10:1b0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.13; Tue, 14 Jun 2022 13:22:12 +0000 Received: from PAXPR08MB6969.eurprd08.prod.outlook.com ([fe80::f938:78d7:da4b:8d23]) by PAXPR08MB6969.eurprd08.prod.outlook.com ([fe80::f938:78d7:da4b:8d23%8]) with mapi id 15.20.5332.020; Tue, 14 Jun 2022 13:22:12 +0000 From: Stefan Herbrechtsmeier To: u-boot@lists.denx.de, Marek Vasut Cc: Stefan Herbrechtsmeier Subject: [PATCH 2/2] misc: usb251xb: Support 8/16 bit device tree values Date: Tue, 14 Jun 2022 15:21:31 +0200 Message-Id: <20220614132132.22329-2-stefan.herbrechtsmeier-oss@weidmueller.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220614132132.22329-1-stefan.herbrechtsmeier-oss@weidmueller.com> References: <20220614132132.22329-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-ClientProxiedBy: AS9PR07CA0046.eurprd07.prod.outlook.com (2603:10a6:20b:46b::9) To PAXPR08MB6969.eurprd08.prod.outlook.com (2603:10a6:102:1d8::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1ae89098-1e65-4cfd-ce60-08da4e08e42f X-MS-TrafficTypeDiagnostic: DBAPR08MB5846:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ucSa3h3AVuwZILbwOnq5lD0lFJ/+Gkn6yIGJnqtqonIj8ys3G93DjJQGPjdUNsYcYyRbhAaLRJow7YaOIFV82wR48g5dzY+SMkGNJL5o3K3okRbuclUr97R5SgMburR7CgysAQwodDLJG948Dyn1snyEiG9VjelfFUo8npH/fYlgirTogV5/fKAq2UZrpmd0zOt796s9qAMP9Y2SUY+c21Kg2yy3jgtQON1ns4M6QljAVmFV8qGZcS2J6Iyf3Xp9SoyhNAIHyr50CsJDAkKBhFFWSDxErskQ6byq196Q+N/s4qlCTwx6O58ic3Rxn27F2EX+UwZneeOdVKNGvJ4EfqRvUupzypiQfz7R3GKc/vvjTmQli95mk8uDIJrlOmamQFwpTZ6C+X06bgwM0TGYDrYkrPyjtwtTCe+2jFxC6j3sMTq8ARHNAm0knRNyvzdIAFq9Dkk/Dk+lvGLtJjHtoSr9IZUNTcbz7iq97g8ohBnq3Rf7FoJhEAgiIcykGwX/V5Uze/MzUYqAVflsAq81MK1WfgTCKyLWRI+XgSml5abHLG96o5I7rJY4PwC/DWmboI5rnegowHts8Hg96tJxjBCoiw0wWCCDqwESN3dZi2HGIz5dJR2RdQkiwpBd1NIpB5S5rHlCXecnUQBoT1fVSxv4hr6JfEO+tMHZhbs4z+21kRS2oR72K1fPXyq22zdJRu7gnhfdeTT0Am2P6ID6lsyTmKvLokEwNAfee46BcyINZucR9ZF0Jr+1c2RQX208LUcgMXD9pmjI5VffA0lSk4aOSwvGLfVigwjzQnokQns= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR08MB6969.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(36756003)(38350700002)(38100700002)(86362001)(83380400001)(26005)(6512007)(2616005)(107886003)(1076003)(6506007)(52116002)(316002)(2906002)(6666004)(6486002)(966005)(508600001)(6916009)(8936002)(186003)(66556008)(66476007)(8676002)(4326008)(5660300002)(66946007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: j3c2kvktXAn88MIajgIFTT9v6b+iS5cpYwlffE/gRCXfvo7llrtVWlYKH3NC3xM5Xs4UvnMsnp5Z3grSk3fmd5AJVndnk/hoDcnTJdNVShc4HwJnZg+YnakQpa+6WoQ7jsBqrL43/W1qpJmFbvMbKPdUFiePSXNkjYZb1U5yfz7vq11B9QQpAfBTTmb2VZaWcsBjPjOfhJMFNMl+TGdL2GQOshygcPF/amv/0K0UCUoz7hzYogk3kGscdbngYXEbRJdlsPqmXu5HAGK6UTPt5UP3Yq5tJ5c7TrqWNjjFMhV/fgD8H56lzsRNekP/4IcZvoBkmEz195fDpo+WVMUHS+yszZllwgXdeveilzkrfcBl6r4++D/Nsdc+b1luOwPRvt9aFM0Fs3F8erEfofXhE9batNKdIAYUEAN8jNSzq5EJr9SMzY9PVAo9+siEGLMY173UtJDIiSvV8pcg2SQa1i2X+jTMUnnTJr+ti0QButHx2aoCd3bfRB7fv0GvfIU+CxBklE1bObaqVNL1a2FlLxeLDHOwqu7airR3mPKq3WwTo8qwCLogdLnPDdI//0CPoW8gUsyVOUquK4Wz15+2qB6iyl2Em+6HbF3JoXel+xG9cLkxNvuvfo0atuWcAd5FYeh0QF5c76wwOK4iHLXPQDBypGr9fF0MVNPNO5G10I86/zFrC/2AEjwYsztniGjHtcLyqoAo+bc/GUP2MCAefBSTTKopJfrholSWkdaCwMQ7tjr2iB4Kb81WkQbUYizVCa6wKqRQMfdBgeye+Oo0HZopndjlAmEJlLfoBnIMD8YHIQzUUZjfA+PPBRT9IDjqC2yawD344GGJUDv4rn+nmaRRCteurq0sbchiGtQkLUOw9EBg0ohXct7I57IP1wOm+hrKXX1IJYTv6Toy/zOte0ow9a/V/beno8eeRglWUMxFtXpJsdyC/h+IX5il8hF9Q7zaCSWUCa68+xGrSeEZG6RtyDuazJRBSZ3CbncQIYw8TJTpxfxdLNpcV+m3xtR5rMoRMcolFc4JIuoRNcYILZG+wOEhB804M1KUVXC85TYoQPmH8p/wxF7M5u7Zrbu+Id/zvyHBncCtWw2oqBj90lZ84tB9W33kG5SFu+bHDDKXFfzEebCjnbE/UDhjr4+jOeGxqDp9cL6S4fq9VMLWWsupNHfpkqZ98krXdg5DuWZKIHyWRWTlx9ECO1+rTVASiznV+HMeGYKw55Bj0AfA5xAhX0/V2aS6AczMpAwMJHmY/mWoJUR0SmXQ9dvnIDX5Nqm5Pq/5FhsYGiI4Ayye+JNOXy0IaFqsftnU+jkTDY1ydU+Sj8WMey9V/lpa1KCNKgfceSjDBRYU5NLkKGwa4DQ4hobKZLXbduoDT7tNNbTh74rfZOTJzOVvAZUNYWN+HD8APix5f40Hj34aQQpidSoQqnbAcyyYmmFWaRqV0mn+xRga7U2TR95Lxd0VAnGNlpKEvSAx9w6FkNyu1MrzqvVS+ej0fUahnwBQzjB4KFwuK5wCpMXcvgLF8Upe71iN3Aua2hkrvJrNmVCxrhGrsnOE3wlKs9fU6BV4Le+Fyvgpt58X8C0VucQvKQRhXNdZBl5mcexlJuFl9ZRgK2+OFFGbzbj9yBMTFQfG1z9gFJnpktHDJTK43VVrKIlSqm5T4vok6cXA1K6cgRA0Cs7k8glF4a1qMnb3sSThfeoop5Wi8TmmWXQ1x8xoSgYhRcx6kxp2Rqy96z7mMJbblBo7QvcH4liysQrN6K0WBuvmjHU= X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ae89098-1e65-4cfd-ce60-08da4e08e42f X-MS-Exchange-CrossTenant-AuthSource: PAXPR08MB6969.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2022 13:22:12.3420 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fhShH4jTCk9fkW5von09kpGhnC8Hm5IxOVa6Xu/0QgMDuTG+Xy9hE5DkiyqHYrZ4zxzprLDSkDDGujikQvfRxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5846 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean From: Stefan Herbrechtsmeier The device tree binding [1] specify the vendor-id, product-id, device-id and language-id as 16 bit values and the linux driver reads the boost-up value as 8 bit value. [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/usb/usb251xb.txt Signed-off-by: Stefan Herbrechtsmeier Reviewed-by: Marek Vasut --- drivers/misc/usb251xb.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/misc/usb251xb.c b/drivers/misc/usb251xb.c index 077edc2504..a78ad1843a 100644 --- a/drivers/misc/usb251xb.c +++ b/drivers/misc/usb251xb.c @@ -400,14 +400,14 @@ static int usb251xb_of_to_plat(struct udevice *dev) } } - if (dev_read_u32(dev, "vendor-id", &hub->vendor_id)) - hub->vendor_id = USB251XB_DEF_VENDOR_ID; + hub->vendor_id = dev_read_u16_default(dev, "vendor-id", + USB251XB_DEF_VENDOR_ID); - if (dev_read_u32(dev, "product-id", &hub->product_id)) - hub->product_id = data->product_id; + hub->product_id = dev_read_u16_default(dev, "product-id", + data->product_id); - if (dev_read_u32(dev, "device-id", &hub->device_id)) - hub->device_id = USB251XB_DEF_DEVICE_ID; + hub->device_id = dev_read_u16_default(dev, "device-id", + USB251XB_DEF_DEVICE_ID); hub->conf_data1 = USB251XB_DEF_CONFIG_DATA_1; if (dev_read_bool(dev, "self-powered")) { @@ -513,11 +513,11 @@ static int usb251xb_of_to_plat(struct udevice *dev) if (!dev_read_u32(dev, "power-on-time-ms", &property_u32)) hub->power_on_time = min_t(u8, property_u32 / 2, 255); - if (dev_read_u32(dev, "language-id", &hub->lang_id)) - hub->lang_id = USB251XB_DEF_LANGUAGE_ID; + hub->lang_id = dev_read_u16_default(dev, "language-id", + USB251XB_DEF_LANGUAGE_ID); - if (!dev_read_u32(dev, "boost-up", &hub->boost_up)) - hub->boost_up = USB251XB_DEF_BOOST_UP; + hub->boost_up = dev_read_u8_default(dev, "boost-up", + USB251XB_DEF_BOOST_UP); cproperty_char = dev_read_string(dev, "manufacturer"); strlcpy(str, cproperty_char ? : USB251XB_DEF_MANUFACTURER_STRING,