| Message ID | 20220415140931.490047-3-vigneshr@ti.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | TI: Add support for AM62 SoC | expand |
On Fri, Apr 15, 2022 at 07:39:22PM +0530, Vignesh Raghavendra wrote: > From: Suman Anna <s-anna@ti.com> > > Add pinctrl macros for AM62x SoCs. These macro definitions are similar > to that of previous platforms, but adding new definitions to avoid any > naming confusions in the SoC dts files. > > checkpatch insists the following error exists: > ERROR: Macros with complex values should be enclosed in parentheses > > However, we do not need parentheses enclosing the values for this > macro as we do intend it to generate two separate values as has been > done for other similar platforms. > > Signed-off-by: Suman Anna <s-anna@ti.com> > Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> > --- > include/dt-bindings/pinctrl/k3.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/dt-bindings/pinctrl/k3.h b/include/dt-bindings/pinctrl/k3.h > index 63e038e36c..a5204ab91d 100644 > --- a/include/dt-bindings/pinctrl/k3.h > +++ b/include/dt-bindings/pinctrl/k3.h > @@ -41,4 +41,7 @@ > #define J721S2_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) > #define J721S2_WKUP_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) > > +#define AM62X_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) > +#define AM62X_MCU_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) > + > #endif I assume this is being submitted to upstream linux as well?
On 15/04/22 9:57 pm, Tom Rini wrote: > On Fri, Apr 15, 2022 at 07:39:22PM +0530, Vignesh Raghavendra wrote: >> From: Suman Anna <s-anna@ti.com> >> >> Add pinctrl macros for AM62x SoCs. These macro definitions are similar >> to that of previous platforms, but adding new definitions to avoid any >> naming confusions in the SoC dts files. >> >> checkpatch insists the following error exists: >> ERROR: Macros with complex values should be enclosed in parentheses >> >> However, we do not need parentheses enclosing the values for this >> macro as we do intend it to generate two separate values as has been >> done for other similar platforms. >> >> Signed-off-by: Suman Anna <s-anna@ti.com> >> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> >> --- >> include/dt-bindings/pinctrl/k3.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/include/dt-bindings/pinctrl/k3.h b/include/dt-bindings/pinctrl/k3.h >> index 63e038e36c..a5204ab91d 100644 >> --- a/include/dt-bindings/pinctrl/k3.h >> +++ b/include/dt-bindings/pinctrl/k3.h >> @@ -41,4 +41,7 @@ >> #define J721S2_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) >> #define J721S2_WKUP_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) >> >> +#define AM62X_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) >> +#define AM62X_MCU_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) >> + >> #endif > > I assume this is being submitted to upstream linux as well? > Sorry, forgot to include upstream ref.: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/dt-bindings/pinctrl/k3.h#n44
diff --git a/include/dt-bindings/pinctrl/k3.h b/include/dt-bindings/pinctrl/k3.h index 63e038e36c..a5204ab91d 100644 --- a/include/dt-bindings/pinctrl/k3.h +++ b/include/dt-bindings/pinctrl/k3.h @@ -41,4 +41,7 @@ #define J721S2_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) #define J721S2_WKUP_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) +#define AM62X_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) +#define AM62X_MCU_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) + #endif