From patchwork Fri Apr 15 11:10:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaurav Jain X-Patchwork-Id: 1617753 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=GScVRulf; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Kfttv1fXBz9sFq for ; Fri, 15 Apr 2022 21:11:35 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 178E781D5A; Fri, 15 Apr 2022 13:11:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="GScVRulf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 169398191C; Fri, 15 Apr 2022 13:11:28 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,SPF_HELO_PASS, T_SCC_BODY_TEXT_LINE,T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on060a.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0c::60a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3BCF981D5A for ; Fri, 15 Apr 2022 13:11:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=gaurav.jain@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iaqEUaYTBOIiNPechScM6bXHNtNSe1FNGJ5a3Uwoz1CPe0njeubxCm9WoG8jA9ZjZPRDamY8KsAgi4m/IVKdqahLbxHweVPIyfTfzvGunm8Bn5ZftT5aqU3fCDpzbfTuuwlHBMFIFVBgw4ZugVVrLIM6CPZ48ByEdi7pErJnEohd5KyH4Ie0aGW8pU5/o2vzs64EpGBeRIZRZ7AMEf2GMR9i9KP+J37wRPE/zC4AM5pWGMPs+cvllwTZEGmx+CpD7CLLE6ZTLDvCQHQeOrMbg437RvsacpHnGiJnGZfdLDlTRaMfHayREqDu74jollwrrsRJF0fyKs2+aAye+xKoKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fqnoLt3aJRz807C6K5nYlCV73Fc3Lrb7Uu7VGGsh05I=; b=M4wWpTSe/nXNkWjLWINedx/3A7TabrIWRYOkwH6IGJT+cWO52Q5FG3PaxWM3AQFIJfSp/2wvzJYeXbroUcpmv0vW2JRszVk67oKpfQg/X65JqBEvxDI2QShbqYlMhXaFG2KIXw8eSaGa0JZVlNkxG/e7X/y4fTBxwNNn7t5WT2ytUhrPkdR+SKvXbFye3TVrsRY/slM4JlWjZlwllWDyQeX2KG/bAqbGmQZ0XSqIvKCIm2gAoWkR6iHxo9st6XMAPATjl7uU7TlogURjncbWpN2zCKWuEPezxc2ss/4xXwFbRMYcJSNcb1y2mK/8eVTiAGA+nRWJNuJfe680xO9eMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fqnoLt3aJRz807C6K5nYlCV73Fc3Lrb7Uu7VGGsh05I=; b=GScVRulfUVlaIcIQAmns14xP3o2QV+lkezBteCs8Df7hY4i8rrha/UZ1wN7lx4ZKUW/xXsaU9ZYrGMa418oLdXtJVKzZMHHQ+N1xiQafuHv8c9aM0LI+V96+hYrJdNAGLWTx4soWn9gHz/xXQ5tVl8ViB90H4Pt195j98FxDixU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5342.eurprd04.prod.outlook.com (2603:10a6:803:46::16) by AM0PR04MB5953.eurprd04.prod.outlook.com (2603:10a6:208:10f::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Fri, 15 Apr 2022 11:11:23 +0000 Received: from VI1PR04MB5342.eurprd04.prod.outlook.com ([fe80::c587:139c:5129:6d02]) by VI1PR04MB5342.eurprd04.prod.outlook.com ([fe80::c587:139c:5129:6d02%7]) with mapi id 15.20.5144.030; Fri, 15 Apr 2022 11:11:22 +0000 From: Gaurav Jain To: Stefano Babic , u-boot@lists.denx.de Cc: Fabio Estevam , Peng Fan , Priyanka Jain , Ye Li , Horia Geanta , Silvano Di Ninno , Varun Sethi , "NXP i . MX U-Boot Team" , Gaurav Jain Subject: [PATCH] i.MX6SX: crypto/fsl: fix entropy delay value Date: Fri, 15 Apr 2022 16:40:49 +0530 Message-Id: <20220415111049.2565744-1-gaurav.jain@nxp.com> X-Mailer: git-send-email 2.25.1 X-ClientProxiedBy: SI2P153CA0013.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::12) To VI1PR04MB5342.eurprd04.prod.outlook.com (2603:10a6:803:46::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 650846b3-14d9-4703-b046-08da1ed0aca0 X-MS-TrafficTypeDiagnostic: AM0PR04MB5953:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2W4G+MV1coPuillkCyLK54Wtdd+aJSUVjIWB3CXknYzkJQHdLryhl/FcI5Qam9LqOk2FAu4KThHIvYqbqbAFNjpvEVbCRraypKYMlbJArUXz5YLIFuKkXUuP32+W/wLvKH1oSCdYolD9m4+T/bFU39CaWqbJSW5kUZ2mUi/wO2MNNfFSk0XdC+d9zlAcX4rnaBwW+p4/U22CKfBX/ystmxEr7EREnIdIpHva1RgWNa538meLUoom8Y0eJpQrkN/nNQOPVGnXGhwsgvTnncqSELR2c6SrZr3C4qJRAvCUoKwxZSzRgqteV3ffta8jYcUi9yRDAi15IzZkoDwqeslf9F0I26fubXOlpYeqq0u1UqEK2hpKLfzduqiP29FO2C8l9hm8mVPX5PPj2C83+xJekHauwxa1Rvdg7wSSylI8zZiQd6MIVE2NZUwz6atQbZ5EugquxDInsoN4abr1wZWKjbxKpOfQFIZVzojm/Rl6U6GO1iSgffwIbqR/GeG+nnwAjFcQXusiMt9vvlV0BFYKI1JraNDoGil/4drn19SWUNNT9exK6z0Skw8DCfbysQPKXQBarkEWgz8JWfO5KOk5+B82VCRIXgbR5uc/EXheFhYPQryl4sO+rmms2cs3OK+hLRfHgG6N2EoCXWwJdL9sNjSqkFp10arMQi2KhI5JXdnZIWzrubdSRmIWKqpjlkTkSc97jVh9Xm4Wp/rwuixRuw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5342.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(8936002)(4326008)(8676002)(83380400001)(508600001)(66946007)(66556008)(6486002)(6512007)(2616005)(26005)(1076003)(86362001)(186003)(6666004)(2906002)(52116002)(44832011)(55236004)(66476007)(6506007)(5660300002)(316002)(36756003)(38350700002)(38100700002)(54906003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: JGP10LoL23rNywjrVqsu4mqXqRA6yM9sMXrjWFHVUdzBOo6RlLhSBZdi3cV+vKCJce1dm2k4WmgRUD4/ntd4eVCkf5e9JE94Es3JJqxlVvL76JYD7G3eiHH+zpfBBK+LeKMGKiiOflE4Wne6SWDt88e0BUPj1Na4/BwrVq8aKZKKInZFAN6GqU09w04oIgi5g0uopMZaXowXrkFkrkcUDXJCp9M3AZDyRzJd8gPipZfHIqvPhJ1YlLy+1oylG0Llpk/3XToRJfotG63na0dJxZBAV0Athypkt22UGXF7m3clU+alO1MCrZMyyCL6VFOn/VKm7TstF8PLk2BD5aIC0o0wElNf+MSQy8C4rbTHAIpzkBf8umPOP2GC7UNgmhFz/eRpmBDt2LS8BdPP/iTjlhTYxRiwE3l613atcRLbyLgxQd/j3Ue9HVeDly0YpPLccdvA5DC1SRiZK1iiJWH+E+dZ0uHHBhmJDigWnfojuV869s8mYTVB9khmcTin34QSpvolqtg2XM/ruPIbdrTr6bTTv9OzHAAmTox4wkdF+ndh4NjetFRIFnR0pQuNFW2k1qGi2AAPjFEhVstvG/cdAkFWpXCQbpTkFe/Hgf416Nsqb5cTSjgch+nBSlVLqgQ3v5eMRKPoSz7AH6M93C7Ol94Hsa67fbZotsprG+neHp2EDY1puP7I2VnEalvif6VfW5YYAt2bZdei+yvbr3DSgD4LSSPcuvjehvcCB9gYtH469u3RdIFfym/0PZnStYpLxIDLvdRLZIZ35JT/mI4UcQ58BULSGPJbSvIwCxBX/NlQeWyF8IUkNnnAA3a/GknRxhK7Qj/9P75XFqcD0RqEntGC0O5zgf3IPM/tcAc0h9ycNTp2HyWQeK4D4e3JTG/cEvzWvv3EWnMbEWv3V6aSaPATHFFgOEV/nmUK+2ocApUNCdmWflVuLOG2kKMNswGrwiLrJkHV0stqfKYam0oLmlgaBVyBe4P1qVDoRUaVRRzOKfYtytil6Ugkp2/1s43Sw4pUA6td5ORduLdua8OR7M8Gs8IohrJOhz2eEb0d+svf7Yc1UwxTmgBSFLLOQ/29fSZG4xL+0PJ3ynd7tMnbTUas8L/TcuhCgSmAAp1L9EgXLTqj1U5C82BhBy9ZQSmC6cNoT+F+8zPXsEcmRo0Ew1jtsTG7KHB3oPjEzmVZ6XvpjggsDIc8mbL2NqEja1iZF0tt9DhBeF29swVu5+zYy+bRZ6iH0ftbR3+mGQQ4ex2GNnEPd4ABTGbLxni15cA+xNaR+fydsoLsMtdyvvuxzc+Kk9quykLHMKQ+mUiggNcHMEhiwgOVrSqmXaIyaMASG6gAuaU7XoY83LZRlS+bvmJmuyh+xiX4bOWZMC0ikiv95dIYoSuenm753VOCEIvm9gESL5301cZnIiXpoECnb1iRvNhLGF2qezPXTLOuTbnb1G9rVVgaOc3c6ItbDGYcj32RisLgVfiDJ5AkRBRZTKgbLT+IN+lKoWYz92bpLY0x2+wwAhptLW8wbGDnmN0ScraCD2VIu8GdmA2IqQwDW+zIgCq2goQ+oTpMIWdOydH0hXdMy3xaV6enLWCVtF9ZNs2qz9VsVLic5a6VslFzkdklwCoPsxdlzTZPZCjDy7VwpASZI/mf3is8IViBQ49M/XSIxQ8L8ml5fU13l8BxkWAY5U2hpBkyzdkdsE+H0wgpr+kfyN8HWgxctbF9BbwJ5E8dJujpmgYo7TDzUbMOM4GRcp9kZIIt26Ww+FQ7bl0= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 650846b3-14d9-4703-b046-08da1ed0aca0 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5342.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2022 11:11:22.7089 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K71rKoBYPQ6N18UFF6UTWEjIcmbydDE5PTiNoEil5KOeUVftD1tEXZ/3iVKLzSHj/niZX01dvopQjTuUfrEPng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5953 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean RNG Hardware error is reported due to incorrect entropy delay rng self test are run to determine the correct ent_dly. test is executed with different voltage and temperature to identify the worst case value for ent_dly. after adding a margin value(1000), ent_dly should be at least 12000. Signed-off-by: Gaurav Jain Reviewed-by: Fabio Estevam --- drivers/crypto/fsl/jr.c | 11 ++++++++++- include/fsl_sec.h | 6 +++++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/fsl/jr.c b/drivers/crypto/fsl/jr.c index 1d951cf0a6..85a3dac796 100644 --- a/drivers/crypto/fsl/jr.c +++ b/drivers/crypto/fsl/jr.c @@ -623,7 +623,7 @@ static void kick_trng(int ent_delay, ccsr_sec_t *sec) static int rng_init(uint8_t sec_idx, ccsr_sec_t *sec) { - int ret, gen_sk, ent_delay = RTSDCTL_ENT_DLY_MIN; + int ret, gen_sk, ent_delay = RTSDCTL_ENT_DLY; struct rng4tst __iomem *rng = (struct rng4tst __iomem *)&sec->rng; u32 inst_handles; @@ -652,6 +652,15 @@ static int rng_init(uint8_t sec_idx, ccsr_sec_t *sec) * the RNG. */ ret = instantiate_rng(sec_idx, sec, gen_sk); + /* + * entropy delay is calculated via self-test method. + * self-test are run across different volatge, temp. + * if worst case value for ent_dly is identified, + * loop can be skipped for that platform. + */ + if (IS_ENABLED(CONFIG_MX6SX)) + break; + } while ((ret == -1) && (ent_delay < RTSDCTL_ENT_DLY_MAX)); if (ret) { printf("SEC%u: Failed to instantiate RNG\n", sec_idx); diff --git a/include/fsl_sec.h b/include/fsl_sec.h index 7b6e3e2c20..d57c4ca820 100644 --- a/include/fsl_sec.h +++ b/include/fsl_sec.h @@ -48,7 +48,11 @@ struct rng4tst { u32 rtmctl; /* misc. control register */ u32 rtscmisc; /* statistical check misc. register */ u32 rtpkrrng; /* poker range register */ -#define RTSDCTL_ENT_DLY_MIN 3200 +#ifdef CONFIG_MX6SX +#define RTSDCTL_ENT_DLY 12000 +#else +#define RTSDCTL_ENT_DLY 3200 +#endif #define RTSDCTL_ENT_DLY_MAX 12800 union { u32 rtpkrmax; /* PRGM=1: poker max. limit register */