From patchwork Tue Mar 22 20:59:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 1608359 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=seco.com header.i=@seco.com header.a=rsa-sha256 header.s=selector1 header.b=gBL+N0eS; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KNP9N2ZJGz9s1l for ; Wed, 23 Mar 2022 08:03:52 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7D45383D57; Tue, 22 Mar 2022 22:02:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=seco.com header.i=@seco.com header.b="gBL+N0eS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 17E1F83C99; Tue, 22 Mar 2022 22:01:08 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02on0611.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe07::611]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B097483B80 for ; Tue, 22 Mar 2022 22:00:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sean.anderson@seco.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R1XG4qe3VsHjZ5uX18XxHGWmi9Fi8/GQ4u4QKEckNIUoD5cCEjY0kag2/IoHf2E7F9fTOzWL/3AGVm3x/u44xcwY8eo3e4RQ4HuHtH9PGMWBQnFYGYkML5NZ0INFQXffdQuCUX1wmJiFM1YEcXvmkUih3TYzdCpKdYVH0n+T3AVLGV2lpvSvuQcm3tZ3Yu0OC5rBXTyIxWLGsGfZSjD/giQcKY99ZfrCYgoh9s3Qb1U8cpBE5wVlyInfNllEFdukamYOLtX/2Cey+IgsKuUCZAcCzGOwMYL5T2ASCIO3iwsRCicMQcKDbNaX0UyvMmT91UcDz7Hq4in6QtP7ApBoKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qF+2R7l0XmyqwPnL6NYnJ8YkuQV1xMZhrltxXEKmt28=; b=NyyG6tj1ssyIu4J/wsJr3ctfwRnAmCO4FvQCwGt+as8uIQzK3zZhHuPQ3ApFDlc/xRVl1/KYSv8ft2cQ7H713SUcvR0m5osx60h9Qv1J4GwqD9uoxa7F5mZGE3iykhScgLA+CGMYPHGuXO2rbVOuEm7/pdxmcniMkWM6B0BPD/PLhTQe0GUJ1HW3y14IAYVoOD41/e6Gpux3Pvf51epOfEI4SibiAqGM7Y4K9D8ONPQrzqpGy11/QaMXjxH/xiLv6Y/dMYYmVLRfhaoQFL6Lsw9F6Kft1g0dEQjo2DzXr5wKrjDPR0qw4vBZCu42OlcyGMZzRVKRq4OZ1gxs71tK4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seco.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qF+2R7l0XmyqwPnL6NYnJ8YkuQV1xMZhrltxXEKmt28=; b=gBL+N0eSCz5RK2BWhbOT2Qej4IPEcx2Dg9P3xsQ9o1P9agvrS6mMJL1P9LEUK3Sb7fpqCJ9Zxlk38SzB3svBYvDML6UZPffWRAoOiR+KzOTg+mdKmgROClOmeOuLNkJsSO6AhkuVIJibqw3ryrAeTEf9T02TGzL/auT+SBj1sVBpBHzboDTwYMHhq+K3wpWnSk/evmrOtXuuMapM1X4aQaNZLRqXxGnX8nG0PmtuTifNbrROt/xer5XQJOzHGVfSXD+EO83yZRN93A2dUR+Qz31i4EYqobM6JooFKAu9dmxFbz/8Zc6gmi6YA5jJVMFlLVNrw3u8d6vyYdQUK4sS/A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=seco.com; Received: from DB7PR03MB4972.eurprd03.prod.outlook.com (2603:10a6:10:7d::22) by VI1PR03MB4591.eurprd03.prod.outlook.com (2603:10a6:803:5f::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.23; Tue, 22 Mar 2022 21:00:34 +0000 Received: from DB7PR03MB4972.eurprd03.prod.outlook.com ([fe80::2414:8ad5:9fd6:3bff]) by DB7PR03MB4972.eurprd03.prod.outlook.com ([fe80::2414:8ad5:9fd6:3bff%5]) with mapi id 15.20.5081.023; Tue, 22 Mar 2022 21:00:34 +0000 From: Sean Anderson To: Tom Rini Cc: Linus Walleij , Liviu Dudau , Andre Przywara , Simon Glass , u-boot@lists.denx.de, Sean Anderson Subject: [PATCH v3 24/29] serial: smh: Initialize serial only if semihosting is enabled Date: Tue, 22 Mar 2022 16:59:32 -0400 Message-Id: <20220322205938.1721846-25-sean.anderson@seco.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220322205938.1721846-1-sean.anderson@seco.com> References: <20220322205938.1721846-1-sean.anderson@seco.com> X-ClientProxiedBy: MN2PR20CA0012.namprd20.prod.outlook.com (2603:10b6:208:e8::25) To DB7PR03MB4972.eurprd03.prod.outlook.com (2603:10a6:10:7d::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9f8f93ff-0e38-4cff-bc24-08da0c470216 X-MS-TrafficTypeDiagnostic: VI1PR03MB4591:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bZn3/n1EpKdX/o9QzE5EnMWAHRi61iI6nkHLJY6xN+x28BzQ74L7F5L6RSk2/X1rq45Fx292Ba8sWIXQIaDgOwOfnFDtON4oJ69+F5coPjwh5xbzl9nIDPUNO0dUosoLQx2691PRzWWHPF2dtLBXcuzdLlDYSIUZDEWLeI63b/21czNaQttmO/EcJNJGo3/joPtXxrsvR1/yNbDiLlHrJzYg7n5fBjdui+PIYTa4LinLRN0zlE8Bfb7BdVF5LqQj8KW7GRfhFfSIirjcbqW+zTXGYLR34A5o6p8gNR5hdhgUvUD2W1mL+u8OsuvYnFfoGvrrtmMNmPGA92zrX4ahh4CO1ojjTwul+Akn+zz11QrwWzM7IxiecCDeUFA7WVu5P3Tfg96AiYsZv1lpwtphMBVr0eqB+vwOPdCfauZWs8+xo2fB9+pYbWqfTkLpDQrM825Txuz8329oQcsx1IgufsvNyKcfQKXqbYqQ8Wpe0Hov6QUjHcz1KjZyn9HL/KnforeveJN1CGloJeeLxRvVbvfAtqXgIl9aAfUVDSlcpYSD4C17TOG5u23o9b4PrN2eQRyhN87nmWw3C6/TfVngURxQkXzwTKEd8dcZFnV6Y95n/NjAQIgX+XAatFDjbKdiQCeQwWVZF9KW3qk6W0IhPzksrGKuvLoptzhW6a+EnyehCLlQNID5VwxXUmccnBf+sNl+GcOSyUYjV7QSaUsyuw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR03MB4972.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2906002)(83380400001)(6486002)(186003)(26005)(107886003)(38100700002)(38350700002)(2616005)(1076003)(6506007)(6512007)(6916009)(36756003)(52116002)(54906003)(316002)(4326008)(5660300002)(8676002)(66556008)(66476007)(508600001)(86362001)(66946007)(8936002)(44832011); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: djYAlYj8nTO7VTw8TLR7Ci0NV3/pmjlGyo2HhZvk1pG9HmUEDRTI7tafw/iTLDpgyrlKK2mzERZSyeYSbDCgNA/p/NqXsHwavJ6ZEODtVy9/QcjlzVexwC0+OikLcUmJv4aS6k1PSaJnyHlfqx4U63r5SlPuacZ4QLvNPpn5zbev1Kc+L92vttbQIxFRcKXSYRn4aS4DqRBGRHvhj/05K+R//EQmgJoLmOPNTj165yoaNDyKmDDOnJKqGItaDgXX1xH5M+y2tbJ8SPiCaAdHsij2lVsJGYaYDITx2482OGPbeKKeTapNzQ0+pfBSvcQvuLlmk1xtm2QzDo+GgHKeGW3/2U+Tn86yaCME4KUZ8uznMP1cT5CDuHifV1no9HhXmx3N7fIyvWYNK3v0Nfc2a70Rolj6ro1VMTNdASNgQUqs7WHD2xjXYUR9VAiiBJsJfaCe/DRSprH+EKG9A44VQCf1peFnTJgrHcY18Jok+YV9dNVgcjdaSzXqRygaIwAY+cRIiLYhzz3dsZVJKMaFdrTCmy8J8zKOC/xTropqB8E3iq2ZSkZnEnB2zICmvCzZmw7gC3dtuXFkRGfjnKVgnpVGeImH02qTct4YU8nSY1o+QYlROnrfnPE/RKNsb9bnWiDbgc1tdATTwqFdgOT7Jm4aJ4819p5s6falTneoZ38RntoZa2lZ9Bu7LLk07VcqO8NsfRGjZjIqq4RVODlA3oyqzHmU0/8dshga8J45Zz+/tjEWB8q/uIAXtQdMJXBGBlg0kBC36VJajNx0oOVSbNG/Vz1U5ar6ai4IoX8QvP6+JY77E2YcQFWroQeTVRznKL6IDgyhiDFU6+CY5iqVgJMJfhHrO7V5OizyNxCGA4kUm2tfxnmeC8FToAIY/8NcTrsslxF17T0JXlaM2690mpZJKUUhATjcWM7wwoyGXpMfZEgSb8vCNBSEedfODwDqMHl5y7/tffCibDUsHaHBvx/Gm3sMAkz3iedPWjZfIDlVJsgayCrnyE3ia03z9Df1Eh9iWUPXnwXpVoFF/oaM87fhtS9M8dSKLn51poNuLEqNYqKW4GyKFJ6wlHP4GGhPHCCCkWiStRb5narh5NKzFqADTSeuBqq19C0IAXLGY6WuedNEDn3EeVQBvRwSvcdtJkSpDqc4ZfpecBxYvkoEVwJfrbX7g/xwhmzUEcwe8gd8sPkHDzWR6dAl+52vRdiwoxAQ8lCf0W04URG3UfmUVJ/c7HYLMI8qNBzz1xVGHa2dzA3ufeLFuU45DH/y5bCGKRx0Q0r/dten0wUu90M0QZlDIfLNxxHCFRItkb4WUdMa/rA1FxF6ZN6E9qMU/6mmdGQqLZ6hM1vDfcaaW1vvpfERAmJdHewsfGIXr/NX/o9s4SwxOyyPou1glVvCNVFQ0dNImQN4y4Bgf/5x4ecuM40abFmapdKK0rUa5yviweRJ9KO8jDUAUSLwpGZkvlIgC74wVIf/fWEUE0zCUqZ7kQ== X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f8f93ff-0e38-4cff-bc24-08da0c470216 X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2022 21:00:34.4695 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mezpwTk4SWEb90iuiVKG4/goARHQUVJWidAPBAM0YCfQ8xpysggssTA2+NsUtT+Sp+vBw7zuDIw4cU8uSXkTJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB4591 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean If semihosting is disabled, then the user has no debugger attached, and will not see any messages. Don't create a serial device in this instance, to (hopefully) fall back on another working serial device. Signed-off-by: Sean Anderson --- (no changes since v2) Changes in v2: - New drivers/serial/serial_semihosting.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/serial/serial_semihosting.c b/drivers/serial/serial_semihosting.c index 7c7c5d9455..62b1b2241b 100644 --- a/drivers/serial/serial_semihosting.c +++ b/drivers/serial/serial_semihosting.c @@ -41,6 +41,13 @@ static const struct dm_serial_ops smh_serial_ops = { .getc = smh_serial_getc, }; +static int smh_serial_bind(struct udevice *dev) +{ + if (semihosting_enabled()) + return 0; + return -ENOENT; +} + static int smh_serial_probe(struct udevice *dev) { struct smh_serial_priv *priv = dev_get_priv(dev); @@ -52,6 +59,7 @@ static int smh_serial_probe(struct udevice *dev) U_BOOT_DRIVER(smh_serial) = { .name = "serial_semihosting", .id = UCLASS_SERIAL, + .bind = smh_serial_bind, .probe = smh_serial_probe, .priv_auto = sizeof(struct smh_serial_priv), .ops = &smh_serial_ops, @@ -122,7 +130,8 @@ struct serial_device serial_smh_device = { void smh_serial_initialize(void) { - serial_register(&serial_smh_device); + if (semihosting_enabled()) + serial_register(&serial_smh_device); } __weak struct serial_device *default_serial_console(void)