From patchwork Thu Mar 10 20:50:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 1604149 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=seco.com header.i=@seco.com header.a=rsa-sha256 header.s=selector1 header.b=ZPnYaCvW; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KF1Yy5fpKz9sGG for ; Fri, 11 Mar 2022 07:56:06 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3EBD783B33; Thu, 10 Mar 2022 21:54:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=seco.com header.i=@seco.com header.b="ZPnYaCvW"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4F01983B3D; Thu, 10 Mar 2022 21:52:26 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0626.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0d::626]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3B6B383AEE for ; Thu, 10 Mar 2022 21:51:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sean.anderson@seco.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N8ELDHhOSewEAH0JztbY6b7M7c3wZ4KM7Yx9xUM6tDPrumEzxzkgoHI7kXZiH3AtSCbDvWaJOUlkNt/mgGp1rlM5j8umZT+uXDWwU8LSSyJbA49oOUMnpIhNe3o7rdHsF1sksVAMaMOdGYY1HbD2k9sCcX34pQ/QswLP4yQ2HjdN9Vj5mLx4MwmFv7CDl53puwud2d7YDn0NBdUSbj2nUDkJxk2yqnkxJjoxcH44KLmA/vluHP6wK6+aZAo1Yd90uBNIApfsDE0X8wmTqRWu2y6sY9As9Tutq9vpR66bEYgv1+qx8wGZoAMa+pvqIVOsiEoBw51UbZ19JAK+/DD94w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uDYqsNtAiH50iFAti8QznsJQxO4uWolNZEyZTzRA3hA=; b=GxJwMOmKlBWcR97zpsNk0amnRIpLt5EFygJ6+zsy5zcrWHTBuHExWd4I2mSpZeOvAloNcZLHNq5o1ecQ/sOf9AlTpJTPwpfm//qX8/qUOOjHgvX/VhP5+e2R8waoSwUAvLh6wCE5jiNLa8MT5OaXv2g6Mt2/8qkbc6Fpv7ipKPNams7EwBWFa9bZwVRhbmCHD2L7QZTPiJbfpYZ3TdLO8NioSoeuNGvMHb5G/q2p8QC8WsqKgggpWcMEioknZC0fF1q9o9bEMD+LkFFv4IWb+6u+kf5qqeFby/qdZHVL62Ib+JNUnIco5P8kdsY+Q/lsPXyH45EcYsAHgqGD41jlxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seco.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uDYqsNtAiH50iFAti8QznsJQxO4uWolNZEyZTzRA3hA=; b=ZPnYaCvWqpBhwk0czP/ZtnqsNNTXI+QExMVnmTQVLegBHUMh1yD28wtv01l3ELN+qJgqOAMN9I1ZIFN4cKi9GJeb9+cKeaGsGYC2cMOjRSfdRzyNy0hzo5hk4ihixVlERHhSjliQCeg+0qeGcdxYv5GrypAGcBekbqbeWt6kNbM9YsRhQp7tff9/NFZXq1Y0zcF5BdB+HpdTr2y0SL0Eub7tgBc6uKsUqCmZ7zLexO8uqna37afTbQYtNlu5htYwbAEdYeFLMnF8NEr7Q2GHgW4ZPn5jYXMKPZ3ep6dWWzsNmm6jHG265IG3j7p89rAQ4w1W7yTVnP9akdgA1DcZGg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=seco.com; Received: from DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) by DB6PR0301MB2439.eurprd03.prod.outlook.com (2603:10a6:4:5b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Thu, 10 Mar 2022 20:51:49 +0000 Received: from DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::9860:b15b:f166:5896]) by DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::9860:b15b:f166:5896%3]) with mapi id 15.20.5061.022; Thu, 10 Mar 2022 20:51:49 +0000 From: Sean Anderson To: Tom Rini Cc: Liviu Dudau , u-boot@lists.denx.de, Simon Glass , Linus Walleij , Andre Przywara , Sean Anderson Subject: [PATCH v2 24/28] serial: smh: Initialize serial only if semihosting is enabled Date: Thu, 10 Mar 2022 15:50:54 -0500 Message-Id: <20220310205059.499269-25-sean.anderson@seco.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220310205059.499269-1-sean.anderson@seco.com> References: <20220310205059.499269-1-sean.anderson@seco.com> X-ClientProxiedBy: BL1PR13CA0433.namprd13.prod.outlook.com (2603:10b6:208:2c3::18) To DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8ef3c75c-50fc-4cc4-f49a-08da02d7cbf0 X-MS-TrafficTypeDiagnostic: DB6PR0301MB2439:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1c+7eeB594RkOD4YHJNBPaB5FvbcNebhup/U4a0+wEXGji8QlUeTDhWNwpdR/F5WhZnDpMU2LNze/Eo1aDFd/uEic2pLfk5E9TGOgf7XQpC8qfRmGU0tQlt72kx7VgIEofnyw4oeVZ+f2Z6SzXMxY7/Vxv+QvH4u+JGfflHuVpONrTu80IZ72+s3ZPX/KjmRsZPNVNbrtNEcJnnuxLO6gkAN4dP9AgTHXCC+A9NyFRjrdMebxXlXfsoh1UWOxJ8ed/d3+lXjzDfQZTRWWnYJT9x6CR5wlQJi60zmkRuNi3EOU0rOf4MDnEHyjGZqg3nYjdPSB7nvjYLZaIQ9973ajxwsDr9Fm5xx0jiHlavJSX0npt7j8SFdRfeTq3KHvQGeDlEEweJluS3vznq6exPwVWQOraP5VJXelbhs2pavTbwsOB2BL6eRiE1XMtefVxJTln5Um29WqVZVyG8eoiMoR4WqlACmkKid22MrSDbNU3ppXT45YAFgF9Y1hXxRQfBS6GjD3rhVoKklys3DbiTHOADKZZTzo2dgb4C8A2gFkL8/7Q1BMUub4Qo2zvoCUqCRxilehCL3ICEtZ4Ec8duwuA1kCV95ovIFe+F0Krxx6obGXkcI5MfRX3yJNx2Kl277qG5/2aj7nkWcoT3JqZ3OWRvGVama5c1rz/2Ps8GLl2/lmdqDvbgDTA3Sb3yTNTGwyxrfUTIUUiwnwVOrCCkeUA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR03MB4523.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(54906003)(66476007)(316002)(4326008)(66556008)(6916009)(8676002)(66946007)(44832011)(36756003)(86362001)(2906002)(38350700002)(38100700002)(5660300002)(8936002)(6512007)(52116002)(6666004)(6486002)(6506007)(508600001)(186003)(26005)(2616005)(107886003)(1076003)(83380400001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: uiCeOIyFKNAsJWfzOrZRxgwvVx0vemHacdIn0X3TfoccVH45ZSS3sKhy8mVtPNnDG7EAnEB20HQfMx08ZcPfGR10pT76PDUYxxdEObrSUl3b0m11jKDxM44L0AWsAPx4hU7lfr1Z1cvrFybvfJXVXdn8A2cAFuH7cw90LH8MyUnmLYgvVdBVjS6gUCNXHG2jrlxovyaj4zUXRAzCsceB/3T6I5ZIia4yG4Y1lTIAHgiIgtV0LQKlcKVRGxVqFJouFm+IkrFsqitMvitz28kCMg5xhuhrpFsrpcirn7YOFCAQEomORESvczqz9QCe+4nON1cUlqHKRJA6VQEtnzlgh9soIRKkPGZhyQZexObQU+PpsW9KDB/BbAmA74lia8Br8orG14Q9y0y67fu967cCQkBeYyY17gQQEOxbekfjFltQJvULMl8dhf9ME3WlPUN2a8wQlW0mzPDvBz4EegIgPTHoJwVD7ak564i+AmX6CJfilLmlovWydzOF3XUmWRzv9VJ1hbo5TQD3MEgyOqXy58xDRee2b8RgFRifhHYkVh9bZOdEgWaUCPMfvBT6ZcoJ9DydcXapEyl8qQ53NYrFw/tqSDZySyRYY+gSKI0CcZETerq+U48SPdaqj2O43HDGco+f4vFfGIJMFLg4LX9/vRtw8T9S/lx6FH7wsLxLV20d7HhEd+dtqkFER3iVVQlTm7lAii5inuY0nmOTijPN67c9AEqhFMFntoxo5sVqUv+CXr7y4evjxOjP1ejJRHYIErnxhFB37apBLstRVrj8CWRoPd5hcks8LcMJKA2S4VKglcJA7cAEMaq4UBUymJC2kxklrm6fPK3oBAEZEVVRCQ4F7M/qfrAxWzJG7hjbPfpuMHh9qSdNfCc199IQn+Bz+9DXaCuaFn4sBfNrVWgsx4CHEq07C20/Fkkl92+LjyYI2zyysJ7j1T6LzyRciA+iVTVxs7AC9isD4ajiQEdOTEDT9gCOIzqSa3R2inTKEWwng/R1vybbzK2OjQlpySRYIMTHCAG0LleWHwINkZz7IyjIIFbc9Sl3F3+XWGOnrjkEtiv+uPAeqhPulQKxLzUNNlZX3/d79sqoxu0o4qUjA0bGIgQtavGiD0dfcL+/rJVhEQo5TVcp7EZ/0JXHRJOcWp141gcazZqxgycSLPMSJui7kDqYscj1GWoLXK0joGAaj7FshaHlUQ4RxuV68SeBHeojrWCmfUcOYCZWYN4I4b595pkYLMuPSsxNcJlk2dsNJZYAKOj2geJ0YcS6Mw2dFJVYdTbUI/9AJyJ8T10d9XcQWpwOJFqRtZ1aGQcQ8O7wJEGkLWFcRMktkvoljcp3A7ZAp3T4gXn+be2wJxBWV+QF7w9zyYp1aSen3otZ5DhHSpALfFSWfPWtlSX6xrnfqMZcilzmX+A5XVPLZtiElklcm6EG1axDv8pialhBfRY1m6znmZwwU31hAQpjISfkF6AhLzXn94+wSE7J9Pok7GcLxU+KfMhMKY0BjtUaFZV271b7NTPJm8LfesORS5SRciUuCh4hZiL+c833XdY3eXZsjaBlUT2by9D9Bg8ECkYQ5f4wII1D1BMqUa7YFM3QaBVdybHnSd5vkjOOMPKfgwEYQQI7GHLdXXw824lqGho= X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ef3c75c-50fc-4cc4-f49a-08da02d7cbf0 X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2022 20:51:49.1324 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6UeJZcdAWCsn7ATylOaa1eLiOCanUE5AGWr0b7mLmWqHkKrO0r4X9emnQsa+ZcA8/TytuxkPQ2nfm6otMU5eCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0301MB2439 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean If semihosting is disabled, then the user has no debugger attached, and will not see any messages. Don't create a serial device in this instance, to (hopefully) fall back on another working serial device. Signed-off-by: Sean Anderson --- Changes in v2: - New drivers/serial/serial_semihosting.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/serial/serial_semihosting.c b/drivers/serial/serial_semihosting.c index b43683c6f1..706c1aabe1 100644 --- a/drivers/serial/serial_semihosting.c +++ b/drivers/serial/serial_semihosting.c @@ -25,9 +25,17 @@ static const struct dm_serial_ops smh_serial_ops = { .getc = smh_serial_getc, }; +static int smh_serial_bind(struct udevice *dev) +{ + if (semihosting_enabled()) + return 0; + return -ENOENT; +} + U_BOOT_DRIVER(smh_serial) = { .name = "serial_semihosting", .id = UCLASS_SERIAL, + .bind = smh_serial_bind, .ops = &smh_serial_ops, .flags = DM_FLAG_PRE_RELOC, }; @@ -83,7 +91,8 @@ struct serial_device serial_smh_device = { void smh_serial_initialize(void) { - serial_register(&serial_smh_device); + if (semihosting_enabled()) + serial_register(&serial_smh_device); } __weak struct serial_device *default_serial_console(void)