diff mbox series

[u-boot-marvell,05/10] pci: pci_mvebu, pci_aardvark: Fix size of configuration cache

Message ID 20211111153549.29111-6-kabel@kernel.org
State Accepted
Commit e967c84a6d211562ff800a00b0c30d7aa808ae4b
Delegated to: Stefan Roese
Headers show
Series PCI mvebu and aardvark changes | expand

Commit Message

Marek Behún Nov. 11, 2021, 3:35 p.m. UTC 
From: Marek Behún <marek.behun@nic.cz>

Since u32 takes up 4 bytes, we need to divide the number of u32s by 4
for cfgcache.

Signed-off-by: Marek Behún <marek.behun@nic.cz>
---
 drivers/pci/pci-aardvark.c | 2 +-
 drivers/pci/pci_mvebu.c    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Stefan Roese Nov. 12, 2021, 2:04 p.m. UTC | #1 
On 11/11/21 16:35, Marek Behún wrote:
> From: Marek Behún <marek.behun@nic.cz>
> 
> Since u32 takes up 4 bytes, we need to divide the number of u32s by 4
> for cfgcache.
> 
> Signed-off-by: Marek Behún <marek.behun@nic.cz>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   drivers/pci/pci-aardvark.c | 2 +-
>   drivers/pci/pci_mvebu.c    | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/pci-aardvark.c b/drivers/pci/pci-aardvark.c
> index 4e94b776c5..8abbc3ffe8 100644
> --- a/drivers/pci/pci-aardvark.c
> +++ b/drivers/pci/pci-aardvark.c
> @@ -202,7 +202,7 @@ struct pcie_advk {
>   	int			sec_busno;
>   	struct udevice		*dev;
>   	struct gpio_desc	reset_gpio;
> -	u32			cfgcache[0x34 - 0x10];
> +	u32			cfgcache[(0x34 - 0x10) / 4];
>   	bool			cfgcrssve;
>   };
>   
> diff --git a/drivers/pci/pci_mvebu.c b/drivers/pci/pci_mvebu.c
> index fde52ec99d..b545e62689 100644
> --- a/drivers/pci/pci_mvebu.c
> +++ b/drivers/pci/pci_mvebu.c
> @@ -93,7 +93,7 @@ struct mvebu_pcie {
>   	unsigned int mem_attr;
>   	unsigned int io_target;
>   	unsigned int io_attr;
> -	u32 cfgcache[0x34 - 0x10];
> +	u32 cfgcache[(0x34 - 0x10) / 4];
>   };
>   
>   /*
> 

Viele Grüße,
Stefan Roese
Stefan Roese Dec. 15, 2021, 10:57 a.m. UTC | #2 
On 11/11/21 16:35, Marek Behún wrote:
> From: Marek Behún <marek.behun@nic.cz>
> 
> Since u32 takes up 4 bytes, we need to divide the number of u32s by 4
> for cfgcache.
> 
> Signed-off-by: Marek Behún <marek.behun@nic.cz>

Applied to u-boot-marvell/master

Thanks,
Stefan

> ---
>   drivers/pci/pci-aardvark.c | 2 +-
>   drivers/pci/pci_mvebu.c    | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/pci-aardvark.c b/drivers/pci/pci-aardvark.c
> index 4e94b776c5..8abbc3ffe8 100644
> --- a/drivers/pci/pci-aardvark.c
> +++ b/drivers/pci/pci-aardvark.c
> @@ -202,7 +202,7 @@ struct pcie_advk {
>   	int			sec_busno;
>   	struct udevice		*dev;
>   	struct gpio_desc	reset_gpio;
> -	u32			cfgcache[0x34 - 0x10];
> +	u32			cfgcache[(0x34 - 0x10) / 4];
>   	bool			cfgcrssve;
>   };
>   
> diff --git a/drivers/pci/pci_mvebu.c b/drivers/pci/pci_mvebu.c
> index fde52ec99d..b545e62689 100644
> --- a/drivers/pci/pci_mvebu.c
> +++ b/drivers/pci/pci_mvebu.c
> @@ -93,7 +93,7 @@ struct mvebu_pcie {
>   	unsigned int mem_attr;
>   	unsigned int io_target;
>   	unsigned int io_attr;
> -	u32 cfgcache[0x34 - 0x10];
> +	u32 cfgcache[(0x34 - 0x10) / 4];
>   };
>   
>   /*
> 

Viele Grüße,
Stefan Roese
diff mbox series

Patch

diff --git a/drivers/pci/pci-aardvark.c b/drivers/pci/pci-aardvark.c
index 4e94b776c5..8abbc3ffe8 100644
--- a/drivers/pci/pci-aardvark.c
+++ b/drivers/pci/pci-aardvark.c
@@ -202,7 +202,7 @@  struct pcie_advk {
 	int			sec_busno;
 	struct udevice		*dev;
 	struct gpio_desc	reset_gpio;
-	u32			cfgcache[0x34 - 0x10];
+	u32			cfgcache[(0x34 - 0x10) / 4];
 	bool			cfgcrssve;
 };
 
diff --git a/drivers/pci/pci_mvebu.c b/drivers/pci/pci_mvebu.c
index fde52ec99d..b545e62689 100644
--- a/drivers/pci/pci_mvebu.c
+++ b/drivers/pci/pci_mvebu.c
@@ -93,7 +93,7 @@  struct mvebu_pcie {
 	unsigned int mem_attr;
 	unsigned int io_target;
 	unsigned int io_attr;
-	u32 cfgcache[0x34 - 0x10];
+	u32 cfgcache[(0x34 - 0x10) / 4];
 };
 
 /*