diff mbox series

[v2,4/9] usb: common: silence dubious errors

Message ID 20211015131525.721323-5-michael@walle.cc
State Accepted
Commit 7f79a2c2357d16fc9dd08e761e931a4f2169d625
Delegated to: Priyanka Jain
Headers show
Series usb: dwc3: add Layerscape SoC support | expand

Commit Message

Michael Walle Oct. 15, 2021, 1:15 p.m. UTC
Both dr_mode and maximum-speed properties are usually optional. Drivers
will still try to fetch the properties nonetheless, which leads to error
messages, although they are no errors. Change pr_err() to pr_debug().

Signed-off-by: Michael Walle <michael@walle.cc>
---
 drivers/usb/common/common.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Glass Oct. 24, 2021, 7:53 p.m. UTC | #1
On Fri, 15 Oct 2021 at 07:15, Michael Walle <michael@walle.cc> wrote:
>
> Both dr_mode and maximum-speed properties are usually optional. Drivers
> will still try to fetch the properties nonetheless, which leads to error
> messages, although they are no errors. Change pr_err() to pr_debug().
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  drivers/usb/common/common.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox series

Patch

diff --git a/drivers/usb/common/common.c b/drivers/usb/common/common.c
index 43564c9fba..ee0c064f1f 100644
--- a/drivers/usb/common/common.c
+++ b/drivers/usb/common/common.c
@@ -29,7 +29,7 @@  enum usb_dr_mode usb_get_dr_mode(ofnode node)
 
 	dr_mode = ofnode_read_string(node, "dr_mode");
 	if (!dr_mode) {
-		pr_err("usb dr_mode not found\n");
+		pr_debug("usb dr_mode not found\n");
 		return USB_DR_MODE_UNKNOWN;
 	}
 
@@ -64,7 +64,7 @@  enum usb_device_speed usb_get_maximum_speed(ofnode node)
 
 	max_speed = ofnode_read_string(node, "maximum-speed");
 	if (!max_speed) {
-		pr_err("usb maximum-speed not found\n");
+		pr_debug("usb maximum-speed not found\n");
 		return USB_SPEED_UNKNOWN;
 	}