diff mbox series

[3/7] imx: ventana: remove phy gpio reset from dt

Message ID 20210929220422.13661-3-tharvey@gateworks.com
State Accepted
Commit 54347344ce47005848333f953f401cd0c6f691f3
Delegated to: Stefano Babic
Headers show
Series [1/7] imx: ventana: add part command | expand

Commit Message

Tim Harvey Sept. 29, 2021, 10:04 p.m. UTC
We configure network phy configuration for internal delay, LED config,
and clock config. If we leave the phy reset gpio defined in dt the
kernel may issue a reset to the phy and break these configs. While some
may be handled by a kernel phy driver, others may not (typically LED
config).

Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
 board/gateworks/gw_ventana/gw_ventana.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Stefano Babic Oct. 7, 2021, 2:13 p.m. UTC | #1
> We configure network phy configuration for internal delay, LED config,
> and clock config. If we leave the phy reset gpio defined in dt the
> kernel may issue a reset to the phy and break these configs. While some
> may be handled by a kernel phy driver, others may not (typically LED
> config).
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/board/gateworks/gw_ventana/gw_ventana.c b/board/gateworks/gw_ventana/gw_ventana.c
index 79629828d0..16468060f7 100644
--- a/board/gateworks/gw_ventana/gw_ventana.c
+++ b/board/gateworks/gw_ventana/gw_ventana.c
@@ -1047,6 +1047,14 @@  int ft_board_setup(void *blob, struct bd_info *bd)
 		ft_board_pci_fixup(blob, bd);
 #endif
 
+	/*
+	 * remove reset gpio control as we configure the PHY registers
+	 * for internal delay, LED config, and clock config in the bootloader
+	 */
+	i = fdt_node_offset_by_compatible(blob, -1, "fsl,imx6q-fec");
+	if (i)
+		fdt_delprop(blob, i, "phy-reset-gpios");
+
 	/*
 	 * Peripheral Config:
 	 *  remove nodes by alias path if EEPROM config tells us the