| Message ID | 20210604045607.1003-2-linux.amoon@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Kever Yang |
| Headers | show |
| Series | [PATCHv3,1/3] pci: pcie_dw_rockchip: Fixed the below compilation error | expand |
Am Fri, Jun 04, 2021 at 04:56:06AM +0000 schrieb Anand Moon: > Drop the unused variable warning below. > > drivers/pci/pcie_dw_rockchip.c:161:6: warning: unused variable > 'val' [-Wunused-variable] > 161 | u32 val; > | ^~~ > Cc: Patrick Wildt <patrick@blueri.se> > Cc: Neil Armstrong <narmstrong@baylibre.com> > Cc: Kever Yang <kever.yang@rock-chips.com> > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > V1 > V2: Added Neil review tags. > --- > drivers/pci/pcie_dw_rockchip.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci/pcie_dw_rockchip.c > index 3ac2434b69..4e448c0a3d 100644 > --- a/drivers/pci/pcie_dw_rockchip.c > +++ b/drivers/pci/pcie_dw_rockchip.c > @@ -158,8 +158,6 @@ static inline void rk_pcie_writel_apb(struct rk_pcie *rk_pcie, u32 reg, > */ > static void rk_pcie_configure(struct rk_pcie *pci, u32 cap_speed) > { > - u32 val; > - > dw_pcie_dbi_write_enable(&pci->dw, true); > > clrsetbits_le32(pci->dw.dbi_base + PCIE_LINK_CAPABILITY, > -- > 2.31.1 > Reviewed-by: Patrick Wildt <patrick@blueri.se>
On 2021/6/4 下午12:56, Anand Moon wrote: > Drop the unused variable warning below. > > drivers/pci/pcie_dw_rockchip.c:161:6: warning: unused variable > 'val' [-Wunused-variable] > 161 | u32 val; > | ^~~ > Cc: Patrick Wildt <patrick@blueri.se> > Cc: Neil Armstrong <narmstrong@baylibre.com> > Cc: Kever Yang <kever.yang@rock-chips.com> > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> > Signed-off-by: Anand Moon <linux.amoon@gmail.com> Reviewed-by: Kever Yang <kever.yang@rock-chips.com> Thanks, - Kever > --- > V1 > V2: Added Neil review tags. > --- > drivers/pci/pcie_dw_rockchip.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci/pcie_dw_rockchip.c > index 3ac2434b69..4e448c0a3d 100644 > --- a/drivers/pci/pcie_dw_rockchip.c > +++ b/drivers/pci/pcie_dw_rockchip.c > @@ -158,8 +158,6 @@ static inline void rk_pcie_writel_apb(struct rk_pcie *rk_pcie, u32 reg, > */ > static void rk_pcie_configure(struct rk_pcie *pci, u32 cap_speed) > { > - u32 val; > - > dw_pcie_dbi_write_enable(&pci->dw, true); > > clrsetbits_le32(pci->dw.dbi_base + PCIE_LINK_CAPABILITY,
diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci/pcie_dw_rockchip.c index 3ac2434b69..4e448c0a3d 100644 --- a/drivers/pci/pcie_dw_rockchip.c +++ b/drivers/pci/pcie_dw_rockchip.c @@ -158,8 +158,6 @@ static inline void rk_pcie_writel_apb(struct rk_pcie *rk_pcie, u32 reg, */ static void rk_pcie_configure(struct rk_pcie *pci, u32 cap_speed) { - u32 val; - dw_pcie_dbi_write_enable(&pci->dw, true); clrsetbits_le32(pci->dw.dbi_base + PCIE_LINK_CAPABILITY,
Drop the unused variable warning below. drivers/pci/pcie_dw_rockchip.c:161:6: warning: unused variable 'val' [-Wunused-variable] 161 | u32 val; | ^~~ Cc: Patrick Wildt <patrick@blueri.se> Cc: Neil Armstrong <narmstrong@baylibre.com> Cc: Kever Yang <kever.yang@rock-chips.com> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- V1 V2: Added Neil review tags. --- drivers/pci/pcie_dw_rockchip.c | 2 -- 1 file changed, 2 deletions(-)