From patchwork Sun Apr 11 09:21:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1464766 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=C0uOxmdU; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FJ5yX570sz9sV5 for ; Sun, 11 Apr 2021 19:23:30 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 076A680201; Sun, 11 Apr 2021 11:23:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="C0uOxmdU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A40A9804E7; Sun, 11 Apr 2021 11:23:14 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AB4BC80201 for ; Sun, 11 Apr 2021 11:23:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1618132976; bh=HkN0favNjhdgZ+4Ufa/5x+F4iFvsC/NaWSru4sIP4fg=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=C0uOxmdUlXwHnT7zIozX7T78ZMW+2Tciu6Q28Fa/NFv3jtHJOZS2MkxigZFMihjNF V+L1gHMLybf2sv5a+5aWMUhyd9NiuRv2tP5HtOO2HkSaHVjAf6ZDOw+UrVhDdrpwYe aDXLtmT4lwT9X9kv+OIcqJIOIUMiW503qkpwQVJE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([62.143.247.63]) by mail.gmx.net (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1ML9uK-1lDRBq23gQ-00IFIc; Sun, 11 Apr 2021 11:22:56 +0200 From: Heinrich Schuchardt To: Tom Rini Cc: u-boot@lists.denx.de, Rick Chen , Simon Glass , Bin Meng , Joel Peshkin , Heinrich Schuchardt Subject: [PATCH v10 1/3] test: fix test/dm/regmap.c Date: Sun, 11 Apr 2021 11:21:56 +0200 Message-Id: <20210411092158.5244-2-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210411092158.5244-1-xypron.glpk@gmx.de> References: <20210411092158.5244-1-xypron.glpk@gmx.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:eLQ59nqQnMxlPie7osCfqCq9G/3DPbCYcMbPI3EzbYPLc2ezkJn 4O32V/RttTmo/WljpKNfflSd5K+xmvVAQixSaGyviPoLXuSnl8lrXGplYiQokD8kfQSkHu/ DiUnPgLCL/phwuh2pzD3VD/Uxm5YvChIIeP1zhUuVzVrBY59UVgz0zu12mpbVAIq5sOr1jV O8DWHkulcbrOhU97d5YJw== X-UI-Out-Filterresults: notjunk:1;V03:K0:uGCfYsgbb9I=:vt4Oy8jatEIb7SG3w8bZgf eTbjSH5n2/hk8j8uQfa3izHWsspNffEhp0wukKp+O9qeZLWFOZHtLRo6zDjxV9i8CL0lV+LL7 xwkbjDchaNVOltnBlSbyBrM32Tgp/IKUmH86WxNTe5siDpM37IKPsfsbkGHAVx/Y71oiIQrLE 3e6WBWIGcu1ugullrWJQ/9GJBT0zpzVPhQiosMfU+a2prAkGrLGVvVrIbiwRliHDi92Thzg7S GZdodafSZvjZ87c/0gvc25ivrZW3YgJBf+/iP+iohwR5ul0AbLbTqjkxWfEieRJVsED4NKlLU D3nOFVy08k10LDSI1nJbQAuC9onBcUL1Xo69Jsdizj0r3Pd+EQoQg/y9RGxyjSjc5ozGfdiIz dUrtmdjUn5rDNp+RwtVnAHvOblkoLvQJunruKYppkSnuiiEL76Xl61qvQYhpfEU7CeI74GLR/ qhitkqPRxPv6j1d68SbLBHn1Gke156MXy5Osm0ShOZ3CKaZ9ELmjmBwI9ayqasvZr5J9Rjepp hSjA4xAYyMLyYKcJ+/1UBklLg0CfUR9FuKMQG+I4m2X4A9gk6M9gbaL3+cVkDeTmTAhCvLaGV N+KfyA2oYqtrDT+3+uJUUaAZ+3WrcNKFF75xPV9mMumIRyr9YTGyozN+aeTd5PP3yl/fNN3Cm 02XvwPP8qrFSVPBNG6F2ONKgf1RePQXAh1XJH7tAKoyvq5pnNuq/sFw5LZFcgLbG5byredCba k0hfw8VaAmPwzx650CAmvhwYfj8RdlC7HK5B9OpPNXcBvW19OWohvflvy3YSNP2Kw6SLl4LDR 1JwU6tb6TteK6BJSNs+zomBD5254CFnexHlVMqf8VcF3NWWvsAxewdIHquBnF/VAL6vQxFUT9 0PrtkNHNnJNYyFD3mS9SP8+obuLacl8CMxr4fdqgSqq1fhGqTKLFCZwCd1lekc2ARpg7WaTtF nUguF2SijJFR4Yqguz74TAN5gVXXWp50Qzw51UWOzw2MaoZt4MrgBwCIN3AfNLlmNJigCQZT/ 3+023qcH6k7lrWFgUWAaVNoOrs0gTn+Jz/7fxmIkvVtMXWLretJkwvWvdzvNQdaxz1FlmUK6L OpvL/claXU0z92S6xCj2znsigt+E8lyQ0fu0bVkEEBNr61YCj1Nls7KKBkJ8M2doM7qHPWy4p xI6qNac7wYacWeB7Q7ls4vn8MjzTZEEAonE3GwWyrQ03+f9pqgjJ/Dw2+VJPPcs/XAEYU= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean regmap_read() only fills the first two bytes of val. The last two bytes are random data from the stack. This means the test will fail randomly. For low endian systems we could simply initialize val to 0 and get correct results. But tests should not depend on endianness. So let's use a pointer conversion instead. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- v10: new patch --- test/dm/regmap.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) -- 2.30.2 diff --git a/test/dm/regmap.c b/test/dm/regmap.c index 22a293096c..372a73ca0c 100644 --- a/test/dm/regmap.c +++ b/test/dm/regmap.c @@ -286,7 +286,8 @@ U_BOOT_DRIVER(regmap_test) = { static int dm_test_devm_regmap(struct unit_test_state *uts) { int i = 0; - u32 val; + u16 val; + void *valp = &val; u16 pattern[REGMAP_TEST_BUF_SZ]; u16 *buffer; struct udevice *dev; @@ -311,7 +312,7 @@ static int dm_test_devm_regmap(struct unit_test_state *uts) ut_assertok(regmap_write(priv->cfg_regmap, i, pattern[i])); } for (i = 0; i < REGMAP_TEST_BUF_SZ; i++) { - ut_assertok(regmap_read(priv->cfg_regmap, i, &val)); + ut_assertok(regmap_read(priv->cfg_regmap, i, valp)); ut_asserteq(val, buffer[i]); ut_asserteq(val, pattern[i]); } @@ -319,9 +320,9 @@ static int dm_test_devm_regmap(struct unit_test_state *uts) ut_asserteq(-ERANGE, regmap_write(priv->cfg_regmap, REGMAP_TEST_BUF_SZ, val)); ut_asserteq(-ERANGE, regmap_read(priv->cfg_regmap, REGMAP_TEST_BUF_SZ, - &val)); + valp)); ut_asserteq(-ERANGE, regmap_write(priv->cfg_regmap, -1, val)); - ut_asserteq(-ERANGE, regmap_read(priv->cfg_regmap, -1, &val)); + ut_asserteq(-ERANGE, regmap_read(priv->cfg_regmap, -1, valp)); return 0; }